From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BFFDC4320E for ; Thu, 29 Jul 2021 15:08:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2359160EC0 for ; Thu, 29 Jul 2021 15:08:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237518AbhG2PI0 (ORCPT ); Thu, 29 Jul 2021 11:08:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:59188 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229934AbhG2PIY (ORCPT ); Thu, 29 Jul 2021 11:08:24 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2E90D60EBC; Thu, 29 Jul 2021 15:08:19 +0000 (UTC) Date: Thu, 29 Jul 2021 17:08:16 +0200 From: Christian Brauner To: Vivek Goyal Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@lst.de, virtio-fs@redhat.com, v9fs-developer@lists.sourceforge.net, stefanha@redhat.com, miklos@szeredi.hu Subject: Re: [PATCH v3 0/3] support booting of arbitrary non-blockdevice file systems Message-ID: <20210729150816.jg5brzgt7nndhtdi@wittgenstein> References: <20210714202321.59729-1-vgoyal@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210714202321.59729-1-vgoyal@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 14, 2021 at 04:23:18PM -0400, Vivek Goyal wrote: > Hi, > > This is V3 of patches. Christoph had posted V2 here. > > https://lore.kernel.org/linux-fsdevel/20210621062657.3641879-1-hch@lst.de/ > > There was a small issue in last patch series that list_bdev_fs_names() > did not put an extra '\0' at the end as current callers were expecting. > > To fix this, I have modified list_bdev_fs_names() and split_fs_names() > to return number of null terminated strings they have parsed. And > modified callers to use that to loop through strings (instead of > relying on an extra null at the end). > > Christoph was finding it hard to find time so I took his patches, > added my changes in patch3 and reposting the patch series. > > I have tested it with 9p, virtiofs and ext4 filesystems as rootfs > and it works for me. lgtm, Acked-by: Christian Brauner From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 29 Jul 2021 17:08:16 +0200 From: Christian Brauner Message-ID: <20210729150816.jg5brzgt7nndhtdi@wittgenstein> References: <20210714202321.59729-1-vgoyal@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210714202321.59729-1-vgoyal@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Subject: Re: [Virtio-fs] [PATCH v3 0/3] support booting of arbitrary non-blockdevice file systems List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vivek Goyal Cc: miklos@szeredi.hu, linux-kernel@vger.kernel.org, virtio-fs@redhat.com, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, v9fs-developer@lists.sourceforge.net, hch@lst.de On Wed, Jul 14, 2021 at 04:23:18PM -0400, Vivek Goyal wrote: > Hi, > > This is V3 of patches. Christoph had posted V2 here. > > https://lore.kernel.org/linux-fsdevel/20210621062657.3641879-1-hch@lst.de/ > > There was a small issue in last patch series that list_bdev_fs_names() > did not put an extra '\0' at the end as current callers were expecting. > > To fix this, I have modified list_bdev_fs_names() and split_fs_names() > to return number of null terminated strings they have parsed. And > modified callers to use that to loop through strings (instead of > relying on an extra null at the end). > > Christoph was finding it hard to find time so I took his patches, > added my changes in patch3 and reposting the patch series. > > I have tested it with 9p, virtiofs and ext4 filesystems as rootfs > and it works for me. lgtm, Acked-by: Christian Brauner