From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D76C4338F for ; Thu, 29 Jul 2021 16:50:43 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DC4060EFD for ; Thu, 29 Jul 2021 16:50:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5DC4060EFD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 71EDC83167; Thu, 29 Jul 2021 18:50:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="taaIf9pJ"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5462883124; Thu, 29 Jul 2021 18:50:04 +0200 (CEST) Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B6AC082F3F for ; Thu, 29 Jul 2021 18:49:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72c.google.com with SMTP id az7so6609275qkb.5 for ; Thu, 29 Jul 2021 09:49:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=goPAgUHH/Hz05NsNc/OHxZkuxhwD1gsb/+gsnNGyX38=; b=taaIf9pJx+OzNwYXo8Y9aF3D98uSHUZRFzIXLbbGcOKiimqx1+wBMV4IhGSbY302GW inaVuRN1b58OoPFXX1j4bOm4HFT61rWbnymcKn2UYmXypS/1EwH1/IRIT2Qzg6T2Rswp /06+wNrCuXz7G52fSsqk94djaAz4JhA7J5NJE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=goPAgUHH/Hz05NsNc/OHxZkuxhwD1gsb/+gsnNGyX38=; b=AERA6P9G6FmKjpxP9Zm+MgpNCNPGLOkGrzE1hrL3cLjJyPMUYnk2ACP0bbrG0ELAw0 o+7vCfuIcNeH7DicXNNIWM0g/+HxPcxhCEJX1t3zTIMlBYSCUa7LN+W9C3XWycoiAUNi RwFEJhPqLq04pt/2ru7oTVUhw5VbCvbVYhYn2TdWOYGXrsN7A48WfK7YCnNGndeJbMIq uKq9L5mO6JTwfeeYh8RI6wq/s7KIxqHnNurbKteSHlxyVvYdoXL0hUXxTk1a/2K+o5d1 KNbkWEHmSj3fLznk09jYJRQd7WaQztMLpfi/1QnU1ITu36Qze0BG4E21ytFpUQNWQZDF BJdg== X-Gm-Message-State: AOAM532uN5d+hEtWQ78iGDvVa3u2Kuk7C8GQL+dWoP405RxEvh3kRwUm +KXFo+WZ5hwhnXha0tJgzOvw9Q== X-Google-Smtp-Source: ABdhPJys2EqZgSxCmnMY7y+FE+9Nsy/RgLq1R6K5HmK6/gCK2IECubSv5PN5zHzNoYgHMyt9SF6kLg== X-Received: by 2002:a05:620a:13f8:: with SMTP id h24mr6245619qkl.350.1627577396624; Thu, 29 Jul 2021 09:49:56 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-94ed-10de-2168-2ec4.res6.spectrum.com. [2603:6081:7b01:cbda:94ed:10de:2168:2ec4]) by smtp.gmail.com with ESMTPSA id t6sm2014647qkg.75.2021.07.29.09.49.55 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 29 Jul 2021 09:49:55 -0700 (PDT) Date: Thu, 29 Jul 2021 12:49:53 -0400 From: Tom Rini To: Patrick Delaunay Cc: u-boot@lists.denx.de, Marek =?iso-8859-1?Q?Beh=FAn?= , Simon Glass , Andre Przywara , Bin Meng , U-Boot STM32 Subject: Re: [RESEND PATCH] build: remove the variable NM in gen_ll_addressable_symbols.sh Message-ID: <20210729164953.GX9379@bill-the-cat> References: <20210721095553.RESEND.1.I550b95f6d12d59aeef5b744d837dbb360037d39e@changeid> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6JpNyHZcz5HoP3tQ" Content-Disposition: inline In-Reply-To: <20210721095553.RESEND.1.I550b95f6d12d59aeef5b744d837dbb360037d39e@changeid> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --6JpNyHZcz5HoP3tQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 21, 2021 at 09:56:07AM +0200, Patrick Delaunay wrote: > With LTO activated, the buildman tools failed with an error on my > configuration (Ubuntu 20.04, stm32mp15_trusted_defconfig) with the error: >=20 > ../arm-linux-gnueabi/bin/nm: > scripts/gen_ll_addressable_symbols.sh: file format not recognized >=20 > It seems the shell variable initialization NM=3D$(NM) is not correctly > interpreted when shell is started in the Makefile, but I have not this > issue when I compile the same target without buildman. >=20 > I don't found the root reason of the problem but I solve it by > providing $(NM) as script parameter instead using a shell variable. >=20 > The command executed is identical: >=20 > cmd_keep-syms-lto.c :=3D NM=3Darm-none-linux-gnueabihf-gcc-nm \ > u-boot/scripts/gen_ll_addressable_symbols.sh arch/arm/cpu/built-in.o \ > .... net/built-in.o >keep-syms-lto.c >=20 > cmd_keep-syms-lto.c :=3D u-boot/scripts/gen_ll_addressable_symbols.sh \ > arm-none-linux-gnueabihf-gcc-nm arch/arm/cpu/built-in.o \ > ... net/built-in.o > keep-syms-lto.c >=20 > Reviewed-by: Simon Glass > Signed-off-by: Patrick Delaunay Applied to u-boot/master, thanks! --=20 Tom --6JpNyHZcz5HoP3tQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEC3DEACgkQFHw5/5Y0 tyyCJQv/dHslWFRPp4iiqRwb66X1yUkDuudbm8qu73D3Oq246bgA4gKY+f8+tLkd UqwfmwBxYt/Uw0qQxa350fl2TOd2ekVrKbIjOjgdIU+oefFl/GFY+3WMIwMfWD0U 6u6YcXHunkDr5AG5lNXzsNqSp7OgcECEvOQYJOjyS9TGMLi493zITlnTTHB72/Q+ cUdU8dW5o9M/4KncRCo1h7r4JnvcA4S3Jl1pSRHlpYntdTG+5SZLDCnLvUtn81mO gkclfVOWZUwIeKAPzrFAJp5ulebkADYuOxbM8U/3XFwMRNzHN1a7xd9j2511J3jX A1PzMLDhL7Fc64F8mJoVopF2/QIDkw7gwEgZK5gG8olvuvG4+RP59ut6xQeDd+78 wN/q5oR2glnWocnmT9rkbNO2X8WJXO4pUo3LS3qxA++Rh3ko3WhbQh39otdOA0BO /Nc7O0ZzHllK7Zlt5KOdwABM6mqHc0WKFa86kcb9AfUxyiuga8wKiBHhCGQg9S2s 4ffMNcZ1 =c3oZ -----END PGP SIGNATURE----- --6JpNyHZcz5HoP3tQ--