From: Sean Paul <sean@poorly.run> To: Douglas Anderson <dianders@chromium.org> Cc: dri-devel@lists.freedesktop.org, tzimmermann@suse.de, linux-arm-msm@vger.kernel.org, a.hajda@samsung.com, sam@ravnborg.org, airlied@linux.ie, bjorn.andersson@linaro.org, daniel@ffwll.ch, devicetree@vger.kernel.org, rodrigo.vivi@intel.com, jonas@kwiboo.se, narmstrong@baylibre.com, Laurent.pinchart@ideasonboard.com, robert.foss@linaro.org, jernej.skrabec@gmail.com, mripard@kernel.org, linus.walleij@linaro.org, maarten.lankhorst@linux.intel.com, rajeevny@codeaurora.org, lyude@redhat.com, thierry.reding@gmail.com, steev@kali.org, Sandeep Panda <spanda@codeaurora.org>, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/6] drm/panel: atna33xc20: Fix the Samsung ATNA33XC20 panel Date: Thu, 29 Jul 2021 15:42:46 -0400 [thread overview] Message-ID: <20210729194242.GB31127@art_vandelay> (raw) In-Reply-To: <20210728164557.1882787-1-dianders@chromium.org> On Wed, Jul 28, 2021 at 09:45:51AM -0700, Douglas Anderson wrote: > > The overall goal of this series is to make the Samsung ATNA33XC20 > panel work more properly. As part of this, we have: > * A bugfix for the recently abstracted DP AUX backlight code. > * A bugfix for the sequencing of the ti-sn65dsi86 bridge driver. > * Removal of the panel from panel-simple and moving it to its own > driver. > > If the bugfixes look good but the rest of the series needs work then > those could land early on their own. There's no real compile time > dependency on the bugfixes, things are just glitchier without them. > > NOTE: this series will (slightly) conflict with my other recent series > making eDP panels probable [1]. The conflict is easy to resolve and > I'm happy to repost either once the other lands. It should be noted > that the fact that the Samsung ATNA33XC20 needs its own panel driver > means that it _can't_ handled as a probed driver. I think this is > fine, at least for now. I don't think it would be easy to make a > unified design with this panel and other panels given that it's an > AMOLED panel and has a whole bunch of different components on board. > > [1] https://lore.kernel.org/r/20210723002146.1962910-1-dianders@chromium.org/ > > > Douglas Anderson (6): Hi Doug, Thanks for the patchset, it all looks to me. For all 6: Reviewed-by: Sean Paul <seanpaul@chromium.org> Sean > drm/dp: Don't zero PWMGEN_BIT_COUNT when driver_pwm_freq_hz not > specified > drm/bridge: ti-sn65dsi86: Fix power off sequence > drm/bridge: ti-sn65dsi86: Add some 100 us delays > Revert "drm/panel-simple: Add Samsung ATNA33XC20" > Revert "drm/panel-simple: Support for delays between GPIO & regulator" > drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 17 +- > drivers/gpu/drm/drm_dp_helper.c | 10 +- > drivers/gpu/drm/panel/Kconfig | 12 + > drivers/gpu/drm/panel/Makefile | 1 + > .../gpu/drm/panel/panel-samsung-atna33xc20.c | 366 ++++++++++++++++++ > drivers/gpu/drm/panel/panel-simple.c | 61 --- > 6 files changed, 398 insertions(+), 69 deletions(-) > create mode 100644 drivers/gpu/drm/panel/panel-samsung-atna33xc20.c > > -- > 2.32.0.432.gabb21c7263-goog > -- Sean Paul, Software Engineer, Google / Chromium OS
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <sean@poorly.run> To: Douglas Anderson <dianders@chromium.org> Cc: narmstrong@baylibre.com, airlied@linux.ie, Sandeep Panda <spanda@codeaurora.org>, dri-devel@lists.freedesktop.org, bjorn.andersson@linaro.org, a.hajda@samsung.com, thierry.reding@gmail.com, Laurent.pinchart@ideasonboard.com, sam@ravnborg.org, jernej.skrabec@gmail.com, devicetree@vger.kernel.org, tzimmermann@suse.de, jonas@kwiboo.se, linux-arm-msm@vger.kernel.org, steev@kali.org, rodrigo.vivi@intel.com, rajeevny@codeaurora.org, linux-kernel@vger.kernel.org, robert.foss@linaro.org Subject: Re: [PATCH 0/6] drm/panel: atna33xc20: Fix the Samsung ATNA33XC20 panel Date: Thu, 29 Jul 2021 15:42:46 -0400 [thread overview] Message-ID: <20210729194242.GB31127@art_vandelay> (raw) In-Reply-To: <20210728164557.1882787-1-dianders@chromium.org> On Wed, Jul 28, 2021 at 09:45:51AM -0700, Douglas Anderson wrote: > > The overall goal of this series is to make the Samsung ATNA33XC20 > panel work more properly. As part of this, we have: > * A bugfix for the recently abstracted DP AUX backlight code. > * A bugfix for the sequencing of the ti-sn65dsi86 bridge driver. > * Removal of the panel from panel-simple and moving it to its own > driver. > > If the bugfixes look good but the rest of the series needs work then > those could land early on their own. There's no real compile time > dependency on the bugfixes, things are just glitchier without them. > > NOTE: this series will (slightly) conflict with my other recent series > making eDP panels probable [1]. The conflict is easy to resolve and > I'm happy to repost either once the other lands. It should be noted > that the fact that the Samsung ATNA33XC20 needs its own panel driver > means that it _can't_ handled as a probed driver. I think this is > fine, at least for now. I don't think it would be easy to make a > unified design with this panel and other panels given that it's an > AMOLED panel and has a whole bunch of different components on board. > > [1] https://lore.kernel.org/r/20210723002146.1962910-1-dianders@chromium.org/ > > > Douglas Anderson (6): Hi Doug, Thanks for the patchset, it all looks to me. For all 6: Reviewed-by: Sean Paul <seanpaul@chromium.org> Sean > drm/dp: Don't zero PWMGEN_BIT_COUNT when driver_pwm_freq_hz not > specified > drm/bridge: ti-sn65dsi86: Fix power off sequence > drm/bridge: ti-sn65dsi86: Add some 100 us delays > Revert "drm/panel-simple: Add Samsung ATNA33XC20" > Revert "drm/panel-simple: Support for delays between GPIO & regulator" > drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 17 +- > drivers/gpu/drm/drm_dp_helper.c | 10 +- > drivers/gpu/drm/panel/Kconfig | 12 + > drivers/gpu/drm/panel/Makefile | 1 + > .../gpu/drm/panel/panel-samsung-atna33xc20.c | 366 ++++++++++++++++++ > drivers/gpu/drm/panel/panel-simple.c | 61 --- > 6 files changed, 398 insertions(+), 69 deletions(-) > create mode 100644 drivers/gpu/drm/panel/panel-samsung-atna33xc20.c > > -- > 2.32.0.432.gabb21c7263-goog > -- Sean Paul, Software Engineer, Google / Chromium OS
next prev parent reply other threads:[~2021-07-29 19:42 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-28 16:45 [PATCH 0/6] drm/panel: atna33xc20: Fix the Samsung ATNA33XC20 panel Douglas Anderson 2021-07-28 16:45 ` Douglas Anderson 2021-07-28 16:45 ` [PATCH 1/6] drm/dp: Don't zero PWMGEN_BIT_COUNT when driver_pwm_freq_hz not specified Douglas Anderson 2021-07-28 16:45 ` Douglas Anderson 2021-07-28 16:45 ` [PATCH 2/6] drm/bridge: ti-sn65dsi86: Fix power off sequence Douglas Anderson 2021-07-28 16:45 ` Douglas Anderson 2021-07-29 11:47 ` Robert Foss 2021-07-29 11:47 ` Robert Foss 2021-07-28 16:45 ` [PATCH 3/6] drm/bridge: ti-sn65dsi86: Add some 100 us delays Douglas Anderson 2021-07-28 16:45 ` Douglas Anderson 2021-07-29 11:48 ` Robert Foss 2021-07-29 11:48 ` Robert Foss 2021-07-28 16:45 ` [PATCH 4/6] Revert "drm/panel-simple: Add Samsung ATNA33XC20" Douglas Anderson 2021-07-28 16:45 ` Douglas Anderson 2021-07-28 16:45 ` [PATCH 5/6] Revert "drm/panel-simple: Support for delays between GPIO & regulator" Douglas Anderson 2021-07-28 16:45 ` Douglas Anderson 2021-07-28 16:45 ` [PATCH 6/6] drm/panel: atna33xc20: Introduce the Samsung ATNA33XC20 panel Douglas Anderson 2021-07-28 16:45 ` Douglas Anderson 2021-07-29 19:42 ` Sean Paul [this message] 2021-07-29 19:42 ` [PATCH 0/6] drm/panel: atna33xc20: Fix " Sean Paul
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210729194242.GB31127@art_vandelay \ --to=sean@poorly.run \ --cc=Laurent.pinchart@ideasonboard.com \ --cc=a.hajda@samsung.com \ --cc=airlied@linux.ie \ --cc=bjorn.andersson@linaro.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=jernej.skrabec@gmail.com \ --cc=jonas@kwiboo.se \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lyude@redhat.com \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=narmstrong@baylibre.com \ --cc=rajeevny@codeaurora.org \ --cc=robert.foss@linaro.org \ --cc=rodrigo.vivi@intel.com \ --cc=sam@ravnborg.org \ --cc=spanda@codeaurora.org \ --cc=steev@kali.org \ --cc=thierry.reding@gmail.com \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.