From: Aurabindo Pillai <aurabindo.pillai@amd.com>
To: <amd-gfx@lists.freedesktop.org>
Cc: Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>,
Eryk.Brol@amd.com, Jaehyun Chung <jaehyun.chung@amd.com>,
Sunpeng.Li@amd.com, Harry.Wentland@amd.com,
Qingqing.Zhuo@amd.com, Rodrigo.Siqueira@amd.com,
Anson.Jacob@amd.com, Aurabindo.Pillai@amd.com,
Jaehyun Chung <jaehyum.chung@amd.com>,
Bhawanpreet.Lakha@amd.com, bindu.r@amd.com
Subject: [PATCH 6/9] drm/amd/display: Add check for validating unsupported ODM plus MPO case
Date: Thu, 29 Jul 2021 16:37:09 -0400 [thread overview]
Message-ID: <20210729203712.1566129-7-aurabindo.pillai@amd.com> (raw)
In-Reply-To: <20210729203712.1566129-1-aurabindo.pillai@amd.com>
From: Jaehyun Chung <jaehyum.chung@amd.com>
[Why]
We do not currently support ODM plus MPO on only one side of the
screen. This unsupported case causes validation calculations to
divide by zero due to invalid viewport values.
[How]
Add stopgap for the validation of ODM plus MPO on one side of
screen case.
Reviewed-by: Dmytro Laktyushkin <Dmytro.Laktyushkin@amd.com>
Acked-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Signed-off-by: Jaehyun Chung <jaehyun.chung@amd.com>
---
drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
index 1596f6b7fed7..f1b8c1292035 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_resource.c
@@ -1051,6 +1051,11 @@ bool resource_build_scaling_params(struct pipe_ctx *pipe_ctx)
/* depends on scaling ratios and recout, does not calculate offset yet */
calculate_viewport_size(pipe_ctx);
+ /* Stopgap for validation of ODM + MPO on one side of screen case */
+ if (pipe_ctx->plane_res.scl_data.viewport.height < 1 ||
+ pipe_ctx->plane_res.scl_data.viewport.width < 1)
+ return false;
+
/*
* LB calculations depend on vp size, h/v_active and scaling ratios
* Setting line buffer pixel depth to 24bpp yields banding
--
2.32.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-07-29 20:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 20:37 [PATCH 0/9] DC patches for Aug 2, 2021 Aurabindo Pillai
2021-07-29 20:37 ` [PATCH 1/9] drm/amd/display: Assume LTTPR interop for DCN31+ Aurabindo Pillai
2021-07-29 20:37 ` [PATCH 2/9] drm/amd/display: Fix Dynamic bpp issue with 8K30 with Navi 1X Aurabindo Pillai
2021-07-29 20:37 ` [PATCH 3/9] drm/amd/display: Increase stutter watermark for dcn303 Aurabindo Pillai
2021-07-29 20:37 ` [PATCH 4/9] drm/amd/display: Remove redundant vblank workqueues in DM Aurabindo Pillai
2021-07-29 20:37 ` [PATCH 5/9] drm/amd/display: Fix resetting DCN3.1 HW when resuming from S4 Aurabindo Pillai
2021-07-29 20:37 ` Aurabindo Pillai [this message]
2021-07-29 20:37 ` [PATCH 7/9] drm/amd/display: workaround for hard hang on HPD on native DP Aurabindo Pillai
2021-07-29 20:37 ` [PATCH 8/9] drm/amd/display: [FW Promotion] Release 0.0.77 Aurabindo Pillai
2021-07-29 20:37 ` [PATCH 9/9] drm/amd/display: 3.2.147 Aurabindo Pillai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210729203712.1566129-7-aurabindo.pillai@amd.com \
--to=aurabindo.pillai@amd.com \
--cc=Anson.Jacob@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Dmytro.Laktyushkin@amd.com \
--cc=Eryk.Brol@amd.com \
--cc=Harry.Wentland@amd.com \
--cc=Qingqing.Zhuo@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Sunpeng.Li@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bindu.r@amd.com \
--cc=jaehyum.chung@amd.com \
--cc=jaehyun.chung@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.