All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Ryoga Saito <contact@proelbtn.com>, netfilter-devel@vger.kernel.org
Cc: kbuild-all@lists.01.org, pablo@netfilter.org,
	stefano.salsano@uniroma2.it, andrea.mayer@uniroma2.it,
	davem@davemloft.net, kuba@kernel.org, yoshfuji@linux-ipv6.org,
	dsahern@kernel.org, Ryoga Saito <contact@proelbtn.com>
Subject: Re: [PATCH v2 1/2] netfilter: add new sysctl toggle for lightweight tunnel netfilter hooks
Date: Thu, 29 Jul 2021 20:41:07 +0800	[thread overview]
Message-ID: <202107292057.KLbvBPA0-lkp@intel.com> (raw)
In-Reply-To: <76d5da6c73eaaa0da2e88b6059caec078bca89e5.1627546390.git.contact@proelbtn.com>

[-- Attachment #1: Type: text/plain, Size: 2795 bytes --]

Hi Ryoga,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on nf-next/master]
[also build test WARNING on nf/master ipvs/master linus/master v5.14-rc3 next-20210728]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Ryoga-Saito/net-add-netfilter-hooks-to-track-SRv6-encapsulated-flows/20210729-165540
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next.git master
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/94a2d9ee8f1c6c8ad998758c4f494719ea7b9a9d
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Ryoga-Saito/net-add-netfilter-hooks-to-track-SRv6-encapsulated-flows/20210729-165540
        git checkout 94a2d9ee8f1c6c8ad998758c4f494719ea7b9a9d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> net/netfilter/nf_conntrack_lwtunnel.c:26:5: warning: no previous prototype for 'nf_conntrack_lwtunnel_sysctl_handler' [-Wmissing-prototypes]
      26 | int nf_conntrack_lwtunnel_sysctl_handler(struct ctl_table *table, int write,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/nf_conntrack_lwtunnel_sysctl_handler +26 net/netfilter/nf_conntrack_lwtunnel.c

    25	
  > 26	int nf_conntrack_lwtunnel_sysctl_handler(struct ctl_table *table, int write,
    27						 void *buffer, size_t *lenp,
    28						 loff_t *ppos)
    29	{
    30		int proc_nf_ct_lwtunnel_enabled = 0;
    31		struct ctl_table tmp = {
    32			.procname = table->procname,
    33			.data = &proc_nf_ct_lwtunnel_enabled,
    34			.maxlen = sizeof(int),
    35			.mode = table->mode,
    36			.extra1 = SYSCTL_ZERO,
    37			.extra2 = SYSCTL_ONE,
    38		};
    39		int ret;
    40	
    41		if (!write)
    42			proc_nf_ct_lwtunnel_enabled = nf_conntrack_lwtunnel_get();
    43	
    44		ret = proc_dointvec_minmax(&tmp, write, buffer, lenp, ppos);
    45	
    46		if (write && ret == 0)
    47			ret = nf_conntrack_lwtunnel_set(proc_nf_ct_lwtunnel_enabled);
    48	
    49		return ret;
    50	}
    51	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68087 bytes --]

  reply	other threads:[~2021-07-29 12:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  8:37 [PATCH v2 0/2] net: add netfilter hooks to track SRv6-encapsulated flows Ryoga Saito
2021-07-29  8:37 ` [PATCH v2 1/2] netfilter: add new sysctl toggle for lightweight tunnel netfilter hooks Ryoga Saito
2021-07-29 12:41   ` kernel test robot [this message]
2021-07-29  8:37 ` [PATCH v2 2/2] netfilter: add netfilter hooks to SRv6 data plane Ryoga Saito

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202107292057.KLbvBPA0-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=andrea.mayer@uniroma2.it \
    --cc=contact@proelbtn.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=kbuild-all@lists.01.org \
    --cc=kuba@kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=stefano.salsano@uniroma2.it \
    --cc=yoshfuji@linux-ipv6.org \
    --subject='Re: [PATCH v2 1/2] netfilter: add new sysctl toggle for lightweight tunnel netfilter hooks' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.