All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: "Alejandro Colomar (man-pages)" <alx.manpages@gmail.com>
Cc: Michael Kerrisk <mtk.manpages@gmail.com>, linux-man@vger.kernel.org
Subject: Re: [PATCH] ioctl_tty.2: Document ioctls: TCGETS2, TCSETS2, TCSETSW2, TCSETSF2
Date: Fri, 30 Jul 2021 02:21:04 +0200	[thread overview]
Message-ID: <20210730002104.ug6gfh3xh4anh3e5@pali> (raw)
In-Reply-To: <7d48a1dd-9641-53e9-bb65-868c86f22821@gmail.com>

On Friday 30 July 2021 01:39:11 Alejandro Colomar (man-pages) wrote:
> user@sqli:/usr/include$ grep -rn 'struct termios {'
> asm-generic/termbits.h:12:struct termios {

You have there a mistake. It is 'struct termios2', not 'struct termios'.

And for 'struct termios' it is more complicated as there are two
different 'struct termios'. One in file <bits/termios.h> (included from
<termios.h>) and one in file <asm-generic/termbits.h> (included from
<linux/termios.h>).

Function tcsetattr() uses 'struct termios' from <bits/termios.h> and
ioctl TCSETS uses 'struct termios' from <asm-generic/termbits.h>.

> user@sqli:/usr/include$ grep -rn '<asm-generic/termbits.h>'
> x86_64-linux-gnu/asm/termbits.h:1:#include <asm-generic/termbits.h>
> user@sqli:/usr/include$ grep -rn '<asm/termbits.h>'
> asm-generic/termios.h:12:#include <asm/termbits.h>
> user@sqli:/usr/include$ grep -rn '<asm-generic/termios.h>'
> x86_64-linux-gnu/asm/termios.h:1:#include <asm-generic/termios.h>
> user@sqli:/usr/include$ grep -rn '<asm/termios.h>'
> linux/termios.h:6:#include <asm/termios.h>
> user@sqli:/usr/include$ grep -rn '<linux/termios.h>'
> user@sqli:/usr/include$

  parent reply	other threads:[~2021-07-30  0:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-25 22:55 [PATCH] ioctl_tty.2: Document ioctls: TCGETS2, TCSETS2, TCSETSW2, TCSETSF2 Pali Rohár
2021-07-29 11:30 ` Alejandro Colomar (man-pages)
2021-07-29 17:31   ` Pali Rohár
2021-07-29 23:39     ` Alejandro Colomar (man-pages)
2021-07-30  0:09       ` Pali Rohár
2021-07-30  7:04         ` Alejandro Colomar (man-pages)
2021-07-30 10:56           ` Pali Rohár
2021-07-30  0:21       ` Pali Rohár [this message]
2021-07-30  7:59         ` Alejandro Colomar (man-pages)
2021-07-30 10:48 ` [PATCH v2] " Pali Rohár
2021-07-30 18:20   ` Alejandro Colomar (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210730002104.ug6gfh3xh4anh3e5@pali \
    --to=pali@kernel.org \
    --cc=alx.manpages@gmail.com \
    --cc=linux-man@vger.kernel.org \
    --cc=mtk.manpages@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.