All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] riscv: Add support to allocate gigantic hugepages using CMA
@ 2021-07-30  1:30 Kefeng Wang
  2021-07-30 12:09 ` Alex Ghiti
  0 siblings, 1 reply; 3+ messages in thread
From: Kefeng Wang @ 2021-07-30  1:30 UTC (permalink / raw)
  To: Palmer Dabbelt, linux-riscv
  Cc: palmerdabbelt, paul.walmsley, aou, Kefeng Wang, Alexandre Ghiti

commit 9e953cda5cdf ("riscv: Introduce huge page support for32/64bit
kernel") add support gigantic hugepage support for RV64.

This patch add support to allocate gigantic hugepages using CMA by
specifying the hugetlb_cma= kernel parameter on RV64.

Cc: Alexandre Ghiti <alex@ghiti.fr>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
v2: don't disable hugepage support on RV32.

 arch/riscv/mm/init.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
index a14bf3910eec..e547e53cddd2 100644
--- a/arch/riscv/mm/init.c
+++ b/arch/riscv/mm/init.c
@@ -19,6 +19,7 @@
 #include <linux/set_memory.h>
 #include <linux/dma-map-ops.h>
 #include <linux/crash_dump.h>
+#include <linux/hugetlb.h>
 
 #include <asm/fixmap.h>
 #include <asm/tlbflush.h>
@@ -216,6 +217,8 @@ static void __init setup_bootmem(void)
 
 	early_init_fdt_scan_reserved_mem();
 	dma_contiguous_reserve(dma32_phys_limit);
+	if (IS_ENABLED(CONFIG_64BIT))
+		hugetlb_cma_reserve(PUD_SHIFT - PAGE_SHIFT);
 	memblock_allow_resize();
 }
 
-- 
2.26.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] riscv: Add support to allocate gigantic hugepages using CMA
  2021-07-30  1:30 [PATCH v2] riscv: Add support to allocate gigantic hugepages using CMA Kefeng Wang
@ 2021-07-30 12:09 ` Alex Ghiti
  2021-07-30 13:01   ` Kefeng Wang
  0 siblings, 1 reply; 3+ messages in thread
From: Alex Ghiti @ 2021-07-30 12:09 UTC (permalink / raw)
  To: Kefeng Wang, Palmer Dabbelt, linux-riscv
  Cc: palmerdabbelt, paul.walmsley, aou

Le 30/07/2021 à 03:30, Kefeng Wang a écrit :
> commit 9e953cda5cdf ("riscv: Introduce huge page support for32/64bit

"Commit"

> kernel") add support gigantic hugepage support for RV64.

"adds support for gigantic huge pages for RV64."

> 
> This patch add support to allocate gigantic hugepages using CMA by

"adds"

> specifying the hugetlb_cma= kernel parameter on RV64.
> 
> Cc: Alexandre Ghiti <alex@ghiti.fr>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> v2: don't disable hugepage support on RV32.
> 
>   arch/riscv/mm/init.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
> index a14bf3910eec..e547e53cddd2 100644
> --- a/arch/riscv/mm/init.c
> +++ b/arch/riscv/mm/init.c
> @@ -19,6 +19,7 @@
>   #include <linux/set_memory.h>
>   #include <linux/dma-map-ops.h>
>   #include <linux/crash_dump.h>
> +#include <linux/hugetlb.h>
>   
>   #include <asm/fixmap.h>
>   #include <asm/tlbflush.h>
> @@ -216,6 +217,8 @@ static void __init setup_bootmem(void)
>   
>   	early_init_fdt_scan_reserved_mem();
>   	dma_contiguous_reserve(dma32_phys_limit);
> +	if (IS_ENABLED(CONFIG_64BIT))
> +		hugetlb_cma_reserve(PUD_SHIFT - PAGE_SHIFT);
>   	memblock_allow_resize();
>   }
>   
> 

Apart from the minor nits above, you can add:

Reviewed-by: Alexandre Ghiti <alex@ghiti.fr>

Thanks!


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2] riscv: Add support to allocate gigantic hugepages using CMA
  2021-07-30 12:09 ` Alex Ghiti
@ 2021-07-30 13:01   ` Kefeng Wang
  0 siblings, 0 replies; 3+ messages in thread
From: Kefeng Wang @ 2021-07-30 13:01 UTC (permalink / raw)
  To: Alex Ghiti, Palmer Dabbelt, linux-riscv; +Cc: palmerdabbelt, paul.walmsley, aou


On 2021/7/30 20:09, Alex Ghiti wrote:
> Le 30/07/2021 à 03:30, Kefeng Wang a écrit :
>> commit 9e953cda5cdf ("riscv: Introduce huge page support for32/64bit
>
> "Commit"
>
>> kernel") add support gigantic hugepage support for RV64.
>
> "adds support for gigantic huge pages for RV64."
>
>>
>> This patch add support to allocate gigantic hugepages using CMA by
>
> "adds"
>
>> specifying the hugetlb_cma= kernel parameter on RV64.
>>
>> Cc: Alexandre Ghiti <alex@ghiti.fr>
>> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
>> ---
>> v2: don't disable hugepage support on RV32.
>>
>>   arch/riscv/mm/init.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/riscv/mm/init.c b/arch/riscv/mm/init.c
>> index a14bf3910eec..e547e53cddd2 100644
>> --- a/arch/riscv/mm/init.c
>> +++ b/arch/riscv/mm/init.c
>> @@ -19,6 +19,7 @@
>>   #include <linux/set_memory.h>
>>   #include <linux/dma-map-ops.h>
>>   #include <linux/crash_dump.h>
>> +#include <linux/hugetlb.h>
>>     #include <asm/fixmap.h>
>>   #include <asm/tlbflush.h>
>> @@ -216,6 +217,8 @@ static void __init setup_bootmem(void)
>>         early_init_fdt_scan_reserved_mem();
>>       dma_contiguous_reserve(dma32_phys_limit);
>> +    if (IS_ENABLED(CONFIG_64BIT))
>> +        hugetlb_cma_reserve(PUD_SHIFT - PAGE_SHIFT);
>>       memblock_allow_resize();
>>   }
>>
>
> Apart from the minor nits above, you can add:
>
> Reviewed-by: Alexandre Ghiti <alex@ghiti.fr>
>
Resend with update, thanks :)
> Thanks!
>
> .
>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-30 13:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-30  1:30 [PATCH v2] riscv: Add support to allocate gigantic hugepages using CMA Kefeng Wang
2021-07-30 12:09 ` Alex Ghiti
2021-07-30 13:01   ` Kefeng Wang

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.