All of
 help / color / mirror / Atom feed
* [PATCH net] can: hi311x: fix a signedness bug in hi3110_cmd()
@ 2021-07-29 14:12 Dan Carpenter
  2021-07-30  6:48 ` Marc Kleine-Budde
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2021-07-29 14:12 UTC (permalink / raw)
  To: Wolfgang Grandegger
  Cc: Marc Kleine-Budde, David S. Miller, Jakub Kicinski,
	Vincent Mailhol, Oliver Hartkopp, Akshay Bhat, linux-can, netdev,

The hi3110_cmd() is supposed to return zero on success and negative
error codes on failure, but it was accidentally declared as a u8 when
it needs to be an int type.

Fixes: 57e83fb9b746 ("can: hi311x: Add Holt HI-311x CAN driver")
Signed-off-by: Dan Carpenter <>
 drivers/net/can/spi/hi311x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/can/spi/hi311x.c b/drivers/net/can/spi/hi311x.c
index dd17b8c53e1c..89d9c986a229 100644
--- a/drivers/net/can/spi/hi311x.c
+++ b/drivers/net/can/spi/hi311x.c
@@ -218,7 +218,7 @@ static int hi3110_spi_trans(struct spi_device *spi, int len)
 	return ret;
-static u8 hi3110_cmd(struct spi_device *spi, u8 command)
+static int hi3110_cmd(struct spi_device *spi, u8 command)
 	struct hi3110_priv *priv = spi_get_drvdata(spi);

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-30  6:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-29 14:12 [PATCH net] can: hi311x: fix a signedness bug in hi3110_cmd() Dan Carpenter
2021-07-30  6:48 ` Marc Kleine-Budde

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.