All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Antonio Caggiano <antonio.caggiano@collabora.com>
Cc: qemu-devel@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH v2 5/8] virtio-gpu: Resource UUID
Date: Fri, 30 Jul 2021 11:57:07 +0200	[thread overview]
Message-ID: <20210730095707.q4rjjuwjikb32xxt@sirius.home.kraxel.org> (raw)
In-Reply-To: <20210728134634.2142156-6-antonio.caggiano@collabora.com>

On Wed, Jul 28, 2021 at 03:46:31PM +0200, Antonio Caggiano wrote:
> Enable resource UUID feature and implement command resource assign UUID.
> For the moment, use the resource ID as UUID.

No, please do that properly right from start.

Needs a uuid -> resource-id table or hash in qemu.  Alternatively have
virglrenderer manage uuids too (which then probably needs some api
changes).  Not sure which is better, also depends on how you are going
to use that (i.e. who will lookup resources by uuid).

take care,
  Gerd



  reply	other threads:[~2021-07-30  9:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-28 13:46 [PATCH v2 0/8] virtio-gpu: Support Venus Vulkan driver Antonio Caggiano
2021-07-28 13:46 ` [PATCH v2 1/8] virtio-gpu: CONTEXT_INIT feature Antonio Caggiano
2021-07-30  9:45   ` Gerd Hoffmann
2021-07-28 13:46 ` [PATCH v2 2/8] virtio-gpu: hostmem [wip] Antonio Caggiano
2021-07-28 18:46   ` Philippe Mathieu-Daudé
2021-07-30  9:49   ` Gerd Hoffmann
2021-07-28 13:46 ` [PATCH v2 3/8] virtio: Add shared memory capability Antonio Caggiano
2021-07-28 13:46 ` [PATCH v2 4/8] virtio-gpu: Shared " Antonio Caggiano
2021-07-30  9:52   ` Gerd Hoffmann
2021-07-28 13:46 ` [PATCH v2 5/8] virtio-gpu: Resource UUID Antonio Caggiano
2021-07-30  9:57   ` Gerd Hoffmann [this message]
2021-07-28 13:46 ` [PATCH v2 6/8] virtio-gpu: Support Venus capset Antonio Caggiano
2021-07-30  9:59   ` Gerd Hoffmann
2021-07-28 13:46 ` [PATCH v2 7/8] virtio-gpu: Initialize Venus Antonio Caggiano
2021-07-28 18:44   ` Philippe Mathieu-Daudé
2021-07-30 10:00   ` Gerd Hoffmann
2021-07-28 13:46 ` [PATCH v2 8/8] virtio-gpu: Handle resource blob commands Antonio Caggiano
2021-07-30 10:04   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210730095707.q4rjjuwjikb32xxt@sirius.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=antonio.caggiano@collabora.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.