From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FD0BC4338F for ; Fri, 30 Jul 2021 12:30:12 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 803BA6024A for ; Fri, 30 Jul 2021 12:30:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 803BA6024A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D1C568332D; Fri, 30 Jul 2021 14:29:36 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="Ys+8X8eC"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0F4CF83310; Fri, 30 Jul 2021 14:29:10 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam07on2062b.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eb2::62b]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 55CA1832EF for ; Fri, 30 Jul 2021 14:29:01 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=xilinx.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ashokred@xilinx.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=K/LUX1Or77LhCzLD2FzKFIitdB7nI383PwPtmntlli117fVsQ2odBPfJU2hTP3OwbKLCjrnvji3xhr1Vs+bnebqoKWwLFdv+07lKzl2OSBIBjwghbDDdd0lgWUcqLohb86fvpPEfPhj3+E2Mq80c6ixRBX2SigZZwM15o7eHV3BXWSNglBKHieQBafsdoewmIgdMuqhzYnFaAPcRWMp7ASZ5dtUEhO3Af0Wtz+C1Q3VlQt68LSe2uajt0lU2f8GGs5aicRAWzjs/o+2l9qi5YRN3tav4LeWI7ptxFqIGzCpVoTFfzZoFzmK5zEsG1gJJb5lycvjWltm5jxUDzT+6HA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VlRATOteusvEn4jPG9AOR7/6RH39nIbj+gg0zB2ULR0=; b=agRIS/PuOaWOouU69vv4iDtIEbcawU0Wy/S5j2biaylsdgOBzEGTT4R/0AYrecehdWULx/imbmJU7RYj/aUD4+kPz4NexEKGqdqS/abOT6G3OGDPZyEsKIUC8YjM+pQu0PwW7fiw0v5NboqadhGTfxbUJVnojS8ouesm+dTaQFRaKuWz7239Z87L5wwYoe4jZ3Nj2Ymg/qE0yojN3m+8bXTa5shuD7RenwjlyrRvqIGmPYa5hMrSm6SmBuI3D1vEoSbukmOy9SDMLiP3cDjtVepyF0i7SOfBKyYXl06dI/V/2FnHMNmk3TqCB7Octbwu/d+XcTuEymtIMH2Qk14GEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.62.198) smtp.rcpttodomain=chromium.org smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VlRATOteusvEn4jPG9AOR7/6RH39nIbj+gg0zB2ULR0=; b=Ys+8X8eCtI/LdQCCqyK8bDpJp3EazJzxEUv4oDz7zPjmdOEWjeYSq55RidvO8Ne+JcGD0/psGTvfTvby9Ran/AY6RqchpnLLSYXcAgbAI1PBBzbqRwrnlI032kAn98WVWmX2Z/mEeThZXEYnQVwyBH7MMd5us4+AHw/Cma3f2Nw= Received: from BN9PR03CA0349.namprd03.prod.outlook.com (2603:10b6:408:f6::24) by SN6PR02MB5471.namprd02.prod.outlook.com (2603:10b6:805:df::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.19; Fri, 30 Jul 2021 12:28:57 +0000 Received: from BN1NAM02FT011.eop-nam02.prod.protection.outlook.com (2603:10b6:408:f6:cafe::3c) by BN9PR03CA0349.outlook.office365.com (2603:10b6:408:f6::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.17 via Frontend Transport; Fri, 30 Jul 2021 12:28:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.62.198) smtp.mailfrom=xilinx.com; chromium.org; dkim=none (message not signed) header.d=none;chromium.org; dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.62.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com; Received: from xsj-pvapexch02.xlnx.xilinx.com (149.199.62.198) by BN1NAM02FT011.mail.protection.outlook.com (10.13.2.129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.4373.18 via Frontend Transport; Fri, 30 Jul 2021 12:28:57 +0000 Received: from xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 30 Jul 2021 05:28:48 -0700 Received: from smtp.xilinx.com (172.19.127.95) by xsj-pvapexch02.xlnx.xilinx.com (172.19.86.41) with Microsoft SMTP Server id 15.1.2176.2 via Frontend Transport; Fri, 30 Jul 2021 05:28:48 -0700 Envelope-to: git@xilinx.com, sjg@chromium.org, somaashokreddy@gmail.com, u-boot@lists.denx.de, monstr@monstr.eu, peng.fan@nxp.com, jh80.chung@samsung.com, faiz_abbas@ti.com, michael@walle.cc Received: from [10.140.6.65] (port=41042 helo=xhdashokred41.localdomain) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1m9Rd9-0002o5-4H; Fri, 30 Jul 2021 05:28:47 -0700 Received: by xhdashokred41.localdomain (Postfix, from userid 2896) id 5E5661005CC; Fri, 30 Jul 2021 06:28:46 -0600 (MDT) From: Ashok Reddy Soma To: CC: , , , , , , , , Ashok Reddy Soma , "T Karthik Reddy" Subject: [PATCH v3 1/7] mmc: zynq_sdhci: Return errors from arasan_sdhci_set_tapdelay Date: Fri, 30 Jul 2021 06:28:36 -0600 Message-ID: <20210730122842.3264-2-ashok.reddy.soma@xilinx.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210730122842.3264-1-ashok.reddy.soma@xilinx.com> References: <20210730122842.3264-1-ashok.reddy.soma@xilinx.com> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a967b8c8-30ff-4179-e725-08d953559a40 X-MS-TrafficTypeDiagnostic: SN6PR02MB5471: X-Microsoft-Antispam-PRVS: X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-MS-Oob-TLC-OOBClassifiers: OLM:139; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ScOsGdWyOEMNYEbQsWUqNekOnRAq7kgyh3BV7+qMzK/e5fSPPisZVz1OlmbMwIJ82/JyPr5HGxBNidB7w8bMgYB0KEfudzQQlGNwhXQyhefPXCUUgLdPKnzLC3nuktZgioyeFxjlrtKYBgVNad438b0m61qXDc/d4SXjkG6DYvnhwEGZALQ4eSrVVa0AU4TDZ3mRLSKq080BB+ucoW0TXwr/+ZSZkVIpAnaHWnqvUCTcRjy+r1PelQdPahOn2+WfiwElSuuuINKvaww3xFBhVKi8xnv8RIfgRGaidTjV0rJ6IsUAadDqgUorHFCfwSDjN0X4DfeelQ77gv/lt5CoQr0FLNBQZEtKrcZ/JsndKsJ4e7lNUznTg5XU6G1Opj8o9PZUrjwQ7m5XrHsMao3pmMAtA6hVz89zyeF5HaHTNfc0DaFpU0I1uyhZbaqeL/7WHxtn3PDwO9Jp7T+AA08vCzGhte/6Ey34Pgyk6Ii3fOTYxb5FJFMIuPRN+tf7hugrdKCw3HgxQopkG+cwzZBAMGAz1OoETb/JNZBDUZ6iaqQvyZqdg/8pY0VnhTFX0Sz3jKcNc+87PzWGK1dEghStYBeJaC9gVbIEZeee8Gh0wIMiJ0+R/n3EbR+GZnsonIIjMNxHEj7UjpUu8TBHEqeZV85I2tX/KDzguWfJFj5MRhlFZnK4nI+/5kUejpH8lRoaUb4wuvKczR1tBPWzKbWx4A== X-Forefront-Antispam-Report: CIP:149.199.62.198; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:xsj-pvapexch02.xlnx.xilinx.com; PTR:unknown-62-198.xilinx.com; CAT:NONE; SFS:(4636009)(36840700001)(46966006)(8676002)(54906003)(70206006)(26005)(6266002)(356005)(336012)(5660300002)(1076003)(186003)(4326008)(70586007)(107886003)(316002)(36906005)(8936002)(2616005)(6916009)(7636003)(103116003)(2906002)(36860700001)(47076005)(82310400003)(6666004)(42186006)(508600001)(83380400001)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2021 12:28:57.3586 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a967b8c8-30ff-4179-e725-08d953559a40 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.62.198]; Helo=[xsj-pvapexch02.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: BN1NAM02FT011.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB5471 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Change return type of arasan_sdhci_set_tapdelay() to int, to facilitate returning errors. Get return values from input and output set clock phase functions inside arasan_sdhci_set_tapdelay() and return those errors. Signed-off-by: T Karthik Reddy Signed-off-by: Ashok Reddy Soma --- Changes in v3: - Added new line after return at two places Changes in v2: - Split patch 1/7 to two patches, one for zynq_sdhci and other one for sdhci drivers/mmc/zynq_sdhci.c | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/drivers/mmc/zynq_sdhci.c b/drivers/mmc/zynq_sdhci.c index ba87ee8dd5..1ecc2ec669 100644 --- a/drivers/mmc/zynq_sdhci.c +++ b/drivers/mmc/zynq_sdhci.c @@ -422,7 +422,7 @@ static int sdhci_versal_sampleclk_set_phase(struct sdhci_host *host, return 0; } -static void arasan_sdhci_set_tapdelay(struct sdhci_host *host) +static int arasan_sdhci_set_tapdelay(struct sdhci_host *host) { struct arasan_sdhci_priv *priv = dev_get_priv(host->mmc->dev); struct arasan_sdhci_clk_data *clk_data = &priv->clk_data; @@ -431,18 +431,31 @@ static void arasan_sdhci_set_tapdelay(struct sdhci_host *host) u8 timing = mode2timing[mmc->selected_mode]; u32 iclk_phase = clk_data->clk_phase_in[timing]; u32 oclk_phase = clk_data->clk_phase_out[timing]; + int ret; dev_dbg(dev, "%s, host:%s, mode:%d\n", __func__, host->name, timing); if (IS_ENABLED(CONFIG_ARCH_ZYNQMP) && device_is_compatible(dev, "xlnx,zynqmp-8.9a")) { - sdhci_zynqmp_sampleclk_set_phase(host, iclk_phase); - sdhci_zynqmp_sdcardclk_set_phase(host, oclk_phase); + ret = sdhci_zynqmp_sampleclk_set_phase(host, iclk_phase); + if (ret) + return ret; + + ret = sdhci_zynqmp_sdcardclk_set_phase(host, oclk_phase); + if (ret) + return ret; } else if (IS_ENABLED(CONFIG_ARCH_VERSAL) && device_is_compatible(dev, "xlnx,versal-8.9a")) { - sdhci_versal_sampleclk_set_phase(host, iclk_phase); - sdhci_versal_sdcardclk_set_phase(host, oclk_phase); + ret = sdhci_versal_sampleclk_set_phase(host, iclk_phase); + if (ret) + return ret; + + ret = sdhci_versal_sdcardclk_set_phase(host, oclk_phase); + if (ret) + return ret; } + + return 0; } static void arasan_dt_read_clk_phase(struct udevice *dev, unsigned char timing, -- 2.17.1