* [PATCH v2 0/9] drm: Extend COMPILE_TEST support to some ARM drivers
@ 2021-07-31 1:39 Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 1/9] drm/omap: Use correct printk format specifiers for size_t Laurent Pinchart
` (8 more replies)
0 siblings, 9 replies; 17+ messages in thread
From: Laurent Pinchart @ 2021-07-31 1:39 UTC (permalink / raw)
To: dri-devel
Cc: Tomi Valkeinen, Sascha Hauer, Jyri Sarha, Jonathan Hunter,
linux-renesas-soc, Thierry Reding, linux-imx, Laurentiu Palcu,
linux-tegra, Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
Hello,
This patch series stems from subsystem-wide changes I wanted to
compile-test with an ARM64 cross-compiler. My laziness to fire a 32-bit
ARM build definitely resulted in more time being spent writing these
patches, but hopefully they'll turn out to be useful for more people.
Patches 1/9 to 3/7 are fixes for compilation warnings on 64-bit
platforms in the omapdrm and sti-drm drivers. They are a dependency for
the Kconfig changes that follow to avoid introducing build warnings, but
could also be merged before.
Patches 3/9 to 8/9 enable compilation of the imx-dcss, omapdrm, sti-drm
and tegra-drm drivers on all architectures with COMPILE_TEST. I have
tested compilation on arm64 and x86, with W=1. The patches are
independent from each other, so they can be picked by their respective
maintainers.
The last patch, 9/9, extends COMPILE_TEST support for the tilcdc driver
to ARM64. The driver doesn't compile on x86 due to a missing __iowmb(),
and I haven't taken the time to investigate how to solve this properly.
The main change since v1 is the extension of COMPILE_TEST to all
platforms instead of only ARM and ARM64.
Please feel free to pick patches individually for the driver(s) you
maintain.
Laurent Pinchart (9):
drm/omap: Use correct printk format specifiers for size_t
drm/omap: Cast pointer to integer without generating warning
drm/sti: Use correct printk format specifiers for size_t
drm/imx/dcss: Enable COMPILE_TEST on all architectures
drm/omap: Enable COMPILE_TEST on all architectures
drm/rcar-du: Enable COMPILE_TEST on all architectures
drm/sti: Enable COMPILE_TEST on all architectures
drm/tegra: Enable COMPILE_TEST on all architectures
drm/tilcdc: Enable COMPILE_TEST on all ARM64 platforms
drivers/gpu/drm/imx/dcss/Kconfig | 3 ++-
drivers/gpu/drm/omapdrm/Kconfig | 2 +-
drivers/gpu/drm/omapdrm/dss/dsi.c | 4 ++--
drivers/gpu/drm/omapdrm/omap_drv.c | 2 +-
drivers/gpu/drm/rcar-du/Kconfig | 1 -
drivers/gpu/drm/sti/Kconfig | 3 ++-
drivers/gpu/drm/sti/sti_hqvdp.c | 4 ++--
drivers/gpu/drm/tegra/Kconfig | 2 +-
drivers/gpu/drm/tilcdc/Kconfig | 3 ++-
drivers/gpu/host1x/Kconfig | 2 +-
10 files changed, 14 insertions(+), 12 deletions(-)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH v2 1/9] drm/omap: Use correct printk format specifiers for size_t
2021-07-31 1:39 [PATCH v2 0/9] drm: Extend COMPILE_TEST support to some ARM drivers Laurent Pinchart
@ 2021-07-31 1:39 ` Laurent Pinchart
2021-08-05 6:28 ` Tomi Valkeinen
2021-07-31 1:39 ` [PATCH v2 2/9] drm/omap: Cast pointer to integer without generating warning Laurent Pinchart
` (7 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Laurent Pinchart @ 2021-07-31 1:39 UTC (permalink / raw)
To: dri-devel
Cc: Tomi Valkeinen, Sascha Hauer, Jyri Sarha, Jonathan Hunter,
linux-renesas-soc, Thierry Reding, linux-imx, Laurentiu Palcu,
linux-tegra, Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
The correct format specifier for size_t is %zu. Using %d (or %u)
generates a warning on 64-bit platforms. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/gpu/drm/omapdrm/dss/dsi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
index 5f1722b040f4..503b5d4bf2c2 100644
--- a/drivers/gpu/drm/omapdrm/dss/dsi.c
+++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
@@ -2094,7 +2094,7 @@ static int dsi_vc_send_long(struct dsi_data *dsi, int vc,
u8 b1, b2, b3, b4;
if (dsi->debug_write)
- DSSDBG("dsi_vc_send_long, %d bytes\n", msg->tx_len);
+ DSSDBG("dsi_vc_send_long, %zu bytes\n", msg->tx_len);
/* len + header */
if (dsi->vc[vc].tx_fifo_size * 32 * 4 < msg->tx_len + 4) {
@@ -2390,7 +2390,7 @@ static int dsi_vc_generic_read(struct omap_dss_device *dssdev, int vc,
return 0;
err:
- DSSERR("%s(vc %d, reqlen %d) failed\n", __func__, vc, msg->tx_len);
+ DSSERR("%s(vc %d, reqlen %zu) failed\n", __func__, vc, msg->tx_len);
return r;
}
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 2/9] drm/omap: Cast pointer to integer without generating warning
2021-07-31 1:39 [PATCH v2 0/9] drm: Extend COMPILE_TEST support to some ARM drivers Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 1/9] drm/omap: Use correct printk format specifiers for size_t Laurent Pinchart
@ 2021-07-31 1:39 ` Laurent Pinchart
2021-07-31 10:12 ` Sergei Shtylyov
2021-08-05 6:29 ` Tomi Valkeinen
2021-07-31 1:39 ` [PATCH v2 3/9] drm/sti: Use correct printk format specifiers for size_t Laurent Pinchart
` (6 subsequent siblings)
8 siblings, 2 replies; 17+ messages in thread
From: Laurent Pinchart @ 2021-07-31 1:39 UTC (permalink / raw)
To: dri-devel
Cc: Tomi Valkeinen, Sascha Hauer, Jyri Sarha, Jonathan Hunter,
linux-renesas-soc, Thierry Reding, linux-imx, Laurentiu Palcu,
linux-tegra, Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
On 64-bit platforms, the compiler complains that casting a void pointer
to an unsigned int loses data. Cast the pointer to a uintptr_t unsigned
to fix this.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/gpu/drm/omapdrm/omap_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
index f86e20578143..c05d3975cb31 100644
--- a/drivers/gpu/drm/omapdrm/omap_drv.c
+++ b/drivers/gpu/drm/omapdrm/omap_drv.c
@@ -572,7 +572,7 @@ static int omapdrm_init(struct omap_drm_private *priv, struct device *dev)
priv->dss->mgr_ops_priv = priv;
soc = soc_device_match(omapdrm_soc_devices);
- priv->omaprev = soc ? (unsigned int)soc->data : 0;
+ priv->omaprev = soc ? (uintptr_t)soc->data : 0;
priv->wq = alloc_ordered_workqueue("omapdrm", 0);
mutex_init(&priv->list_lock);
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 3/9] drm/sti: Use correct printk format specifiers for size_t
2021-07-31 1:39 [PATCH v2 0/9] drm: Extend COMPILE_TEST support to some ARM drivers Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 1/9] drm/omap: Use correct printk format specifiers for size_t Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 2/9] drm/omap: Cast pointer to integer without generating warning Laurent Pinchart
@ 2021-07-31 1:39 ` Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 4/9] drm/imx/dcss: Enable COMPILE_TEST on all architectures Laurent Pinchart
` (5 subsequent siblings)
8 siblings, 0 replies; 17+ messages in thread
From: Laurent Pinchart @ 2021-07-31 1:39 UTC (permalink / raw)
To: dri-devel
Cc: Tomi Valkeinen, Sascha Hauer, Jyri Sarha, Jonathan Hunter,
linux-renesas-soc, Thierry Reding, linux-imx, Laurentiu Palcu,
linux-tegra, Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
The correct format specifier for size_t is %zu. Using %d (or %u)
generates a warning on 64-bit platforms. Fix it.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Philippe Cornu <philippe.cornu@foss.st.com>
---
drivers/gpu/drm/sti/sti_hqvdp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/sti/sti_hqvdp.c b/drivers/gpu/drm/sti/sti_hqvdp.c
index d09b08995b12..3c61ba8b43e0 100644
--- a/drivers/gpu/drm/sti/sti_hqvdp.c
+++ b/drivers/gpu/drm/sti/sti_hqvdp.c
@@ -927,12 +927,12 @@ static void sti_hqvdp_start_xp70(struct sti_hqvdp *hqvdp)
header = (struct fw_header *)firmware->data;
if (firmware->size < sizeof(*header)) {
- DRM_ERROR("Invalid firmware size (%d)\n", firmware->size);
+ DRM_ERROR("Invalid firmware size (%zu)\n", firmware->size);
goto out;
}
if ((sizeof(*header) + header->rd_size + header->wr_size +
header->pmem_size + header->dmem_size) != firmware->size) {
- DRM_ERROR("Invalid fmw structure (%d+%d+%d+%d+%d != %d)\n",
+ DRM_ERROR("Invalid fmw structure (%zu+%d+%d+%d+%d != %zu)\n",
sizeof(*header), header->rd_size, header->wr_size,
header->pmem_size, header->dmem_size,
firmware->size);
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 4/9] drm/imx/dcss: Enable COMPILE_TEST on all architectures
2021-07-31 1:39 [PATCH v2 0/9] drm: Extend COMPILE_TEST support to some ARM drivers Laurent Pinchart
` (2 preceding siblings ...)
2021-07-31 1:39 ` [PATCH v2 3/9] drm/sti: Use correct printk format specifiers for size_t Laurent Pinchart
@ 2021-07-31 1:39 ` Laurent Pinchart
2021-07-31 16:31 ` kernel test robot
2021-07-31 1:39 ` [PATCH v2 5/9] drm/omap: " Laurent Pinchart
` (4 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Laurent Pinchart @ 2021-07-31 1:39 UTC (permalink / raw)
To: dri-devel
Cc: Tomi Valkeinen, Sascha Hauer, Jyri Sarha, Jonathan Hunter,
linux-renesas-soc, Thierry Reding, linux-imx, Laurentiu Palcu,
linux-tegra, Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
To extend test coverage, relax the dependency on ARCH_MXC and ARM64 to
also enable compilation when COMPILE_TEST is selected.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
Changes since v1:
- Enable COMPILE_TEST on all architectures
---
drivers/gpu/drm/imx/dcss/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/imx/dcss/Kconfig b/drivers/gpu/drm/imx/dcss/Kconfig
index 2b17a964ff05..451ed05321cc 100644
--- a/drivers/gpu/drm/imx/dcss/Kconfig
+++ b/drivers/gpu/drm/imx/dcss/Kconfig
@@ -3,7 +3,8 @@ config DRM_IMX_DCSS
select IMX_IRQSTEER
select DRM_KMS_CMA_HELPER
select VIDEOMODE_HELPERS
- depends on DRM && ARCH_MXC && ARM64
+ depends on DRM
+ depends on (ARCH_MXC && ARM64) || COMPILE_TEST
help
Choose this if you have a NXP i.MX8MQ based system and want to use the
Display Controller Subsystem. This option enables DCSS support.
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 5/9] drm/omap: Enable COMPILE_TEST on all architectures
2021-07-31 1:39 [PATCH v2 0/9] drm: Extend COMPILE_TEST support to some ARM drivers Laurent Pinchart
` (3 preceding siblings ...)
2021-07-31 1:39 ` [PATCH v2 4/9] drm/imx/dcss: Enable COMPILE_TEST on all architectures Laurent Pinchart
@ 2021-07-31 1:39 ` Laurent Pinchart
2021-08-05 6:30 ` Tomi Valkeinen
2021-07-31 1:39 ` [PATCH v2 6/9] drm/rcar-du: " Laurent Pinchart
` (3 subsequent siblings)
8 siblings, 1 reply; 17+ messages in thread
From: Laurent Pinchart @ 2021-07-31 1:39 UTC (permalink / raw)
To: dri-devel
Cc: Tomi Valkeinen, Sascha Hauer, Jyri Sarha, Jonathan Hunter,
linux-renesas-soc, Thierry Reding, linux-imx, Laurentiu Palcu,
linux-tegra, Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
To extend test coverage, relax the dependency on ARCH_OMAP2PLUS or
ARCH_MULTIPLATFORM to also enable compilation with COMPILE_TEST.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
Changes since v1:
- Enable COMPILE_TEST on all architectures
---
drivers/gpu/drm/omapdrm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
index e7281da5bc6a..560d0cdd6156 100644
--- a/drivers/gpu/drm/omapdrm/Kconfig
+++ b/drivers/gpu/drm/omapdrm/Kconfig
@@ -2,7 +2,7 @@
config DRM_OMAP
tristate "OMAP DRM"
depends on DRM
- depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM
+ depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM || COMPILE_TEST
select OMAP2_DSS
select DRM_KMS_HELPER
select VIDEOMODE_HELPERS
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 6/9] drm/rcar-du: Enable COMPILE_TEST on all architectures
2021-07-31 1:39 [PATCH v2 0/9] drm: Extend COMPILE_TEST support to some ARM drivers Laurent Pinchart
` (4 preceding siblings ...)
2021-07-31 1:39 ` [PATCH v2 5/9] drm/omap: " Laurent Pinchart
@ 2021-07-31 1:39 ` Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 7/9] drm/sti: " Laurent Pinchart
` (2 subsequent siblings)
8 siblings, 0 replies; 17+ messages in thread
From: Laurent Pinchart @ 2021-07-31 1:39 UTC (permalink / raw)
To: dri-devel
Cc: Tomi Valkeinen, Sascha Hauer, Jyri Sarha, Jonathan Hunter,
linux-renesas-soc, Thierry Reding, linux-imx, Laurentiu Palcu,
linux-tegra, Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
To extend test coverage, support COMPILE_TEST on all architectures by
dropping the ARM || ARM64 dependency. The dependency is a no-op when
COMPILE_TEST is not selected as ARCH_RENESAS can only be defined for ARM
or ARM64.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/gpu/drm/rcar-du/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/Kconfig b/drivers/gpu/drm/rcar-du/Kconfig
index b47e74421e34..bce3a67f14d3 100644
--- a/drivers/gpu/drm/rcar-du/Kconfig
+++ b/drivers/gpu/drm/rcar-du/Kconfig
@@ -2,7 +2,6 @@
config DRM_RCAR_DU
tristate "DRM Support for R-Car Display Unit"
depends on DRM && OF
- depends on ARM || ARM64
depends on ARCH_RENESAS || COMPILE_TEST
imply DRM_RCAR_CMM
imply DRM_RCAR_LVDS
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 7/9] drm/sti: Enable COMPILE_TEST on all architectures
2021-07-31 1:39 [PATCH v2 0/9] drm: Extend COMPILE_TEST support to some ARM drivers Laurent Pinchart
` (5 preceding siblings ...)
2021-07-31 1:39 ` [PATCH v2 6/9] drm/rcar-du: " Laurent Pinchart
@ 2021-07-31 1:39 ` Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 8/9] drm/tegra: " Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 9/9] drm/tilcdc: Enable COMPILE_TEST on all ARM64 platforms Laurent Pinchart
8 siblings, 0 replies; 17+ messages in thread
From: Laurent Pinchart @ 2021-07-31 1:39 UTC (permalink / raw)
To: dri-devel
Cc: Tomi Valkeinen, Sascha Hauer, Jyri Sarha, Jonathan Hunter,
linux-renesas-soc, Thierry Reding, linux-imx, Laurentiu Palcu,
linux-tegra, Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
To extend test coverage, relax the dependency on ARCH_STI or
ARCH_MULTIPLATFORM to also enable compilation with COMPILE_TEST.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
Changes since v1:
- Enable COMPILE_TEST on all architectures
---
drivers/gpu/drm/sti/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/sti/Kconfig b/drivers/gpu/drm/sti/Kconfig
index d0cfdd36b38f..4c88785a95a8 100644
--- a/drivers/gpu/drm/sti/Kconfig
+++ b/drivers/gpu/drm/sti/Kconfig
@@ -1,7 +1,8 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_STI
tristate "DRM Support for STMicroelectronics SoC stiH4xx Series"
- depends on OF && DRM && (ARCH_STI || ARCH_MULTIPLATFORM)
+ depends on OF && DRM
+ depends on ARCH_STI || ARCH_MULTIPLATFORM || COMPILE_TEST
select RESET_CONTROLLER
select DRM_KMS_HELPER
select DRM_GEM_CMA_HELPER
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 8/9] drm/tegra: Enable COMPILE_TEST on all architectures
2021-07-31 1:39 [PATCH v2 0/9] drm: Extend COMPILE_TEST support to some ARM drivers Laurent Pinchart
` (6 preceding siblings ...)
2021-07-31 1:39 ` [PATCH v2 7/9] drm/sti: " Laurent Pinchart
@ 2021-07-31 1:39 ` Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 9/9] drm/tilcdc: Enable COMPILE_TEST on all ARM64 platforms Laurent Pinchart
8 siblings, 0 replies; 17+ messages in thread
From: Laurent Pinchart @ 2021-07-31 1:39 UTC (permalink / raw)
To: dri-devel
Cc: Tomi Valkeinen, Sascha Hauer, Jyri Sarha, Jonathan Hunter,
linux-renesas-soc, Thierry Reding, linux-imx, Laurentiu Palcu,
linux-tegra, Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
To extend test coverage, support COMPILE_TEST on all architectures.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
Changes since v1:
- Enable COMPILE_TEST on all architectures
---
drivers/gpu/drm/tegra/Kconfig | 2 +-
drivers/gpu/host1x/Kconfig | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tegra/Kconfig b/drivers/gpu/drm/tegra/Kconfig
index 5043dcaf1cf9..8eef9094d26a 100644
--- a/drivers/gpu/drm/tegra/Kconfig
+++ b/drivers/gpu/drm/tegra/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_TEGRA
tristate "NVIDIA Tegra DRM"
- depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
+ depends on ARCH_TEGRA || COMPILE_TEST
depends on COMMON_CLK
depends on DRM
depends on OF
diff --git a/drivers/gpu/host1x/Kconfig b/drivers/gpu/host1x/Kconfig
index 6dab94adf25e..977a0ac54e93 100644
--- a/drivers/gpu/host1x/Kconfig
+++ b/drivers/gpu/host1x/Kconfig
@@ -1,7 +1,7 @@
# SPDX-License-Identifier: GPL-2.0-only
config TEGRA_HOST1X
tristate "NVIDIA Tegra host1x driver"
- depends on ARCH_TEGRA || (ARM && COMPILE_TEST)
+ depends on ARCH_TEGRA || COMPILE_TEST
select IOMMU_IOVA
help
Driver for the NVIDIA Tegra host1x hardware.
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 17+ messages in thread
* [PATCH v2 9/9] drm/tilcdc: Enable COMPILE_TEST on all ARM64 platforms
2021-07-31 1:39 [PATCH v2 0/9] drm: Extend COMPILE_TEST support to some ARM drivers Laurent Pinchart
` (7 preceding siblings ...)
2021-07-31 1:39 ` [PATCH v2 8/9] drm/tegra: " Laurent Pinchart
@ 2021-07-31 1:39 ` Laurent Pinchart
8 siblings, 0 replies; 17+ messages in thread
From: Laurent Pinchart @ 2021-07-31 1:39 UTC (permalink / raw)
To: dri-devel
Cc: Tomi Valkeinen, Sascha Hauer, Jyri Sarha, Jonathan Hunter,
linux-renesas-soc, Thierry Reding, linux-imx, Laurentiu Palcu,
linux-tegra, Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
To extend test coverage, support COMPILE_TEST on ARM64 in addition to
ARM.
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
drivers/gpu/drm/tilcdc/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/Kconfig b/drivers/gpu/drm/tilcdc/Kconfig
index 9f505a149990..37009f4ace9f 100644
--- a/drivers/gpu/drm/tilcdc/Kconfig
+++ b/drivers/gpu/drm/tilcdc/Kconfig
@@ -1,7 +1,8 @@
# SPDX-License-Identifier: GPL-2.0-only
config DRM_TILCDC
tristate "DRM Support for TI LCDC Display Controller"
- depends on DRM && OF && ARM
+ depends on DRM && OF
+ depends on ARM || (ARM64 && COMPILE_TEST)
select DRM_KMS_HELPER
select DRM_KMS_CMA_HELPER
select DRM_GEM_CMA_HELPER
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/9] drm/omap: Cast pointer to integer without generating warning
2021-07-31 1:39 ` [PATCH v2 2/9] drm/omap: Cast pointer to integer without generating warning Laurent Pinchart
@ 2021-07-31 10:12 ` Sergei Shtylyov
2021-08-05 6:29 ` Tomi Valkeinen
1 sibling, 0 replies; 17+ messages in thread
From: Sergei Shtylyov @ 2021-07-31 10:12 UTC (permalink / raw)
To: Laurent Pinchart, dri-devel
Cc: Tomi Valkeinen, Sascha Hauer, Jyri Sarha, Jonathan Hunter,
linux-renesas-soc, Thierry Reding, linux-imx, Laurentiu Palcu,
linux-tegra, Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
Hello
On 31.07.2021 4:39, Laurent Pinchart wrote:
> On 64-bit platforms, the compiler complains that casting a void pointer
> to an unsigned int loses data. Cast the pointer to a uintptr_t unsigned
Is "unsigned" really needed here?
> to fix this.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index f86e20578143..c05d3975cb31 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -572,7 +572,7 @@ static int omapdrm_init(struct omap_drm_private *priv, struct device *dev)
> priv->dss->mgr_ops_priv = priv;
>
> soc = soc_device_match(omapdrm_soc_devices);
> - priv->omaprev = soc ? (unsigned int)soc->data : 0;
> + priv->omaprev = soc ? (uintptr_t)soc->data : 0;
> priv->wq = alloc_ordered_workqueue("omapdrm", 0);
>
> mutex_init(&priv->list_lock);
MBR, Sergei
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/9] drm/omap: Cast pointer to integer without generating warning
@ 2021-07-31 10:12 ` Sergei Shtylyov
0 siblings, 0 replies; 17+ messages in thread
From: Sergei Shtylyov @ 2021-07-31 10:12 UTC (permalink / raw)
To: Laurent Pinchart, dri-devel
Cc: Tomi Valkeinen, Sascha Hauer, Jyri Sarha, Jonathan Hunter,
linux-renesas-soc, Thierry Reding, linux-imx, Laurentiu Palcu,
linux-tegra, Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
Hello
On 31.07.2021 4:39, Laurent Pinchart wrote:
> On 64-bit platforms, the compiler complains that casting a void pointer
> to an unsigned int loses data. Cast the pointer to a uintptr_t unsigned
Is "unsigned" really needed here?
> to fix this.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index f86e20578143..c05d3975cb31 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -572,7 +572,7 @@ static int omapdrm_init(struct omap_drm_private *priv, struct device *dev)
> priv->dss->mgr_ops_priv = priv;
>
> soc = soc_device_match(omapdrm_soc_devices);
> - priv->omaprev = soc ? (unsigned int)soc->data : 0;
> + priv->omaprev = soc ? (uintptr_t)soc->data : 0;
> priv->wq = alloc_ordered_workqueue("omapdrm", 0);
>
> mutex_init(&priv->list_lock);
MBR, Sergei
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/9] drm/omap: Cast pointer to integer without generating warning
2021-07-31 10:12 ` Sergei Shtylyov
(?)
@ 2021-07-31 11:29 ` Laurent Pinchart
-1 siblings, 0 replies; 17+ messages in thread
From: Laurent Pinchart @ 2021-07-31 11:29 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: dri-devel, Tomi Valkeinen, Sascha Hauer, Jyri Sarha,
Jonathan Hunter, linux-renesas-soc, Thierry Reding, linux-imx,
Laurentiu Palcu, linux-tegra, Shawn Guo, Alain VOLMAT-SCND-01,
Benjamin Gaignard
Hi Sergey,
On Sat, Jul 31, 2021 at 01:12:58PM +0300, Sergei Shtylyov wrote:
> On 31.07.2021 4:39, Laurent Pinchart wrote:
>
> > On 64-bit platforms, the compiler complains that casting a void pointer
> > to an unsigned int loses data. Cast the pointer to a uintptr_t unsigned
>
> Is "unsigned" really needed here?
No it's not :-) I'll s/uintptr_t unsigned/uintptr_t/.
> > to fix this.
> >
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > drivers/gpu/drm/omapdrm/omap_drv.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> > index f86e20578143..c05d3975cb31 100644
> > --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> > +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> > @@ -572,7 +572,7 @@ static int omapdrm_init(struct omap_drm_private *priv, struct device *dev)
> > priv->dss->mgr_ops_priv = priv;
> >
> > soc = soc_device_match(omapdrm_soc_devices);
> > - priv->omaprev = soc ? (unsigned int)soc->data : 0;
> > + priv->omaprev = soc ? (uintptr_t)soc->data : 0;
> > priv->wq = alloc_ordered_workqueue("omapdrm", 0);
> >
> > mutex_init(&priv->list_lock);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 4/9] drm/imx/dcss: Enable COMPILE_TEST on all architectures
2021-07-31 1:39 ` [PATCH v2 4/9] drm/imx/dcss: Enable COMPILE_TEST on all architectures Laurent Pinchart
@ 2021-07-31 16:31 ` kernel test robot
0 siblings, 0 replies; 17+ messages in thread
From: kernel test robot @ 2021-07-31 16:31 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2120 bytes --]
Hi Laurent,
I love your patch! Yet something to improve:
[auto build test ERROR on tegra-drm/drm/tegra/for-next]
[also build test ERROR on tegra/for-next drm-intel/for-linux-next drm-tip/drm-tip drm-exynos/exynos-drm-next linus/master v5.14-rc3 next-20210730]
[cannot apply to drm/drm-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Laurent-Pinchart/drm-Extend-COMPILE_TEST-support-to-some-ARM-drivers/20210731-094250
base: git://anongit.freedesktop.org/tegra/linux.git drm/tegra/for-next
config: m68k-allyesconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4ab6a624633b3e2ff77110d25782fa4394ecb50d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Laurent-Pinchart/drm-Extend-COMPILE_TEST-support-to-some-ARM-drivers/20210731-094250
git checkout 4ab6a624633b3e2ff77110d25782fa4394ecb50d
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
m68k-linux-ld: drivers/gpu/drm/imx/dcss/dcss-scaler.o: in function `dcss_scaler_gaussian_filter':
>> dcss-scaler.c:(.text+0x9a): undefined reference to `__divdi3'
m68k-linux-ld: drivers/gpu/drm/imx/dcss/dcss-scaler.o: in function `dcss_scaler_filter_design':
dcss-scaler.c:(.text+0x676): undefined reference to `__divdi3'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 60682 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 1/9] drm/omap: Use correct printk format specifiers for size_t
2021-07-31 1:39 ` [PATCH v2 1/9] drm/omap: Use correct printk format specifiers for size_t Laurent Pinchart
@ 2021-08-05 6:28 ` Tomi Valkeinen
0 siblings, 0 replies; 17+ messages in thread
From: Tomi Valkeinen @ 2021-08-05 6:28 UTC (permalink / raw)
To: Laurent Pinchart, dri-devel
Cc: Sascha Hauer, Jyri Sarha, Jonathan Hunter, linux-renesas-soc,
Thierry Reding, linux-imx, Laurentiu Palcu, linux-tegra,
Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
On 31/07/2021 04:39, Laurent Pinchart wrote:
> The correct format specifier for size_t is %zu. Using %d (or %u)
> generates a warning on 64-bit platforms. Fix it.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/omapdrm/dss/dsi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/dss/dsi.c b/drivers/gpu/drm/omapdrm/dss/dsi.c
> index 5f1722b040f4..503b5d4bf2c2 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dsi.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dsi.c
> @@ -2094,7 +2094,7 @@ static int dsi_vc_send_long(struct dsi_data *dsi, int vc,
> u8 b1, b2, b3, b4;
>
> if (dsi->debug_write)
> - DSSDBG("dsi_vc_send_long, %d bytes\n", msg->tx_len);
> + DSSDBG("dsi_vc_send_long, %zu bytes\n", msg->tx_len);
>
> /* len + header */
> if (dsi->vc[vc].tx_fifo_size * 32 * 4 < msg->tx_len + 4) {
> @@ -2390,7 +2390,7 @@ static int dsi_vc_generic_read(struct omap_dss_device *dssdev, int vc,
>
> return 0;
> err:
> - DSSERR("%s(vc %d, reqlen %d) failed\n", __func__, vc, msg->tx_len);
> + DSSERR("%s(vc %d, reqlen %zu) failed\n", __func__, vc, msg->tx_len);
> return r;
> }
>
>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 2/9] drm/omap: Cast pointer to integer without generating warning
2021-07-31 1:39 ` [PATCH v2 2/9] drm/omap: Cast pointer to integer without generating warning Laurent Pinchart
2021-07-31 10:12 ` Sergei Shtylyov
@ 2021-08-05 6:29 ` Tomi Valkeinen
1 sibling, 0 replies; 17+ messages in thread
From: Tomi Valkeinen @ 2021-08-05 6:29 UTC (permalink / raw)
To: Laurent Pinchart, dri-devel
Cc: Sascha Hauer, Jyri Sarha, Jonathan Hunter, linux-renesas-soc,
Thierry Reding, linux-imx, Laurentiu Palcu, linux-tegra,
Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
On 31/07/2021 04:39, Laurent Pinchart wrote:
> On 64-bit platforms, the compiler complains that casting a void pointer
> to an unsigned int loses data. Cast the pointer to a uintptr_t unsigned
> to fix this.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c
> index f86e20578143..c05d3975cb31 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.c
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.c
> @@ -572,7 +572,7 @@ static int omapdrm_init(struct omap_drm_private *priv, struct device *dev)
> priv->dss->mgr_ops_priv = priv;
>
> soc = soc_device_match(omapdrm_soc_devices);
> - priv->omaprev = soc ? (unsigned int)soc->data : 0;
> + priv->omaprev = soc ? (uintptr_t)soc->data : 0;
> priv->wq = alloc_ordered_workqueue("omapdrm", 0);
>
> mutex_init(&priv->list_lock);
>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH v2 5/9] drm/omap: Enable COMPILE_TEST on all architectures
2021-07-31 1:39 ` [PATCH v2 5/9] drm/omap: " Laurent Pinchart
@ 2021-08-05 6:30 ` Tomi Valkeinen
0 siblings, 0 replies; 17+ messages in thread
From: Tomi Valkeinen @ 2021-08-05 6:30 UTC (permalink / raw)
To: Laurent Pinchart, dri-devel
Cc: Sascha Hauer, Jyri Sarha, Jonathan Hunter, linux-renesas-soc,
Thierry Reding, linux-imx, Laurentiu Palcu, linux-tegra,
Shawn Guo, Alain VOLMAT-SCND-01, Benjamin Gaignard
On 31/07/2021 04:39, Laurent Pinchart wrote:
> To extend test coverage, relax the dependency on ARCH_OMAP2PLUS or
> ARCH_MULTIPLATFORM to also enable compilation with COMPILE_TEST.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
> Changes since v1:
>
> - Enable COMPILE_TEST on all architectures
> ---
> drivers/gpu/drm/omapdrm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/Kconfig b/drivers/gpu/drm/omapdrm/Kconfig
> index e7281da5bc6a..560d0cdd6156 100644
> --- a/drivers/gpu/drm/omapdrm/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/Kconfig
> @@ -2,7 +2,7 @@
> config DRM_OMAP
> tristate "OMAP DRM"
> depends on DRM
> - depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM
> + depends on ARCH_OMAP2PLUS || ARCH_MULTIPLATFORM || COMPILE_TEST
> select OMAP2_DSS
> select DRM_KMS_HELPER
> select VIDEOMODE_HELPERS
>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Tomi
^ permalink raw reply [flat|nested] 17+ messages in thread
end of thread, other threads:[~2021-08-05 6:30 UTC | newest]
Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-31 1:39 [PATCH v2 0/9] drm: Extend COMPILE_TEST support to some ARM drivers Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 1/9] drm/omap: Use correct printk format specifiers for size_t Laurent Pinchart
2021-08-05 6:28 ` Tomi Valkeinen
2021-07-31 1:39 ` [PATCH v2 2/9] drm/omap: Cast pointer to integer without generating warning Laurent Pinchart
2021-07-31 10:12 ` Sergei Shtylyov
2021-07-31 10:12 ` Sergei Shtylyov
2021-07-31 11:29 ` Laurent Pinchart
2021-08-05 6:29 ` Tomi Valkeinen
2021-07-31 1:39 ` [PATCH v2 3/9] drm/sti: Use correct printk format specifiers for size_t Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 4/9] drm/imx/dcss: Enable COMPILE_TEST on all architectures Laurent Pinchart
2021-07-31 16:31 ` kernel test robot
2021-07-31 1:39 ` [PATCH v2 5/9] drm/omap: " Laurent Pinchart
2021-08-05 6:30 ` Tomi Valkeinen
2021-07-31 1:39 ` [PATCH v2 6/9] drm/rcar-du: " Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 7/9] drm/sti: " Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 8/9] drm/tegra: " Laurent Pinchart
2021-07-31 1:39 ` [PATCH v2 9/9] drm/tilcdc: Enable COMPILE_TEST on all ARM64 platforms Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.