From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E3AAC4338F for ; Sat, 31 Jul 2021 13:17:17 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE82A61019 for ; Sat, 31 Jul 2021 13:17:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BE82A61019 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4F01D8319C; Sat, 31 Jul 2021 15:17:14 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="XIsldAJM"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5531282D93; Sat, 31 Jul 2021 15:17:07 +0200 (CEST) Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 869F282D93 for ; Sat, 31 Jul 2021 15:17:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bmeng.cn@gmail.com Received: by mail-pl1-x62c.google.com with SMTP id z3so13060034plg.8 for ; Sat, 31 Jul 2021 06:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LL5ArhX8Jc3LJTMBw9KGKmexX1VLRHP5g77ak/4JMVQ=; b=XIsldAJMtN4LqUQmM9p7KIDPGgca1pxfV8XOLC5gusgOkaE4yZfhXafiLFS/vYSyvF GVRUCNeEGI7tBYI5RUIHmltn3L5uQxRruX/FLh4PyRht2sjQHwM9f7qtXpOGlwHk7LcC VePU69oHOZyo8EBXmzCB8SdBWY+/D5PfmYbN6Ev5aAnets5JvrWVQaboRpOobPPWuBsm dLGRNpjjJWCZlwBIfKKWJigZyNFpRCIUs72YUvVZLb1ShboqnLjJbLCRcxNUhBmOq41Y R6BAgU9yye1TUKh8WLnPOekNArnPa5XzS+KSQx6UimkZy8ZQwNXuS0XhOcU2oPOYHhKO xT1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=LL5ArhX8Jc3LJTMBw9KGKmexX1VLRHP5g77ak/4JMVQ=; b=J/3U5L4DtjVuej82qirXD8Qd5nD2MQDg6YqkMOzqMs8HQNw9icnhQqY0WP9FrpMGhv Hi39a1xutAKWopHKBANrjbSmovT/fCsMFUV+gsJouScbO52lKAT4ZO7nLiQVywI0UjTt /5jO0UzkLzOoFcCL1f8IjpLTR9GGFyd+DmpysnXzRcRjGvFUGS7fSgG1+2UXiW2mvKfo GtHys5/LU42nDBgzySvZqyTYJwMvfKGBjte+Snqdrsi+RqwJwAihf8skGPjhVgWLAPqs yC4thai5yKXWdfXaxgzp0ZpbDAOQ8aVX5cnjoKYjKtgu+epqga0VO+1iLJRy1t1Dz0ax 5O9Q== X-Gm-Message-State: AOAM531+j1ArFp2wCxVOC2tO0xJcj0pD5iosMcrHAhlpnnlSIULB1mmW kHV3zHYGfj7IVDGKPvWcjNw= X-Google-Smtp-Source: ABdhPJyH1lenKVlN6ZLnKYjuM8DstFy9Cz88ksqIwnqI1E2iT+6yFUXj3HI8R0Li2dbEkVIwWOrScQ== X-Received: by 2002:a17:90a:46c2:: with SMTP id x2mr8373097pjg.197.1627737422624; Sat, 31 Jul 2021 06:17:02 -0700 (PDT) Received: from i9-aorus-gtx1080.localdomain (144.168.56.201.16clouds.com. [144.168.56.201]) by smtp.gmail.com with ESMTPSA id h14sm5692744pfo.47.2021.07.31.06.17.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 31 Jul 2021 06:17:02 -0700 (PDT) From: Bin Meng To: Simon Glass , u-boot@lists.denx.de Cc: Bin Meng Subject: [PATCH 1/2] x86: queensbay: Optimize disable_igd() a little Date: Sat, 31 Jul 2021 21:16:51 +0800 Message-Id: <20210731131652.19206-1-bmeng.cn@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Initialize igd and sdvo to NULL so that we don't need to test the return value of dm_pci_bus_find_bdf() later. Signed-off-by: Bin Meng --- arch/x86/cpu/queensbay/tnc.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/x86/cpu/queensbay/tnc.c b/arch/x86/cpu/queensbay/tnc.c index 782ed863fe..e38c0198e4 100644 --- a/arch/x86/cpu/queensbay/tnc.c +++ b/arch/x86/cpu/queensbay/tnc.c @@ -18,18 +18,15 @@ static int __maybe_unused disable_igd(void) { - struct udevice *igd, *sdvo; + struct udevice *igd = NULL; + struct udevice *sdvo = NULL; int ret; ret = dm_pci_bus_find_bdf(TNC_IGD, &igd); - if (ret) - return ret; if (!igd) return 0; ret = dm_pci_bus_find_bdf(TNC_SDVO, &sdvo); - if (ret) - return ret; if (!sdvo) return 0; -- 2.25.1