From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AFBEC4338F for ; Sat, 31 Jul 2021 17:24:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3152461050 for ; Sat, 31 Jul 2021 17:24:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230355AbhGaRYr (ORCPT ); Sat, 31 Jul 2021 13:24:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:44596 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbhGaRYq (ORCPT ); Sat, 31 Jul 2021 13:24:46 -0400 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E763D61042; Sat, 31 Jul 2021 17:24:34 +0000 (UTC) Date: Sat, 31 Jul 2021 18:27:14 +0100 From: Jonathan Cameron To: Rob Herring Cc: Billy Tsai , Jonathan Cameron , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "joel@jms.id.au" , "andrew@aj.id.au" , "p.zabel@pengutronix.de" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , BMC-SW Subject: Re: [v2 1/8] dt-bindings: iio: adc: rename the aspeed adc yaml Message-ID: <20210731182714.7197bdcc@jic23-huawei> In-Reply-To: References: <20210723081621.29477-1-billy_tsai@aspeedtech.com> <20210723081621.29477-2-billy_tsai@aspeedtech.com> <20210723154456.00006744@Huawei.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Jul 2021 14:31:35 -0600 Rob Herring wrote: > On Mon, Jul 26, 2021 at 06:53:07AM +0000, Billy Tsai wrote: > > Hi Jonathan, > > > > On 2021/7/23, 10:45 PM, "Jonathan Cameron" wrote: > > > > On Fri, 23 Jul 2021 16:16:14 +0800 > > Billy Tsai wrote: > > > > > > The aspeed,ast2400-adc.yaml not only descriptor the bindings of ast2400. > > > > Rename it to aspeed,adc.yaml for all of the aspeed adc bindings. > > > > > > > > Signed-off-by: Billy Tsai > > > > > We try to avoid 'wild' card type namings most of the time and instead > > > name after a particular part number. I say try because clearly > > > we let a few in over the years :( > > > > > It is very hard to know if this binding will apply to 'all' future > > > aspeed ADCs. > > > > > As such I'm not sure this particular rename makes sense. > > > > If I want to extend the yaml file to compatible more versions of the aspeed adc. > > Would you suggest to add new files call aspeed,ast2600-adc.yaml or just append it > > to the aspeed,ast2400-adc.yaml? > > If 2600 is not backwards compatible with 2400, then probably a new > schema file. Given you are adding new properties (which only apply to > 2600?), then most likely a new schema file. Depends at which point there > are too many conditional (if/then/else) schemas. Agreed. It's a judgement call you need to make on when it is worth the new file. Note that doesn't have anything to do with splitting the driver. We have mulitple binding files for single drivers and for that matter multiple drivers for single binding files. If it is 'compatible' enough to not make the file to complex, then add to the existing ast2400 file without renaming. Jonathan > > Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B73BDC4338F for ; Sat, 31 Jul 2021 17:26:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73B6760EBC for ; Sat, 31 Jul 2021 17:26:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 73B6760EBC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nluSX6hisTHy8guUFsipkHesox00nfDUdsXjQBINn5Q=; b=GWKxbpVl6LDsSp ERn7uerzg84BDZ8HB1ON3KtkcZVSBD5fllB1AY58AyY/0MAtvsvI2gXy0/09jaqzy+KKlDBa+3MO0 RMyWb1aUU6GeBuX3iCEWbL87A864sSAaYiQM3pz2KLvRCBRJbC4g3a/Lq4J/q84mC/DqUsi2QnXCk t4b3XtRdo4DNfED7AiSO2xFMxzdCMCF3Qp/B3OERwmn5NO7locQrqajC1XaBXUK8kLgYdVae/CEHN 4uvrNX07YH3T+lWe//xmdQ/Qf11C2FigaV3Lr8g2ULzrsMbjWG/IRUhm5UM6VedVx7h3LwGYh+olX OI4ihCCYqO33bF8cvATw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9sj7-00BzNV-EN; Sat, 31 Jul 2021 17:24:45 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9sj1-00BzMr-SQ for linux-arm-kernel@lists.infradead.org; Sat, 31 Jul 2021 17:24:41 +0000 Received: from jic23-huawei (cpc108967-cmbg20-2-0-cust86.5-4.cable.virginm.net [81.101.6.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E763D61042; Sat, 31 Jul 2021 17:24:34 +0000 (UTC) Date: Sat, 31 Jul 2021 18:27:14 +0100 From: Jonathan Cameron To: Rob Herring Cc: Billy Tsai , Jonathan Cameron , "lars@metafoo.de" , "pmeerw@pmeerw.net" , "joel@jms.id.au" , "andrew@aj.id.au" , "p.zabel@pengutronix.de" , "linux-iio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , BMC-SW Subject: Re: [v2 1/8] dt-bindings: iio: adc: rename the aspeed adc yaml Message-ID: <20210731182714.7197bdcc@jic23-huawei> In-Reply-To: References: <20210723081621.29477-1-billy_tsai@aspeedtech.com> <20210723081621.29477-2-billy_tsai@aspeedtech.com> <20210723154456.00006744@Huawei.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210731_102439_996047_C7938F0D X-CRM114-Status: GOOD ( 26.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 29 Jul 2021 14:31:35 -0600 Rob Herring wrote: > On Mon, Jul 26, 2021 at 06:53:07AM +0000, Billy Tsai wrote: > > Hi Jonathan, > > > > On 2021/7/23, 10:45 PM, "Jonathan Cameron" wrote: > > > > On Fri, 23 Jul 2021 16:16:14 +0800 > > Billy Tsai wrote: > > > > > > The aspeed,ast2400-adc.yaml not only descriptor the bindings of ast2400. > > > > Rename it to aspeed,adc.yaml for all of the aspeed adc bindings. > > > > > > > > Signed-off-by: Billy Tsai > > > > > We try to avoid 'wild' card type namings most of the time and instead > > > name after a particular part number. I say try because clearly > > > we let a few in over the years :( > > > > > It is very hard to know if this binding will apply to 'all' future > > > aspeed ADCs. > > > > > As such I'm not sure this particular rename makes sense. > > > > If I want to extend the yaml file to compatible more versions of the aspeed adc. > > Would you suggest to add new files call aspeed,ast2600-adc.yaml or just append it > > to the aspeed,ast2400-adc.yaml? > > If 2600 is not backwards compatible with 2400, then probably a new > schema file. Given you are adding new properties (which only apply to > 2600?), then most likely a new schema file. Depends at which point there > are too many conditional (if/then/else) schemas. Agreed. It's a judgement call you need to make on when it is worth the new file. Note that doesn't have anything to do with splitting the driver. We have mulitple binding files for single drivers and for that matter multiple drivers for single binding files. If it is 'compatible' enough to not make the file to complex, then add to the existing ast2400 file without renaming. Jonathan > > Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel