[PATCH] sstate: Fix rebuilds when changing layer config

[PATCH] sstate: Fix rebuilds when changing layer config

[Richard Purdie]

When adding a layer which changed SSTATE_EXCLUDEDEPS_SYSROOT, the state
hashes were changing when they should not. This was caused by wider use
of setscene_depvalid which means the dependency on the variable was seen
when it was previously not.

Exclude the variable since this should be be included in the hashes.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/classes/sstate.bbclass | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/classes/sstate.bbclass b/meta/classes/sstate.bbclass
index f6710fc2835..554e401ee25 100644
--- a/meta/classes/sstate.bbclass
+++ b/meta/classes/sstate.bbclass
@@ -1018,6 +1018,7 @@ def sstate_checkhashes(sq_data, d, siginfo=False, currentcount=0, summary=True,
         bb.parse.siggen.checkhashes(sq_data, missed, found, d)
 
     return found
+setscene_depvalid[vardepsexclude] = "SSTATE_EXCLUDEDEPS_SYSROOT"
 
 BB_SETSCENE_DEPVALID = "setscene_depvalid"
 
-- 
2.30.2

Re: [OE-core] [PATCH] sstate: Fix rebuilds when changing layer config

[Michael Opdenacker]

Hi Richard,

On 8/1/21 2:48 PM, Richard Purdie wrote:
> When adding a layer which changed SSTATE_EXCLUDEDEPS_SYSROOT, the state
> hashes were changing when they should not. This was caused by wider use
> of setscene_depvalid which means the dependency on the variable was seen
> when it was previously not.
>
> Exclude the variable since this should be be included in the hashes.

I realize that this variable isn't documented in any of the manuals.
Should be document it?
Thank you in advance for your advice.

Cheers,
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH] sstate: Fix rebuilds when changing layer config

[Richard Purdie]

On Mon, 2021-08-02 at 15:30 +0200, Michael Opdenacker wrote:
> Hi Richard,
> 
> On 8/1/21 2:48 PM, Richard Purdie wrote:
> > When adding a layer which changed SSTATE_EXCLUDEDEPS_SYSROOT, the state
> > hashes were changing when they should not. This was caused by wider use
> > of setscene_depvalid which means the dependency on the variable was seen
> > when it was previously not.
> > 
> > Exclude the variable since this should be be included in the hashes.
> 
> I realize that this variable isn't documented in any of the manuals.
> Should be document it?
> Thank you in advance for your advice.

Yes, this should be on the list of things to document.

Cheers,

Richard

Re: [OE-core] [PATCH] sstate: Fix rebuilds when changing layer config

[Michael Opdenacker]

On 8/2/21 4:36 PM, Richard Purdie wrote:
> On Mon, 2021-08-02 at 15:30 +0200, Michael Opdenacker wrote:
>> Hi Richard,
>>
>> On 8/1/21 2:48 PM, Richard Purdie wrote:
>>> When adding a layer which changed SSTATE_EXCLUDEDEPS_SYSROOT, the state
>>> hashes were changing when they should not. This was caused by wider use
>>> of setscene_depvalid which means the dependency on the variable was seen
>>> when it was previously not.
>>>
>>> Exclude the variable since this should be be included in the hashes.
>> I realize that this variable isn't documented in any of the manuals.
>> Should be document it?
>> Thank you in advance for your advice.
> Yes, this should be on the list of things to document.


Thanks for confirming. I opened a new bug for this, now that we have a
special category for undocumented variables:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=14496

Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com