All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Glass <sjg@chromium.org>
To: U-Boot Mailing List <u-boot@lists.denx.de>
Cc: Tom Rini <trini@konsulko.com>, Simon Glass <sjg@chromium.org>
Subject: [PATCH v2 04/32] pci: Remove guard around compatibility functions
Date: Sun,  1 Aug 2021 18:54:17 -0600	[thread overview]
Message-ID: <20210802005446.2267075-5-sjg@chromium.org> (raw)
In-Reply-To: <20210802005446.2267075-1-sjg@chromium.org>

This prevents use of IS_ENABLED() in other files. Functions should be
visible in headers even if they are not available at link time.

Fix it.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

(no changes since v1)

 include/pci.h | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/include/pci.h b/include/pci.h
index e07d6c31bc1..ca086420ff2 100644
--- a/include/pci.h
+++ b/include/pci.h
@@ -789,7 +789,6 @@ extern void pci_mpc85xx_init (struct pci_controller *hose);
 extern void imx_pcie_remove(void);
 #endif
 
-#if !defined(CONFIG_DM_PCI) || defined(CONFIG_DM_PCI_COMPAT)
 /**
  * pci_write_bar32() - Write the address of a BAR including control bits
  *
@@ -797,6 +796,8 @@ extern void imx_pcie_remove(void);
  * with devices which require hard-coded addresses, not part of the normal
  * PCI enumeration process.
  *
+ * This is only available if CONFIG_DM_PCI_COMPAT is enabled
+ *
  * @hose:	PCI hose to use
  * @dev:	PCI device to update
  * @barnum:	BAR number (0-5)
@@ -808,6 +809,8 @@ void pci_write_bar32(struct pci_controller *hose, pci_dev_t dev, int barnum,
 /**
  * pci_read_bar32() - read the address of a bar
  *
+ * This is only available if CONFIG_DM_PCI_COMPAT is enabled
+ *
  * @hose:	PCI hose to use
  * @dev:	PCI device to inspect
  * @barnum:	BAR number (0-5)
@@ -818,6 +821,8 @@ u32 pci_read_bar32(struct pci_controller *hose, pci_dev_t dev, int barnum);
 /**
  * pci_hose_find_devices() - Find devices by vendor/device ID
  *
+ * This is only available if CONFIG_DM_PCI_COMPAT is enabled
+ *
  * @hose:	PCI hose to search
  * @busnum:	Bus number to search
  * @ids:	PCI vendor/device IDs to look for, terminated by 0, 0 record
@@ -828,7 +833,6 @@ u32 pci_read_bar32(struct pci_controller *hose, pci_dev_t dev, int barnum);
  */
 pci_dev_t pci_hose_find_devices(struct pci_controller *hose, int busnum,
 				struct pci_device_id *ids, int *indexp);
-#endif /* !CONFIG_DM_PCI || CONFIG_DM_PCI_COMPAT */
 
 /* Access sizes for PCI reads and writes */
 enum pci_size_t {
-- 
2.32.0.554.ge1b32706d8-goog


  parent reply	other threads:[~2021-08-02  0:55 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  0:54 [PATCH v2 00/32] pci: Drop all pre-driver model code Simon Glass
2021-08-02  0:54 ` [PATCH v2 01/32] pci: Drop old code from pci command Simon Glass
2021-08-06 21:20   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 02/32] ppc: Remove UCP1020 board Simon Glass
2021-08-02  3:00   ` Tom Rini
2021-09-13 18:46   ` Arcturus Support
2021-09-14  1:02   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 03/32] pci: Drop old code from header file Simon Glass
2021-09-14  1:03   ` Tom Rini
2021-08-02  0:54 ` Simon Glass [this message]
2021-08-06 21:20   ` [PATCH v2 04/32] pci: Remove guard around compatibility functions Tom Rini
2021-08-02  0:54 ` [PATCH v2 05/32] pci: Drop DM_PCI check from fdtdec Simon Glass
2021-09-14  1:03   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 06/32] pci: Drop DM_PCI check from pci_common Simon Glass
2021-08-06 21:20   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 07/32] ppc: Drop CONFIG_SYS_PCI_SUBSYS_VENDORID Simon Glass
2021-08-06 21:20   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 08/32] pci: powerpc: Drop old code Simon Glass
2021-08-06 21:20   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 09/32] pci: freescale: " Simon Glass
2021-08-06 21:20   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 10/32] pci: dm: core: Drop DM_PCI check from devfdt_get_addr_pci() Simon Glass
2021-08-06 21:20   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 11/32] ppc: Drop DM_PCI from config files Simon Glass
2021-08-06 21:20   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 12/32] pci: acpi: Drop DM_PCI check from ahci Simon Glass
2021-09-14  1:03   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 13/32] pci: usb: Drop DM_PCI from ohci Simon Glass
2021-08-05 23:44   ` Tom Rini
2021-08-06 21:21   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 14/32] ppc: malta: Drop use of DM_PCI Simon Glass
2021-08-06 21:21   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 15/32] ppc: socrates: " Simon Glass
2021-08-06 21:21   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 16/32] pci: gt64120: " Simon Glass
2021-08-06 21:21   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 17/32] pci: msc01: " Simon Glass
2021-08-06 21:21   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 18/32] pci: imx: " Simon Glass
2021-08-06 21:21   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 19/32] pci: scsi: pci: Drop DM_PCI check from scsi Simon Glass
2021-08-06 21:21   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 20/32] pci: Drop DM_PCI check from bios_emul Simon Glass
2021-08-06 21:21   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 21/32] net: Drop DM_PCI check from designware driver Simon Glass
2021-09-14  1:03   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 22/32] pci: imx: Drop DM_PCI check from cpu driver Simon Glass
2021-08-06 21:21   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 23/32] pci: arm: mvebu: Drop DM_PCI check from Simon Glass
2021-08-06 12:46   ` Tom Rini
2021-08-06 21:21   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 24/32] pci: sata_sil: Drop DM_PCI checks Simon Glass
2021-08-06 21:21   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 25/32] distro_bootcmd: Drop DM_PCI check Simon Glass
2021-08-06 12:46   ` Tom Rini
2021-08-06 21:21   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 26/32] pci: Drop pci_init_board() Simon Glass
2021-08-06 21:21   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 27/32] pci: ppc: Drop ftpci100 driver Simon Glass
2021-08-06 21:22   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 28/32] ppc: Drop idt8t49n222a_serdes_clk driver Simon Glass
2021-08-06 21:22   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 29/32] ppc: Drop t4qds and b4860qds references Simon Glass
2021-08-06 21:22   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 30/32] pci: Drop PCI_INDIRECT_BRIDGE Simon Glass
2021-09-14  1:03   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 31/32] pci: Drop DM_PCI Simon Glass
2021-09-14  1:03   ` Tom Rini
2021-08-02  0:54 ` [PATCH v2 32/32] pci: Drop migration method Simon Glass
2021-08-06 21:22   ` Tom Rini
2021-08-07 14:14 ` [PATCH v2 00/32] pci: Drop all pre-driver model code Simon Glass
2021-08-07 14:32   ` Tom Rini
2021-08-07 14:39     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802005446.2267075-5-sjg@chromium.org \
    --to=sjg@chromium.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.