* [PATCH net-next] neighbour: Rename procfs entry
@ 2021-08-02 3:57 Yajun Deng
2021-08-02 16:30 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Yajun Deng @ 2021-08-02 3:57 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, Yajun Deng
Use gc_thresh_{min, default, max} instead of gc_thresh{1, 2, 3}.
This is more friendly for user.
Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
---
net/core/neighbour.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index e831b9adf1e4..c294addb7818 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -3595,7 +3595,7 @@ static struct neigh_sysctl_table {
.proc_handler = proc_dointvec_jiffies,
},
[NEIGH_VAR_GC_THRESH1] = {
- .procname = "gc_thresh1",
+ .procname = "gc_thresh_min",
.maxlen = sizeof(int),
.mode = 0644,
.extra1 = SYSCTL_ZERO,
@@ -3603,7 +3603,7 @@ static struct neigh_sysctl_table {
.proc_handler = proc_dointvec_minmax,
},
[NEIGH_VAR_GC_THRESH2] = {
- .procname = "gc_thresh2",
+ .procname = "gc_thresh_default",
.maxlen = sizeof(int),
.mode = 0644,
.extra1 = SYSCTL_ZERO,
@@ -3611,7 +3611,7 @@ static struct neigh_sysctl_table {
.proc_handler = proc_dointvec_minmax,
},
[NEIGH_VAR_GC_THRESH3] = {
- .procname = "gc_thresh3",
+ .procname = "gc_thresh_max",
.maxlen = sizeof(int),
.mode = 0644,
.extra1 = SYSCTL_ZERO,
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] neighbour: Rename procfs entry
2021-08-02 3:57 [PATCH net-next] neighbour: Rename procfs entry Yajun Deng
@ 2021-08-02 16:30 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2021-08-02 16:30 UTC (permalink / raw)
To: Yajun Deng; +Cc: davem, netdev, linux-kernel
On Mon, 2 Aug 2021 11:57:45 +0800 Yajun Deng wrote:
> Use gc_thresh_{min, default, max} instead of gc_thresh{1, 2, 3}.
> This is more friendly for user.
We can't rename files in procfs after they had been present
in an official kernel release. They are uABI. Same goes for
your default -> current rename patch.
You also forgot to update documentation.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-02 16:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-02 3:57 [PATCH net-next] neighbour: Rename procfs entry Yajun Deng
2021-08-02 16:30 ` Jakub Kicinski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.