All of lore.kernel.org
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: agraf@csgraf.de, trini@konsulko.com, sjg@chromium.org,
	ilias.apalodimas@linaro.org, sughosh.ganu@linaro.org,
	masami.hiramatsu@linaro.org, u-boot@lists.denx.de
Subject: Re: [PATCH v2 4/9] efi_loader: ease the file path check for public key
Date: Mon, 2 Aug 2021 13:50:24 +0900	[thread overview]
Message-ID: <20210802045024.GD7965@laputa> (raw)
In-Reply-To: <ab0b714b-c861-b24f-4644-fa9c83a3511e@gmx.de>

On Sun, Aug 01, 2021 at 11:35:15AM +0200, Heinrich Schuchardt wrote:
> On 7/27/21 11:10 AM, AKASHI Takahiro wrote:
> > The check for CONFIG_EFI_CAPSULE_KEY_PATH:
> >      ifeq ("$(wildcard $(EFI_CAPSULE_KEY_PATH))","")
> > does not allow users to specify a relative path for including a public
> > key binary. This is fine for most of all cases, but it will make it
> > difficult to add pytest test cases as pre-created keys/certificates
> > are placed in "test" directory.
> > 
> > So just ease the check, still causing an error if the specified file
> > does not exist at compiling efi_capsule_key.S.
> > 
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > ---
> >   lib/efi_loader/Makefile | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lib/efi_loader/Makefile b/lib/efi_loader/Makefile
> > index 9b369430e258..fca0da4d131e 100644
> > --- a/lib/efi_loader/Makefile
> > +++ b/lib/efi_loader/Makefile
> > @@ -21,8 +21,9 @@ targets += helloworld.o
> >   endif
> > 
> >   ifeq ($(CONFIG_EFI_CAPSULE_AUTHENTICATE),y)
> > -EFI_CAPSULE_KEY_PATH := $(subst $\",,$(CONFIG_EFI_CAPSULE_KEY_PATH))
> > -ifeq ("$(wildcard $(EFI_CAPSULE_KEY_PATH))","")
> > +#EFI_CAPSULE_KEY_PATH := $(subst $\",,$(CONFIG_EFI_CAPSULE_KEY_PATH))
> > +#ifeq ("$(wildcard $(EFI_CAPSULE_KEY_PATH))","")
> 
> Please, remove these two comment lines.

I forgot to do so.

> > +ifeq ($(CONFIG_EFI_CAPSULE_KEY_PATH),"")
> >   $(error .esl cerificate not found. Configure your CONFIG_EFI_CAPSULE_KEY_PATH)
> 
> %s/cerificate/certificate/

This misspelling does exist in the original.
I won't fix it.

-Takahiro Akashi


> Best regards
> 
> Heinrich
> 
> >   endif
> >   endif
> > 
> 

  reply	other threads:[~2021-08-02  4:50 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27  9:10 [PATCH v2 0/9] efi_loader: capsule: improve capsule authentication support AKASHI Takahiro
2021-07-27  9:10 ` [PATCH v2 1/9] tools: mkeficapsule: add firmwware image signing AKASHI Takahiro
2021-07-28  8:12   ` Masami Hiramatsu
2021-08-01  9:21   ` Heinrich Schuchardt
2021-08-02  3:30     ` AKASHI Takahiro
2021-08-02  6:18       ` Heinrich Schuchardt
2021-08-02  6:55         ` AKASHI Takahiro
2021-07-27  9:10 ` [PATCH v2 2/9] tools: mkeficapsule: add man page AKASHI Takahiro
2021-08-01  9:28   ` Heinrich Schuchardt
2021-07-27  9:10 ` [PATCH v2 3/9] doc: update UEFI document for usage of mkeficapsule AKASHI Takahiro
2021-08-01  9:31   ` Heinrich Schuchardt
2021-07-27  9:10 ` [PATCH v2 4/9] efi_loader: ease the file path check for public key AKASHI Takahiro
2021-08-01  9:35   ` Heinrich Schuchardt
2021-08-02  4:50     ` AKASHI Takahiro [this message]
2021-07-27  9:10 ` [PATCH v2 5/9] test/py: efi_capsule: add image authentication test AKASHI Takahiro
2021-08-01  9:38   ` Heinrich Schuchardt
2021-08-02  4:02     ` AKASHI Takahiro
2021-07-27  9:10 ` [PATCH v2 6/9] sandbox: add config for efi capsule " AKASHI Takahiro
2021-07-28 20:21   ` Heinrich Schuchardt
2021-07-29  0:39     ` AKASHI Takahiro
2021-07-31 16:59   ` Simon Glass
2021-08-01  4:29     ` AKASHI Takahiro
2021-08-01 19:00       ` Simon Glass
2021-08-01 22:57         ` AKASHI Takahiro
2021-08-02 19:19           ` Simon Glass
2021-07-27  9:10 ` [PATCH v2 7/9] GitLab: add a test rule " AKASHI Takahiro
2021-07-27  9:10 ` [PATCH v2 8/9] tools: mkeficapsule: allow for specifying GUID explicitly AKASHI Takahiro
2021-07-27  9:10 ` [PATCH v2 9/9] test/py: efi_capsule: align with the syntax change of mkeficapsule AKASHI Takahiro
2021-08-01  9:40 ` [PATCH v2 0/9] efi_loader: capsule: improve capsule authentication support Heinrich Schuchardt
2021-08-02  5:00   ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802045024.GD7965@laputa \
    --to=takahiro.akashi@linaro.org \
    --cc=agraf@csgraf.de \
    --cc=ilias.apalodimas@linaro.org \
    --cc=masami.hiramatsu@linaro.org \
    --cc=sjg@chromium.org \
    --cc=sughosh.ganu@linaro.org \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.