From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01916C4338F for ; Mon, 2 Aug 2021 09:04:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D15FC60F9F for ; Mon, 2 Aug 2021 09:04:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232711AbhHBJEX (ORCPT ); Mon, 2 Aug 2021 05:04:23 -0400 Received: from mail.netfilter.org ([217.70.188.207]:49244 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232732AbhHBJEW (ORCPT ); Mon, 2 Aug 2021 05:04:22 -0400 Received: from netfilter.org (bl11-146-165.dsl.telepac.pt [85.244.146.165]) by mail.netfilter.org (Postfix) with ESMTPSA id 18C3360037; Mon, 2 Aug 2021 11:03:36 +0200 (CEST) Date: Mon, 2 Aug 2021 11:04:04 +0200 From: Pablo Neira Ayuso To: Phil Sutter Cc: netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH] ebtables: Dump atomic waste Message-ID: <20210802090404.GA1252@salvia> References: <20210730103715.20501-1-phil@nwl.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210730103715.20501-1-phil@nwl.cc> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org Hi Phil, On Fri, Jul 30, 2021 at 12:37:15PM +0200, Phil Sutter wrote: > With ebtables-nft.8 now educating people about the missing > functionality, get rid of atomic remains in source code. This eliminates > mostly comments except for --atomic-commit which was treated as alias of > --init-table. People not using the latter are probably trying to > atomic-commit from an atomic-file which in turn is not supported, so no > point keeping it. That's fine. If there's any need in the future for emulating this in the future, it should be possible to map atomic-save to ebtables-save and atomic-commit to ebtables-restore. Anyway, this one of the exotic options in ebtables that makes it different from ip,ip6,arptables. Given there are better tools now that are aligned with the more orthodox approach, this should be OK. Thanks.