From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18BF6C4338F for ; Mon, 2 Aug 2021 09:08:19 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 00FD360F9F for ; Mon, 2 Aug 2021 09:08:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 00FD360F9F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C359B82E1B; Mon, 2 Aug 2021 11:08:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id A56338337D; Mon, 2 Aug 2021 11:08:13 +0200 (CEST) Received: from ATCSQR.andestech.com (atcsqr.andestech.com [60.248.187.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D525B80082 for ; Mon, 2 Aug 2021 11:08:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (atcpcs16.andestech.com [10.0.1.222]) by ATCSQR.andestech.com with ESMTP id 17297mV8045541; Mon, 2 Aug 2021 17:07:48 +0800 (GMT-8) (envelope-from ycliang@andestech.com) Received: from andestech.com (10.0.15.65) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Mon, 2 Aug 2021 17:07:46 +0800 Date: Mon, 2 Aug 2021 17:07:47 +0800 From: Leo Liang To: Zong Li CC: Subject: Re: [PATCH 2/2] board: sifive: overwrite board_fdt_blob_setup in u-boot proper Message-ID: <20210802090747.GE3588@andestech.com> References: <20210727090659.7525-1-zong.li@sifive.com> <20210727090659.7525-2-zong.li@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20210727090659.7525-2-zong.li@sifive.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Originating-IP: [10.0.15.65] X-DNSRBL: X-MAIL: ATCSQR.andestech.com 17297mV8045541 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, Jul 27, 2021 at 05:06:59PM +0800, Zong Li wrote: > Add board_fdt_blob_setup to return the device tree location which is > passed by prior stage in u-boot proper. The generic board_fdt_blob_setup > always returns _end, it mignt be ok because u-boot SPL would currently > put the dtb there, but it would be broken if we put the dtb to another > place and assigned the location into a1 register for u-boot proper. Use > the location passed by prior stage would make more sence, because we > actually pass the location to u-boot proper and want to use that one, > rather than the dtb which in _end. > > We can't use CONFIG_OF_PRIOR_STAGE because it doens't distinguish the > implementation of u-boot SPL and u-boot proper, so u-boot SPL need to > reply on the prior stage to pass device tree location as well, but we > don't pass the DT from boot rom now. In addition, when > CONFIG_OF_PRIOR_STAGE is enabled, the u-boot-spl.bin and u-boot.itb won't > include the device tree. > > Signed-off-by: Zong Li > --- > board/sifive/unleashed/unleashed.c | 11 +++++++++++ > board/sifive/unmatched/unmatched.c | 11 +++++++++++ > 2 files changed, 22 insertions(+) Reviewed-by: Leo Yu-Chi Liang