From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A2E8C4338F for ; Mon, 2 Aug 2021 11:59:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39A8B60F70 for ; Mon, 2 Aug 2021 11:59:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233455AbhHBL7S (ORCPT ); Mon, 2 Aug 2021 07:59:18 -0400 Received: from mail.netfilter.org ([217.70.188.207]:49678 "EHLO mail.netfilter.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230503AbhHBL7S (ORCPT ); Mon, 2 Aug 2021 07:59:18 -0400 Received: from netfilter.org (bl11-146-165.dsl.telepac.pt [85.244.146.165]) by mail.netfilter.org (Postfix) with ESMTPSA id 1C09760031; Mon, 2 Aug 2021 13:58:33 +0200 (CEST) Date: Mon, 2 Aug 2021 13:59:02 +0200 From: Pablo Neira Ayuso To: Phil Sutter , netfilter-devel@vger.kernel.org Subject: Re: [iptables PATCH] ebtables: Dump atomic waste Message-ID: <20210802115902.GA29377@salvia> References: <20210730103715.20501-1-phil@nwl.cc> <20210802090404.GA1252@salvia> <20210802110555.GW3673@orbyte.nwl.cc> <20210802115127.GA29324@salvia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210802115127.GA29324@salvia> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netfilter-devel@vger.kernel.org offlist On Mon, Aug 02, 2021 at 01:51:27PM +0200, Pablo Neira Ayuso wrote: > On Mon, Aug 02, 2021 at 01:05:55PM +0200, Phil Sutter wrote: > > On Mon, Aug 02, 2021 at 11:04:04AM +0200, Pablo Neira Ayuso wrote: > > > Hi Phil, > > > > > > On Fri, Jul 30, 2021 at 12:37:15PM +0200, Phil Sutter wrote: > > > > With ebtables-nft.8 now educating people about the missing > > > > functionality, get rid of atomic remains in source code. This eliminates > > > > mostly comments except for --atomic-commit which was treated as alias of > > > > --init-table. People not using the latter are probably trying to > > > > atomic-commit from an atomic-file which in turn is not supported, so no > > > > point keeping it. > > > > > > That's fine. > > > > > > If there's any need in the future for emulating this in the future, it > > > should be possible to map atomic-save to ebtables-save and > > > atomic-commit to ebtables-restore. > > > > I had considered that, but the binary format of atomic-file drove me > > off: If we can't support existing atomic-files easily, we better deny > > unless someone has a strong argument to do it. And then I'd try to > > support it fully, so it's not a half-ass solution with a catch. :) > > That's sensible. I did not know the file format is different, I never used exotic ebtables features ever myself.