From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F2BEC4338F for ; Mon, 2 Aug 2021 13:00:22 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 028D160E09 for ; Mon, 2 Aug 2021 13:00:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 028D160E09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 361AE8339D; Mon, 2 Aug 2021 15:00:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="AaN5w9S8"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 309658339D; Mon, 2 Aug 2021 15:00:18 +0200 (CEST) Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 42BFF82CE8 for ; Mon, 2 Aug 2021 15:00:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf33.google.com with SMTP id f91so8789900qva.9 for ; Mon, 02 Aug 2021 06:00:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=020La2mbhKO9cZj6OSNX0IuB0IO1fkzJymSYIOA4Nts=; b=AaN5w9S8qddLzqogi9gb3DlwGzO9sBu3WncUi8eV0dymB7jOKqcc8gQknoMm34x8kG EvthTg8poDiq4WgFkKx0abR2Ms+cSyUpJ0FB38Om9LNMGYgqLHcFOrhFusqxcYu9jPU4 wNskuYTto9WPXEulhrnyCLYimXdhMxQDajfxQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=020La2mbhKO9cZj6OSNX0IuB0IO1fkzJymSYIOA4Nts=; b=P/nHr4ny5+a25Fez32meCvt+wOhv2dEcTNdhWsrjqNLf2Z0xi/8pmOGQeoa6wQPwEK 0/lPxaFXPswp2KBnuu9aEa/53GdUdDuUbsqkq98hiVuNPMu45/X1nOySrFUxItI9Bh44 M+Zh13sp/JGzaCZGhS6qM48Mm4LYYi9dIZDH2AOzcJyOoNwiK63jKfjpGv4QjDoHJvyf qO5xIjBa0LoojDA+01/61o9P0ZfogBIES/fPoVZ+WSOpoBdX0X7oiVkCEFEi9sd33oXM DFtY4cWNM1I/GsO3yzNypYczH/DEKeSOudLlarNgYDXe40ZvOHMrRhbp1OPLUWmh1chA wsQg== X-Gm-Message-State: AOAM533GHmmLo3wKzburFe1CGxyQwtIdT9tO499qRCcNY38/QyI5q27E fO4CkhxOfoC4tyRuNvOnMnpLTQ== X-Google-Smtp-Source: ABdhPJynsBUpx1uQPuUEZoFUhhCYDPUECNLFlU02czA8GBK0+EVa6WAaKRD2Y/tOHCqVwTAP+5Tn/A== X-Received: by 2002:ad4:4a8c:: with SMTP id h12mr16017372qvx.62.1627909211602; Mon, 02 Aug 2021 06:00:11 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-ed77-66b8-7f0a-3b78.res6.spectrum.com. [2603:6081:7b01:cbda:ed77:66b8:7f0a:3b78]) by smtp.gmail.com with ESMTPSA id l14sm4633254qtj.26.2021.08.02.06.00.10 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Aug 2021 06:00:10 -0700 (PDT) Date: Mon, 2 Aug 2021 09:00:08 -0400 From: Tom Rini To: Marek Vasut Cc: Jan Kiszka , U-Boot Mailing List , Hai Pham , Simon Goldschmidt , Stephen Warren , Lokesh Vutla Subject: Re: [PATCH] Revert "arm: bootm: Disable LMB reservation for command line and board info on arm64" Message-ID: <20210802130008.GR9379@bill-the-cat> References: <1971775f-28de-83d0-9459-a4e68c744a18@siemens.com> <20210729152307.GP9379@bill-the-cat> <20210729165802.GA9379@bill-the-cat> <446b4861-6987-092a-43ce-5d3aa322f8f3@denx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iypyCFsJOaOiUfyx" Content-Disposition: inline In-Reply-To: <446b4861-6987-092a-43ce-5d3aa322f8f3@denx.de> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --iypyCFsJOaOiUfyx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 02, 2021 at 02:54:22AM +0200, Marek Vasut wrote: > On 7/29/21 6:58 PM, Tom Rini wrote: >=20 > [...] >=20 > > > > so when did rcar3 introduce something there that shouldn't be > > > > reserved? And you had phrased this to me on IRC as about reserving= spot > > > > for ATAGS, and that not being needed of course on arm64. But that'= s not > > > > what's going on. Perhaps the answer is that rcar3 needs to introdu= ce a > > > > board_lmb_reserve to free the normal arch one and provide whatever = more > > > > narrow scope it needs. > > >=20 > > > Based on the commit message 2359fa7a878 ("arm: bootm: Disable LMB > > > reservation for command line and board info on arm64") , this is abou= t ATAGS > > > and we really don't need to reserve those on arm64. > >=20 > > Commit 2359fa7a878 disables the entire arch_lmb_reserve function on > > aarch64, yes. I assumed when we had talked that it was a small area > > being set aside and perhaps mis-recalled that ATAGS tended to live at > > DDR_BASE + 0x800 or so. >=20 > That arch_lmb_reserve() is responsible for reserving architecture specific > memory. On arm32 it is ATAGS, on arm64 it is nothing as far as I can tell > (and see below regarding the TLB). I don't think that LMB ever covered ATAGS. ATAGS, I could have sworn, were at start of memory + 0x800 or so. This LMB is for the top of memory where U-Boot is. --=20 Tom --iypyCFsJOaOiUfyx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEH7FIACgkQFHw5/5Y0 tyxoAwwAqU69hTye1QEY3srZ+LmOqds/1u7H3K7NLrKAHWqfaOx0OB2FS/qfGZBY zh6ONFSgqFkc+PlqbH10TWnOBJy7d9jKnuoffGiAmCgi6dVEHtrsIFGOV4ZL/1z4 F9JjiC9iofKDgHwEZmnxqtHEqWGVFhqagvcjLFjLubBGLR+fvIScUaVUrTg06GO4 dWmJxsv8R67p1TnQ2EXoQaFSkY0VSI3+tFfo1vmYLFZD/jjSYhutUsb2p8yStXol Y8FNaPFYLYh0armrM+a+dBYS1tGv6MWx/2Bw7+bEU3RSPuGQDIIdunHzvBeiXhle tn/8YSJjbih+BR3lmUEm7Yxg7+STzrfSa94KxhBEdNuwiIB93BQTN+LqY1iWAsj3 qLvbBL9yNbGu7d32K+H5YYcgeqAwltT18tn38RrYXFz9dYFzzn7zCFWTVdET1t15 R/mhbnVWcGrlfstpCQYBSv/wM0+mMG7Ue8g0snF52jBXnMMnUWRQCROJsS2xjOzZ Lfbl5H8x =DeaT -----END PGP SIGNATURE----- --iypyCFsJOaOiUfyx--