[PATCH] btrfs: mark compressed range uptodate only if all bio succeed

From: Goldwyn Rodrigues <rgoldwyn@suse.com>
To: gregkh@linuxfoundation.org
Cc: stable@vger.kernel.org, dsterba@suse.com
Subject: [PATCH] btrfs: mark compressed range uptodate only if all bio succeed
Date: Mon, 2 Aug 2021 09:31:07 -0500	[thread overview]
Message-ID: <20210802143107.d5qglh642bh4uktg@fiona> (raw)
In-Reply-To: <162771320782111@kroah.com>

Git-commit: 240246f6b913b0c23733cfd2def1d283f8cc9bbe
For: v4.9

In compression write endio sequence, the range which the compressed_bio
writes is marked as uptodate if the last bio of the compressed (sub)bios
is completed successfully. There could be previous bio which may
have failed which is recorded in cb->errors.

Set the writeback range as uptodate only if cb->errors is zero, as opposed
to checking only the last bio's status.

Backporting notes: in all versions up to 4.4 the last argument is always
replaced by "!cb->errors".

Signed-off-by: Goldwyn Rodrigues <rgoldwyn@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/compression.c b/fs/btrfs/compression.c
index d4d8b7e36b2f..2534e44cfd40 100644
--- a/fs/btrfs/compression.c
+++ b/fs/btrfs/compression.c
@@ -290,7 +290,7 @@ static void end_compressed_bio_write(struct bio *bio)
 					 cb->start,
 					 cb->start + cb->len - 1,
 					 NULL,
-					 bio->bi_error ? 0 : 1);
+					 !cb->errors);
 	cb->compressed_pages[0]->mapping = NULL;
 
 	end_compressed_writeback(inode, cb);

-- 
Goldwyn
