From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC101C4338F for ; Mon, 2 Aug 2021 19:42:36 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32F9C60F58 for ; Mon, 2 Aug 2021 19:42:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 32F9C60F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 094C382D1C; Mon, 2 Aug 2021 21:42:34 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Tvrv07G4"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D3DD882D81; Mon, 2 Aug 2021 21:42:31 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 8A6B582D1C for ; Mon, 2 Aug 2021 21:42:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id 7A59B60FC0; Mon, 2 Aug 2021 19:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1627933346; bh=SMxg6Gd/5ibmtx3s51XlT6ahACiHsdkj5GUto1cMREA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Tvrv07G424et15dvTaBotvP5tYlMhLdjtmrn82v0INCNRAzloUOb2RSyHJfpFSiUQ aJPjh492oZpVJv6LjN3UgPMhyQcIDeYUuwrbNlQhxtcrt/Rts2hUrSXBHbyPIL6R1o 7OMednnIYu9cQOR6gaa08NX2b/FHGf+30jJrnaIi0f7/9qt8ujxhPUXn846oKg9yL1 BCuUtiKVj02KuVBs6nzZMI2N2AzBnwLfIeRtpLwPmFgAnlup1sy79dCNG5r4ozwTUv lT1smG2Emga72n8b+LOA7kMpG8akxc1zAbtwsNVyenoalo3H+rC2As0h+sFyTxFG29 X9Br3ZbT7nRDA== Received: by pali.im (Postfix) id 0AA8EB98; Mon, 2 Aug 2021 21:42:23 +0200 (CEST) Date: Mon, 2 Aug 2021 21:42:23 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Simon Glass Cc: Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?utf-8?B?QmVow7pu?= , Tom Rini , U-Boot Mailing List Subject: Re: [PATCH 11/11] Remove including timestamp.h in version.h Message-ID: <20210802194223.5myvz6l27rjkfrld@pali> References: <20210802131838.21097-1-pali@kernel.org> <20210802131838.21097-12-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Monday 02 August 2021 13:21:58 Simon Glass wrote: > Hi Pali, > > On Mon, 2 Aug 2021 at 07:20, Pali Rohár wrote: > > > > Header file version.h does not use anything from timestamp.h. Including of > > timestamp.h has side effect which cause recompiling object file at every > > make run because timestamp.h changes at every run. > > > > So remove timestamp.h from version.h and include timestamp.h in files > > which needs it. > > > > This change reduce recompilation time of final U-Boot binary when U-Boot > > source files were not changed as less source files needs to be recompiled. > > > > Signed-off-by: Pali Rohár > > --- > > arch/arm/mach-rockchip/tpl.c | 4 ++++ > > board/work-microwave/work_92105/work_92105_display.c | 1 + > > cmd/version.c | 1 + > > common/spl/spl.c | 4 ++++ > > drivers/rtc/emul_rtc.c | 2 +- > > include/version.h | 2 -- > > 6 files changed, 11 insertions(+), 3 deletions(-) > > Reviewed-by: Simon Glass > > I assume we do actually want to regenerate the timestamp when U-Boot > builds, even if nothing has changed. Is that right? This is current behavior and these my patches do not change it. Patches just smartly moves the source of this timestamp (from macros to global variable; so source files do not have to be recompiled when external global variable changes -- as opposite of macros). > It could be > confusing otherwise, as people cannot 'update' the banner without > making a trivial change. IIRC linux kernel does not change this date 'banner' when nothing was changed. So maybe it is, maybe it is not confusing...