All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Matt Merhar <mattmerhar@protonmail.com>,
	Peter Geis <pgwipeout@gmail.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
	linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: [PATCH v2 11/15] ARM: tegra: acer-a500: Remove bogus USB VBUS regulators
Date: Tue,  3 Aug 2021 00:19:43 +0300	[thread overview]
Message-ID: <20210802211947.19715-12-digetx@gmail.com> (raw)
In-Reply-To: <20210802211947.19715-1-digetx@gmail.com>

The configuration of USB VBUS regulators was borrowed from downstream
kernel, which is incorrect because the corresponding GPIOs are connected
to PROX_EN (A501 3G model) and LED_EN pins in accordance to the board
schematics. USB works fine with both GPIOs being disabled, so remove the
bogus USB VBUS regulators. The USB VBUS of USB3 is supplied from the fixed
5v system regulator and device-mode USB1 doesn't have VBUS switches.

Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
 .../boot/dts/tegra20-acer-a500-picasso.dts    | 25 +------------------
 1 file changed, 1 insertion(+), 24 deletions(-)

diff --git a/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts b/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
index 4897079680bd..c385b13d4faa 100644
--- a/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
+++ b/arch/arm/boot/dts/tegra20-acer-a500-picasso.dts
@@ -723,7 +723,6 @@ usb-phy@c5000000 {
 		nvidia,xcvr-setup-use-fuses;
 		nvidia,xcvr-lsfslew = <2>;
 		nvidia,xcvr-lsrslew = <2>;
-		vbus-supply = <&vdd_vbus1>;
 	};
 
 	usb@c5008000 {
@@ -735,7 +734,7 @@ usb-phy@c5008000 {
 		nvidia,xcvr-setup-use-fuses;
 		nvidia,xcvr-lsfslew = <2>;
 		nvidia,xcvr-lsrslew = <2>;
-		vbus-supply = <&vdd_vbus3>;
+		vbus-supply = <&vdd_5v0_sys>;
 	};
 
 	brcm_wifi_pwrseq: wifi-pwrseq {
@@ -995,28 +994,6 @@ vdd_pnl: regulator@3 {
 		vin-supply = <&vdd_5v0_sys>;
 	};
 
-	vdd_vbus1: regulator@4 {
-		compatible = "regulator-fixed";
-		regulator-name = "vdd_usb1_vbus";
-		regulator-min-microvolt = <5000000>;
-		regulator-max-microvolt = <5000000>;
-		regulator-always-on;
-		gpio = <&gpio TEGRA_GPIO(D, 0) GPIO_ACTIVE_HIGH>;
-		enable-active-high;
-		vin-supply = <&vdd_5v0_sys>;
-	};
-
-	vdd_vbus3: regulator@5 {
-		compatible = "regulator-fixed";
-		regulator-name = "vdd_usb3_vbus";
-		regulator-min-microvolt = <5000000>;
-		regulator-max-microvolt = <5000000>;
-		regulator-always-on;
-		gpio = <&gpio TEGRA_GPIO(D, 3) GPIO_ACTIVE_HIGH>;
-		enable-active-high;
-		vin-supply = <&vdd_5v0_sys>;
-	};
-
 	sound {
 		compatible = "nvidia,tegra-audio-wm8903-picasso",
 			     "nvidia,tegra-audio-wm8903";
-- 
2.32.0


  parent reply	other threads:[~2021-08-02 21:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02 21:19 [PATCH v2 00/15] Tegra ARM32 device-tree improvements for 5.15 Dmitry Osipenko
2021-08-02 21:19 ` [PATCH v2 01/15] ARM: tegra: Add SoC thermal sensor to Tegra30 device-trees Dmitry Osipenko
2021-08-02 21:19 ` [PATCH v2 02/15] ARM: tegra: ouya: Add interrupt to temperature sensor node Dmitry Osipenko
2021-08-02 21:19 ` [PATCH v2 03/15] ARM: tegra: paz00: " Dmitry Osipenko
2021-08-02 21:19 ` [PATCH v2 04/15] ARM: tegra: nexus7: " Dmitry Osipenko
2021-08-02 21:19 ` [PATCH v2 05/15] ARM: tegra: acer-a500: " Dmitry Osipenko
2021-08-02 21:19 ` [PATCH v2 06/15] ARM: tegra: nyan: Correct interrupt trigger type of temperature sensor Dmitry Osipenko
2021-08-02 21:19 ` [PATCH v2 07/15] ARM: tegra: apalis: " Dmitry Osipenko
2021-08-02 21:19 ` [PATCH v2 08/15] ARM: tegra: cardhu: " Dmitry Osipenko
2021-08-02 21:19 ` [PATCH v2 09/15] ARM: tegra: dalmore: " Dmitry Osipenko
2021-08-02 21:19 ` [PATCH v2 10/15] ARM: tegra: jetson-tk1: " Dmitry Osipenko
2021-08-02 21:19 ` Dmitry Osipenko [this message]
2021-08-02 21:19 ` [PATCH v2 12/15] ARM: tegra: acer-a500: Add power supplies to accelerometer Dmitry Osipenko
2021-08-02 21:19 ` [PATCH v2 13/15] ARM: tegra: acer-a500: Use verbose variant of atmel,wakeup-method value Dmitry Osipenko
2021-08-02 21:19 ` [PATCH v2 14/15] ARM: tegra: acer-a500: Improve thermal zones Dmitry Osipenko
2021-08-02 21:19 ` [PATCH v2 15/15] ARM: tegra: nexus7: " Dmitry Osipenko
2021-08-11 10:05 ` [PATCH v2 00/15] Tegra ARM32 device-tree improvements for 5.15 Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210802211947.19715-12-digetx@gmail.com \
    --to=digetx@gmail.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mattmerhar@protonmail.com \
    --cc=pgwipeout@gmail.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.