From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FE65C4338F for ; Mon, 2 Aug 2021 21:31:20 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECECE60F39 for ; Mon, 2 Aug 2021 21:31:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ECECE60F39 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 919AB83446; Mon, 2 Aug 2021 23:31:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="o9YQgemd"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 85E5B83447; Mon, 2 Aug 2021 23:31:17 +0200 (CEST) Received: from mail-qt1-x833.google.com (mail-qt1-x833.google.com [IPv6:2607:f8b0:4864:20::833]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2CBE783446 for ; Mon, 2 Aug 2021 23:31:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x833.google.com with SMTP id d2so12661252qto.6 for ; Mon, 02 Aug 2021 14:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZNu/fGGANcF353vokXNVw9cLaq7GSB7MT1S1dIccZlM=; b=o9YQgemdFQ3R4UpHiRx2CEZ/pBZL3BN9CKOYGd0hx5eX7PgARR/eGffNB6WPrMWZbU neoO7Hc+jYy9gq/sN3Cktg6YtiD0RQH4AoctaPQ6n7/2ZL7PHlN1sBgx4XEv9eyMFq1a ROyDyTu0p0iSYZp7ODSyzf3KNebTijtRumCus= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZNu/fGGANcF353vokXNVw9cLaq7GSB7MT1S1dIccZlM=; b=uiiD00zFB7EMi+yUV0dsevPaNXq06Q2Jv1qTEz7r9cbKduTIqUGv4oDgZ+FAJs9vlc Jd8OQMmsARjS7lSU0LF2H6WfRZfg7Fs9Nc8xeX+d2HbC2+6I2w1eWLg2niO/3IR1eNk3 P5wIRrIIO513BPKQXSk7LgGww55lzkoSez5Eno0DqK4h0dh+iXfMiwmwFG0vgHR01r9q J0rysgut4iRTkhAQXg0cKgLzqoZayKssRWnwVcrhBLCTCZngicvXIWvyT0wNDLSndfqd snOIgAZlbflAUZfLMUDTOgannrUK/jvj1vWuYYx+SrA1Kj3kQj/R+vI7MXpK4D0bsvOS C5yg== X-Gm-Message-State: AOAM531BPvOaOfphE9d4/AadEFxrVU1pBscESd2deeePro6LyxSoetnl K1dHs2Cc0RTBkZCAOa+WUMzW+g== X-Google-Smtp-Source: ABdhPJzSa8f7esVhjMS50zwxqgkTuuRM3SN7lEzA538AJdeugHeMEXlNFT47DL4rd1D/HQQwCszRjA== X-Received: by 2002:aed:206a:: with SMTP id 97mr928823qta.180.1627939862999; Mon, 02 Aug 2021 14:31:02 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a0a3-ef76-0712-405d.res6.spectrum.com. [2603:6081:7b01:cbda:a0a3:ef76:712:405d]) by smtp.gmail.com with ESMTPSA id 74sm6629228qkh.42.2021.08.02.14.31.01 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 02 Aug 2021 14:31:02 -0700 (PDT) Date: Mon, 2 Aug 2021 17:31:00 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Simon Glass , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?iso-8859-1?Q?Beh=FAn?= , U-Boot Mailing List Subject: Re: [PATCH 11/11] Remove including timestamp.h in version.h Message-ID: <20210802213100.GG9379@bill-the-cat> References: <20210802131838.21097-1-pali@kernel.org> <20210802131838.21097-12-pali@kernel.org> <20210802194223.5myvz6l27rjkfrld@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7kk4IND6+1vYtI79" Content-Disposition: inline In-Reply-To: <20210802194223.5myvz6l27rjkfrld@pali> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --7kk4IND6+1vYtI79 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 02, 2021 at 09:42:23PM +0200, Pali Roh=E1r wrote: > On Monday 02 August 2021 13:21:58 Simon Glass wrote: > > Hi Pali, > >=20 > > On Mon, 2 Aug 2021 at 07:20, Pali Roh=E1r wrote: > > > > > > Header file version.h does not use anything from timestamp.h. Includi= ng of > > > timestamp.h has side effect which cause recompiling object file at ev= ery > > > make run because timestamp.h changes at every run. > > > > > > So remove timestamp.h from version.h and include timestamp.h in files > > > which needs it. > > > > > > This change reduce recompilation time of final U-Boot binary when U-B= oot > > > source files were not changed as less source files needs to be recomp= iled. > > > > > > Signed-off-by: Pali Roh=E1r > > > --- > > > arch/arm/mach-rockchip/tpl.c | 4 ++++ > > > board/work-microwave/work_92105/work_92105_display.c | 1 + > > > cmd/version.c | 1 + > > > common/spl/spl.c | 4 ++++ > > > drivers/rtc/emul_rtc.c | 2 +- > > > include/version.h | 2 -- > > > 6 files changed, 11 insertions(+), 3 deletions(-) > >=20 > > Reviewed-by: Simon Glass > >=20 > > I assume we do actually want to regenerate the timestamp when U-Boot > > builds, even if nothing has changed. Is that right? >=20 > This is current behavior and these my patches do not change it. Patches > just smartly moves the source of this timestamp (from macros to global > variable; so source files do not have to be recompiled when external > global variable changes -- as opposite of macros). >=20 > > It could be > > confusing otherwise, as people cannot 'update' the banner without > > making a trivial change. >=20 > IIRC linux kernel does not change this date 'banner' when nothing was > changed. So maybe it is, maybe it is not confusing... I think that if nothing changes the banner not changing is the right behavior. Reviewed-by: Tom Rini --=20 Tom --7kk4IND6+1vYtI79 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEIZBQACgkQFHw5/5Y0 tyz5Kgv8DtDyTjO0f8pMwusSZkIM1fxONVqE2E6Y3tkZ1a24wW5iPxJklxVf0o3B khyPnKFNMtQYmBipG2Wp1jPaf8ErPskM8n2qvs5uHDIxoSSWccUuhOg7XMDDb7vl 18AMGTiouUV6WHYF1nqoJ0vcCKgXyhQRcJLxn58lZri8QvAsPsCi2v4gpBxoBd9B cc1kflMBd+JCS+EqcEfWng2eNHbJ1CL3b7Qi+LyaN7Chj70XV9YdkpMNMH8Mo9cS cUPk5ozDSKsSm8IeZnZatTvMhHenY9mot97QrGcHwIEjtoAn0PXROuOqaKulrhic xPtaYW4m1zXG9jzk+PUxCAvckpr5pC6KU2cgCdne2WFRInXEeV3vqshStPtMPU5E v/hNIFH9d9M5J5r8RySs5+yW1dbZWQ+Q1u/Vk+Yv4RqWtmmSb5gbVLZRyV239eFZ 7EnGeDybSODQFXdCaFjeqsZO3BMy+2GRfIvhEDa7kV+xsuvH/QNZVn7WEiB0gT6Z HktvaYA1 =E9kl -----END PGP SIGNATURE----- --7kk4IND6+1vYtI79--