[PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param

[PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param

[Mason Zhang]

This patch fixed set_cs_timing param, because cs timing delay has
been moved to spi_device.

Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com>
---
 drivers/spi/spi-tegra114.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index 5131141bbf0d..e9de1d958bbd 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -717,12 +717,12 @@ static void tegra_spi_deinit_dma_param(struct tegra_spi_data *tspi,
 	dma_release_channel(dma_chan);
 }
 
-static int tegra_spi_set_hw_cs_timing(struct spi_device *spi,
-				      struct spi_delay *setup,
-				      struct spi_delay *hold,
-				      struct spi_delay *inactive)
+static int tegra_spi_set_hw_cs_timing(struct spi_device *spi)
 {
 	struct tegra_spi_data *tspi = spi_master_get_devdata(spi->master);
+	struct spi_delay *setup = &spi->cs_setup;
+	struct spi_delay *hold = &spi->cs_hold;
+	struct spi_delay *inactive = &spi->cs_inactive;
 	u8 setup_dly, hold_dly, inactive_dly;
 	u32 setup_hold;
 	u32 spi_cs_timing;
-- 
2.18.0

[PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param

[Mason Zhang]

This patch fixed set_cs_timing param, because cs timing delay has
been moved to spi_device.

Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com>
---
 drivers/spi/spi-tegra114.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index 5131141bbf0d..e9de1d958bbd 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -717,12 +717,12 @@ static void tegra_spi_deinit_dma_param(struct tegra_spi_data *tspi,
 	dma_release_channel(dma_chan);
 }
 
-static int tegra_spi_set_hw_cs_timing(struct spi_device *spi,
-				      struct spi_delay *setup,
-				      struct spi_delay *hold,
-				      struct spi_delay *inactive)
+static int tegra_spi_set_hw_cs_timing(struct spi_device *spi)
 {
 	struct tegra_spi_data *tspi = spi_master_get_devdata(spi->master);
+	struct spi_delay *setup = &spi->cs_setup;
+	struct spi_delay *hold = &spi->cs_hold;
+	struct spi_delay *inactive = &spi->cs_inactive;
 	u8 setup_dly, hold_dly, inactive_dly;
 	u32 setup_hold;
 	u32 spi_cs_timing;
-- 
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

[PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param

[Mason Zhang]

This patch fixed set_cs_timing param, because cs timing delay has
been moved to spi_device.

Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com>
---
 drivers/spi/spi-tegra114.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/spi/spi-tegra114.c b/drivers/spi/spi-tegra114.c
index 5131141bbf0d..e9de1d958bbd 100644
--- a/drivers/spi/spi-tegra114.c
+++ b/drivers/spi/spi-tegra114.c
@@ -717,12 +717,12 @@ static void tegra_spi_deinit_dma_param(struct tegra_spi_data *tspi,
 	dma_release_channel(dma_chan);
 }
 
-static int tegra_spi_set_hw_cs_timing(struct spi_device *spi,
-				      struct spi_delay *setup,
-				      struct spi_delay *hold,
-				      struct spi_delay *inactive)
+static int tegra_spi_set_hw_cs_timing(struct spi_device *spi)
 {
 	struct tegra_spi_data *tspi = spi_master_get_devdata(spi->master);
+	struct spi_delay *setup = &spi->cs_setup;
+	struct spi_delay *hold = &spi->cs_hold;
+	struct spi_delay *inactive = &spi->cs_inactive;
 	u8 setup_dly, hold_dly, inactive_dly;
 	u32 setup_hold;
 	u32 spi_cs_timing;
-- 
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 736 bytes --]

On Tue, Aug 03, 2021 at 06:25:18PM +0800, Mason Zhang wrote:
> This patch fixed set_cs_timing param, because cs timing delay has
> been moved to spi_device.
> 
> Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com>
> ---
>  drivers/spi/spi-tegra114.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Each individual patch in the series needs to be buildable by itself, if
an earlier commit in the series causes things to fail to build then that
commit needs to be improved so that this doesn't happen.  This supports
things like bisection.

Please also look into how you're sending serieses, these patches aren't
threaded together as normal and there's a weird "***" in the subject of
the first patch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 736 bytes --]

On Tue, Aug 03, 2021 at 06:25:18PM +0800, Mason Zhang wrote:
> This patch fixed set_cs_timing param, because cs timing delay has
> been moved to spi_device.
> 
> Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com>
> ---
>  drivers/spi/spi-tegra114.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Each individual patch in the series needs to be buildable by itself, if
an earlier commit in the series causes things to fail to build then that
commit needs to be improved so that this doesn't happen.  This supports
things like bisection.

Please also look into how you're sending serieses, these patches aren't
threaded together as normal and there's a weird "***" in the subject of
the first patch.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 170 bytes --]

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

Re: [PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 736 bytes --]

On Tue, Aug 03, 2021 at 06:25:18PM +0800, Mason Zhang wrote:
> This patch fixed set_cs_timing param, because cs timing delay has
> been moved to spi_device.
> 
> Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com>
> ---
>  drivers/spi/spi-tegra114.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Each individual patch in the series needs to be buildable by itself, if
an earlier commit in the series causes things to fail to build then that
commit needs to be improved so that this doesn't happen.  This supports
things like bisection.

Please also look into how you're sending serieses, these patches aren't
threaded together as normal and there's a weird "***" in the subject of
the first patch.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param

[Mason Zhang]

On Tue, 2021-08-03 at 15:10 +0100, Mark Brown wrote:
> On Tue, Aug 03, 2021 at 06:25:18PM +0800, Mason Zhang wrote:
> > This patch fixed set_cs_timing param, because cs timing delay has
> > been moved to spi_device.
> > 
> > Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com>
> > ---
> >  drivers/spi/spi-tegra114.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Each individual patch in the series needs to be buildable by itself, if
> an earlier commit in the series causes things to fail to build then that
> commit needs to be improved so that this doesn't happen.  This supports
> things like bisection.
> 
> Please also look into how you're sending serieses, these patches aren't
> threaded together as normal and there's a weird "***" in the subject of
> the first patch.


Dear Mark:

	Thanks for your suggestions, I have merged patch 2/3/4 in one patch to
ensure it can be built by itself.
	And I have updated the patch v3, and removed the *** int the first
patch.


Thanks
Mason

Re: [PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param

[Mason Zhang]

On Tue, 2021-08-03 at 15:10 +0100, Mark Brown wrote:
> On Tue, Aug 03, 2021 at 06:25:18PM +0800, Mason Zhang wrote:
> > This patch fixed set_cs_timing param, because cs timing delay has
> > been moved to spi_device.
> > 
> > Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com>
> > ---
> >  drivers/spi/spi-tegra114.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Each individual patch in the series needs to be buildable by itself, if
> an earlier commit in the series causes things to fail to build then that
> commit needs to be improved so that this doesn't happen.  This supports
> things like bisection.
> 
> Please also look into how you're sending serieses, these patches aren't
> threaded together as normal and there's a weird "***" in the subject of
> the first patch.


Dear Mark:

	Thanks for your suggestions, I have merged patch 2/3/4 in one patch to
ensure it can be built by itself.
	And I have updated the patch v3, and removed the *** int the first
patch.


Thanks
Mason
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

Re: [PATCH v2 4/4] spi: tegra114: Fix set_cs_timing param

[Mason Zhang]

On Tue, 2021-08-03 at 15:10 +0100, Mark Brown wrote:
> On Tue, Aug 03, 2021 at 06:25:18PM +0800, Mason Zhang wrote:
> > This patch fixed set_cs_timing param, because cs timing delay has
> > been moved to spi_device.
> > 
> > Signed-off-by: Mason Zhang <Mason.Zhang@mediatek.com>
> > ---
> >  drivers/spi/spi-tegra114.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> Each individual patch in the series needs to be buildable by itself, if
> an earlier commit in the series causes things to fail to build then that
> commit needs to be improved so that this doesn't happen.  This supports
> things like bisection.
> 
> Please also look into how you're sending serieses, these patches aren't
> threaded together as normal and there's a weird "***" in the subject of
> the first patch.


Dear Mark:

	Thanks for your suggestions, I have merged patch 2/3/4 in one patch to
ensure it can be built by itself.
	And I have updated the patch v3, and removed the *** int the first
patch.


Thanks
Mason
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel