From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 54F6EC4338F for ; Tue, 3 Aug 2021 17:16:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2673A60230 for ; Tue, 3 Aug 2021 17:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237829AbhHCRQL (ORCPT ); Tue, 3 Aug 2021 13:16:11 -0400 Received: from foss.arm.com ([217.140.110.172]:52528 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237775AbhHCRPL (ORCPT ); Tue, 3 Aug 2021 13:15:11 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8181B139F; Tue, 3 Aug 2021 10:14:59 -0700 (PDT) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 34F2A3F40C; Tue, 3 Aug 2021 10:14:57 -0700 (PDT) Date: Tue, 3 Aug 2021 18:14:51 +0100 From: Lorenzo Pieralisi To: Boqun Feng Cc: Bjorn Helgaas , Arnd Bergmann , Marc Zyngier , Catalin Marinas , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, Sunil Muthuswamy , Mike Rapoport Subject: Re: [PATCH v6 8/8] PCI: hv: Turn on the host bridge probing on ARM64 Message-ID: <20210803171451.GA15466@lpieralisi> References: <20210726180657.142727-1-boqun.feng@gmail.com> <20210726180657.142727-9-boqun.feng@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210726180657.142727-9-boqun.feng@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 27, 2021 at 02:06:57AM +0800, Boqun Feng wrote: > Now we have everything we need, just provide a proper sysdata type for > the bus to use on ARM64 and everything else works. > > Signed-off-by: Boqun Feng > --- > drivers/pci/controller/pci-hyperv.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c > index e6276aaa4659..62dbe98d1fe1 100644 > --- a/drivers/pci/controller/pci-hyperv.c > +++ b/drivers/pci/controller/pci-hyperv.c > @@ -40,6 +40,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -448,7 +449,11 @@ enum hv_pcibus_state { > }; > > struct hv_pcibus_device { > +#ifdef CONFIG_X86 > struct pci_sysdata sysdata; > +#elif defined(CONFIG_ARM64) > + struct pci_config_window sysdata; This is ugly. HV does not need pci_config_window at all right (other than arm64 pcibios_root_bridge_prepare()) ? The issue is that in HV you have to have *some* sysdata != NULL, it is just some data to retrieve the hv_pcibus_device. Mmaybe we can rework ARM64 ACPI code to store the acpi_device in struct pci_host_bridge->private instead of retrieving it from pci_config_window so that we decouple HV from the ARM64 back-end. HV would just set struct pci_host_bridge->private == NULL. I need to think about this a bit, I don't think it should block this series though but it would be nicer. Lorenzo > +#endif > struct pci_host_bridge *bridge; > struct fwnode_handle *fwnode; > /* Protocol version negotiated with the host */ > @@ -3075,7 +3080,9 @@ static int hv_pci_probe(struct hv_device *hdev, > dom_req, dom); > > hbus->bridge->domain_nr = dom; > +#ifdef CONFIG_X86 > hbus->sysdata.domain = dom; > +#endif > > hbus->hdev = hdev; > INIT_LIST_HEAD(&hbus->children); > -- > 2.32.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15C2CC4338F for ; Tue, 3 Aug 2021 17:16:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA70461037 for ; Tue, 3 Aug 2021 17:16:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DA70461037 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xWBBg8VP7WmqWFh3cOvZbpkJLBduGKiWDOT9WVwyWUs=; b=P8HB9Va/8X0jHK xdAqvZjOd21/XnxoKIIbsHhgH30tQI7s9qSXfqMAUCIC4fUlPWuXTAoW/NiIc1On68jdbppgAfJpT A3L718zJX0XXAxHJg2Cs4NO5HwRGPZ0Ea/EAyIAK3N9pZ1SR4oQR7kqrY9sXKawBsmRYzAbzf5/92 w1lNAuk8t7T/wOCQ9EXXC2skvuwG2SlV161gYGEs1+QhJexoCX3Ft8sI9V07BYmRo4arTnZ69FImY Fd4MQ+zN699LyT414z4BKgFA46ANRH9rEFUjPKiCmt3gab6zIyy1LidHnjN2I3rt3Gy5QnZLCjafv 9s533TsJRpnL0n6H+r0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAy0S-003n7z-Nz; Tue, 03 Aug 2021 17:15:08 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAy0P-003n74-FH for linux-arm-kernel@lists.infradead.org; Tue, 03 Aug 2021 17:15:07 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8181B139F; Tue, 3 Aug 2021 10:14:59 -0700 (PDT) Received: from lpieralisi (e121166-lin.cambridge.arm.com [10.1.196.255]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 34F2A3F40C; Tue, 3 Aug 2021 10:14:57 -0700 (PDT) Date: Tue, 3 Aug 2021 18:14:51 +0100 From: Lorenzo Pieralisi To: Boqun Feng Cc: Bjorn Helgaas , Arnd Bergmann , Marc Zyngier , Catalin Marinas , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, Sunil Muthuswamy , Mike Rapoport Subject: Re: [PATCH v6 8/8] PCI: hv: Turn on the host bridge probing on ARM64 Message-ID: <20210803171451.GA15466@lpieralisi> References: <20210726180657.142727-1-boqun.feng@gmail.com> <20210726180657.142727-9-boqun.feng@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210726180657.142727-9-boqun.feng@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210803_101505_609755_078EC09C X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 27, 2021 at 02:06:57AM +0800, Boqun Feng wrote: > Now we have everything we need, just provide a proper sysdata type for > the bus to use on ARM64 and everything else works. > > Signed-off-by: Boqun Feng > --- > drivers/pci/controller/pci-hyperv.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c > index e6276aaa4659..62dbe98d1fe1 100644 > --- a/drivers/pci/controller/pci-hyperv.c > +++ b/drivers/pci/controller/pci-hyperv.c > @@ -40,6 +40,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -448,7 +449,11 @@ enum hv_pcibus_state { > }; > > struct hv_pcibus_device { > +#ifdef CONFIG_X86 > struct pci_sysdata sysdata; > +#elif defined(CONFIG_ARM64) > + struct pci_config_window sysdata; This is ugly. HV does not need pci_config_window at all right (other than arm64 pcibios_root_bridge_prepare()) ? The issue is that in HV you have to have *some* sysdata != NULL, it is just some data to retrieve the hv_pcibus_device. Mmaybe we can rework ARM64 ACPI code to store the acpi_device in struct pci_host_bridge->private instead of retrieving it from pci_config_window so that we decouple HV from the ARM64 back-end. HV would just set struct pci_host_bridge->private == NULL. I need to think about this a bit, I don't think it should block this series though but it would be nicer. Lorenzo > +#endif > struct pci_host_bridge *bridge; > struct fwnode_handle *fwnode; > /* Protocol version negotiated with the host */ > @@ -3075,7 +3080,9 @@ static int hv_pci_probe(struct hv_device *hdev, > dom_req, dom); > > hbus->bridge->domain_nr = dom; > +#ifdef CONFIG_X86 > hbus->sysdata.domain = dom; > +#endif > > hbus->hdev = hdev; > INIT_LIST_HEAD(&hbus->children); > -- > 2.32.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel