From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C8E3C4338F for ; Tue, 3 Aug 2021 20:27:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F012560FA0 for ; Tue, 3 Aug 2021 20:27:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F012560FA0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6005C6E8D7; Tue, 3 Aug 2021 20:27:38 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 77DE76E8D7; Tue, 3 Aug 2021 20:27:36 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10065"; a="299361361" X-IronPort-AV: E=Sophos;i="5.84,292,1620716400"; d="scan'208";a="299361361" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2021 13:27:36 -0700 X-IronPort-AV: E=Sophos;i="5.84,292,1620716400"; d="scan'208";a="502540357" Received: from unerlige-ril-10.jf.intel.com (HELO unerlige-ril-10.165.21.208) ([10.165.21.208]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2021 13:27:36 -0700 Date: Tue, 3 Aug 2021 13:27:35 -0700 From: Umesh Nerlige Ramappa To: intel-gfx@lists.freedesktop.org, Lionel G Landwerlin , Ashutosh Dixit , daniel@ffwll.ch, joonas.lahtinen@linux.intel.com Cc: dri-devel@lists.freedesktop.org Subject: Re: [PATCH 0/8] Enable triggered perf query for Xe_HP Message-ID: <20210803202735.GC15814@unerlige-ril-10.165.21.208> References: <20210803201349.31031-1-umesh.nerlige.ramappa@intel.com> <20210803201838.GB15814@unerlige-ril-10.165.21.208> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20210803201838.GB15814@unerlige-ril-10.165.21.208> User-Agent: Mutt/1.12.1 (2019-06-15) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Aug 03, 2021 at 01:18:38PM -0700, Umesh Nerlige Ramappa wrote: >+ Joonas > >On Tue, Aug 03, 2021 at 01:13:41PM -0700, Umesh Nerlige Ramappa wrote: >>This is a revival of the patch series to support triggered perf query reports >>from here - https://patchwork.freedesktop.org/series/83831/ >> >>The patches were not pushed earlier because corresponding UMD changes were >>missing. This revival addresses UMD changes in GPUvis for this series. GPUvis >>uses the perf library in igt-gpu-tools. Changes to the library are here - >>https://patchwork.freedesktop.org/series/93355/ >> >>GPUvis changes will be posted as a PR once the above library and kernel changes >>are pushed. GPUvis changes: https://github.com/unerlige/gpuvis/commit/1c19c134a64564f7b8d7ca3b46449324040a40be >> >>Summary of the feature: >> >>Current platforms provide MI_REPORT_PERF_COUNT to query a snapshot of perf >>counters from a batch. This mechanism does not have consistent support on all >>engines for newer platforms. To support perf query, all new platforms use a >>mechanism to trigger OA report snapshots into the OA buffer by writing to a HW >>register from a batch. To lookup this report in the OA buffer quickly, the OA >>buffer is mmapped into the user space. >> >>This series implements the new query mechanism. >> >>Signed-off-by: Umesh Nerlige Ramappa >> >>Chris Wilson (3): >> drm/i915/gt: Refactor _wa_add to reuse wa_index and wa_list_grow >> drm/i915/gt: Check for conflicting RING_NONPRIV >> drm/i915/gt: Enable dynamic adjustment of RING_NONPRIV >> >>Piotr Maciejewski (1): >> drm/i915/perf: Ensure observation logic is not clock gated >> >>Umesh Nerlige Ramappa (4): >> drm/i915/gt: Lock intel_engine_apply_whitelist with uncore->lock >> drm/i915/perf: Whitelist OA report trigger registers >> drm/i915/perf: Whitelist OA counter and buffer registers >> drm/i915/perf: Map OA buffer to user space for gen12 performance query >> >>drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- >>drivers/gpu/drm/i915/gem/i915_gem_mman.h | 2 + >>drivers/gpu/drm/i915/gt/intel_workarounds.c | 269 +++++++++++++----- >>drivers/gpu/drm/i915/gt/intel_workarounds.h | 7 + >>.../gpu/drm/i915/gt/selftest_workarounds.c | 237 +++++++++++++++ >>drivers/gpu/drm/i915/i915_perf.c | 228 ++++++++++++++- >>drivers/gpu/drm/i915/i915_perf_types.h | 8 + >>drivers/gpu/drm/i915/i915_reg.h | 30 +- >>include/uapi/drm/i915_drm.h | 33 +++ >>9 files changed, 728 insertions(+), 88 deletions(-) >> >>-- >>2.20.1 >> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5041C432BE for ; Tue, 3 Aug 2021 20:27:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A34606052B for ; Tue, 3 Aug 2021 20:27:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A34606052B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C21016E8D9; Tue, 3 Aug 2021 20:27:38 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 77DE76E8D7; Tue, 3 Aug 2021 20:27:36 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10065"; a="299361361" X-IronPort-AV: E=Sophos;i="5.84,292,1620716400"; d="scan'208";a="299361361" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2021 13:27:36 -0700 X-IronPort-AV: E=Sophos;i="5.84,292,1620716400"; d="scan'208";a="502540357" Received: from unerlige-ril-10.jf.intel.com (HELO unerlige-ril-10.165.21.208) ([10.165.21.208]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Aug 2021 13:27:36 -0700 Date: Tue, 3 Aug 2021 13:27:35 -0700 From: Umesh Nerlige Ramappa To: intel-gfx@lists.freedesktop.org, Lionel G Landwerlin , Ashutosh Dixit , daniel@ffwll.ch, joonas.lahtinen@linux.intel.com Cc: dri-devel@lists.freedesktop.org Message-ID: <20210803202735.GC15814@unerlige-ril-10.165.21.208> References: <20210803201349.31031-1-umesh.nerlige.ramappa@intel.com> <20210803201838.GB15814@unerlige-ril-10.165.21.208> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20210803201838.GB15814@unerlige-ril-10.165.21.208> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [Intel-gfx] [PATCH 0/8] Enable triggered perf query for Xe_HP X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Aug 03, 2021 at 01:18:38PM -0700, Umesh Nerlige Ramappa wrote: >+ Joonas > >On Tue, Aug 03, 2021 at 01:13:41PM -0700, Umesh Nerlige Ramappa wrote: >>This is a revival of the patch series to support triggered perf query reports >>from here - https://patchwork.freedesktop.org/series/83831/ >> >>The patches were not pushed earlier because corresponding UMD changes were >>missing. This revival addresses UMD changes in GPUvis for this series. GPUvis >>uses the perf library in igt-gpu-tools. Changes to the library are here - >>https://patchwork.freedesktop.org/series/93355/ >> >>GPUvis changes will be posted as a PR once the above library and kernel changes >>are pushed. GPUvis changes: https://github.com/unerlige/gpuvis/commit/1c19c134a64564f7b8d7ca3b46449324040a40be >> >>Summary of the feature: >> >>Current platforms provide MI_REPORT_PERF_COUNT to query a snapshot of perf >>counters from a batch. This mechanism does not have consistent support on all >>engines for newer platforms. To support perf query, all new platforms use a >>mechanism to trigger OA report snapshots into the OA buffer by writing to a HW >>register from a batch. To lookup this report in the OA buffer quickly, the OA >>buffer is mmapped into the user space. >> >>This series implements the new query mechanism. >> >>Signed-off-by: Umesh Nerlige Ramappa >> >>Chris Wilson (3): >> drm/i915/gt: Refactor _wa_add to reuse wa_index and wa_list_grow >> drm/i915/gt: Check for conflicting RING_NONPRIV >> drm/i915/gt: Enable dynamic adjustment of RING_NONPRIV >> >>Piotr Maciejewski (1): >> drm/i915/perf: Ensure observation logic is not clock gated >> >>Umesh Nerlige Ramappa (4): >> drm/i915/gt: Lock intel_engine_apply_whitelist with uncore->lock >> drm/i915/perf: Whitelist OA report trigger registers >> drm/i915/perf: Whitelist OA counter and buffer registers >> drm/i915/perf: Map OA buffer to user space for gen12 performance query >> >>drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- >>drivers/gpu/drm/i915/gem/i915_gem_mman.h | 2 + >>drivers/gpu/drm/i915/gt/intel_workarounds.c | 269 +++++++++++++----- >>drivers/gpu/drm/i915/gt/intel_workarounds.h | 7 + >>.../gpu/drm/i915/gt/selftest_workarounds.c | 237 +++++++++++++++ >>drivers/gpu/drm/i915/i915_perf.c | 228 ++++++++++++++- >>drivers/gpu/drm/i915/i915_perf_types.h | 8 + >>drivers/gpu/drm/i915/i915_reg.h | 30 +- >>include/uapi/drm/i915_drm.h | 33 +++ >>9 files changed, 728 insertions(+), 88 deletions(-) >> >>-- >>2.20.1 >>