From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E13DC432BE for ; Wed, 4 Aug 2021 01:07:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1052460F58 for ; Wed, 4 Aug 2021 01:07:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232333AbhHDBHV (ORCPT ); Tue, 3 Aug 2021 21:07:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:59536 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230083AbhHDBHU (ORCPT ); Tue, 3 Aug 2021 21:07:20 -0400 Received: from rorschach.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7254E60EE9; Wed, 4 Aug 2021 01:07:07 +0000 (UTC) Date: Tue, 3 Aug 2021 21:07:05 -0400 From: Steven Rostedt To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, Peter Zijlstra , Ingo Molnar , Karol Herbst , Pekka Paalanen , Dave Hansen , Andy Lutomirski , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , nouveau@lists.freedesktop.org Subject: Re: [PATCH 06/38] x86/mmiotrace: Replace deprecated CPU-hotplug functions. Message-ID: <20210803210705.2fdc9d1a@rorschach.local.home> In-Reply-To: <20210803141621.780504-7-bigeasy@linutronix.de> References: <20210803141621.780504-1-bigeasy@linutronix.de> <20210803141621.780504-7-bigeasy@linutronix.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Aug 2021 16:15:49 +0200 Sebastian Andrzej Siewior wrote: > The functions get_online_cpus() and put_online_cpus() have been > deprecated during the CPU hotplug rework. They map directly to > cpus_read_lock() and cpus_read_unlock(). > > Replace deprecated CPU-hotplug functions with the official version. > The behavior remains unchanged. > > Cc: Steven Rostedt Reviewed-by: Steven Rostedt (VMware) -- Steve > Cc: Ingo Molnar > Cc: Karol Herbst > Cc: Pekka Paalanen > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Borislav Petkov > Cc: x86@kernel.org > Cc: "H. Peter Anvin" > Cc: nouveau@lists.freedesktop.org > Signed-off-by: Sebastian Andrzej Siewior > --- > arch/x86/mm/mmio-mod.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/mm/mmio-mod.c b/arch/x86/mm/mmio-mod.c > index cd768dafca9e9..933a2ebad471b 100644 > --- a/arch/x86/mm/mmio-mod.c > +++ b/arch/x86/mm/mmio-mod.c > @@ -376,12 +376,12 @@ static void enter_uniprocessor(void) > goto out; > } > > - get_online_cpus(); > + cpus_read_lock(); > cpumask_copy(downed_cpus, cpu_online_mask); > cpumask_clear_cpu(cpumask_first(cpu_online_mask), downed_cpus); > if (num_online_cpus() > 1) > pr_notice("Disabling non-boot CPUs...\n"); > - put_online_cpus(); > + cpus_read_unlock(); > > for_each_cpu(cpu, downed_cpus) { > err = remove_cpu(cpu); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7CBAC4338F for ; Wed, 4 Aug 2021 01:07:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 73B4860F8F for ; Wed, 4 Aug 2021 01:07:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 73B4860F8F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EBEE46E9A4; Wed, 4 Aug 2021 01:07:32 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id 631B96E9A4 for ; Wed, 4 Aug 2021 01:07:08 +0000 (UTC) Received: from rorschach.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7254E60EE9; Wed, 4 Aug 2021 01:07:07 +0000 (UTC) Date: Tue, 3 Aug 2021 21:07:05 -0400 From: Steven Rostedt To: Sebastian Andrzej Siewior Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, Peter Zijlstra , Ingo Molnar , Karol Herbst , Pekka Paalanen , Dave Hansen , Andy Lutomirski , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , nouveau@lists.freedesktop.org Message-ID: <20210803210705.2fdc9d1a@rorschach.local.home> In-Reply-To: <20210803141621.780504-7-bigeasy@linutronix.de> References: <20210803141621.780504-1-bigeasy@linutronix.de> <20210803141621.780504-7-bigeasy@linutronix.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Nouveau] [PATCH 06/38] x86/mmiotrace: Replace deprecated CPU-hotplug functions. X-BeenThere: nouveau@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Nouveau development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces@lists.freedesktop.org Sender: "Nouveau" On Tue, 3 Aug 2021 16:15:49 +0200 Sebastian Andrzej Siewior wrote: > The functions get_online_cpus() and put_online_cpus() have been > deprecated during the CPU hotplug rework. They map directly to > cpus_read_lock() and cpus_read_unlock(). > > Replace deprecated CPU-hotplug functions with the official version. > The behavior remains unchanged. > > Cc: Steven Rostedt Reviewed-by: Steven Rostedt (VMware) -- Steve > Cc: Ingo Molnar > Cc: Karol Herbst > Cc: Pekka Paalanen > Cc: Dave Hansen > Cc: Andy Lutomirski > Cc: Peter Zijlstra > Cc: Thomas Gleixner > Cc: Borislav Petkov > Cc: x86@kernel.org > Cc: "H. Peter Anvin" > Cc: nouveau@lists.freedesktop.org > Signed-off-by: Sebastian Andrzej Siewior > --- > arch/x86/mm/mmio-mod.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/mm/mmio-mod.c b/arch/x86/mm/mmio-mod.c > index cd768dafca9e9..933a2ebad471b 100644 > --- a/arch/x86/mm/mmio-mod.c > +++ b/arch/x86/mm/mmio-mod.c > @@ -376,12 +376,12 @@ static void enter_uniprocessor(void) > goto out; > } > > - get_online_cpus(); > + cpus_read_lock(); > cpumask_copy(downed_cpus, cpu_online_mask); > cpumask_clear_cpu(cpumask_first(cpu_online_mask), downed_cpus); > if (num_online_cpus() > 1) > pr_notice("Disabling non-boot CPUs...\n"); > - put_online_cpus(); > + cpus_read_unlock(); > > for_each_cpu(cpu, downed_cpus) { > err = remove_cpu(cpu);