From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA0E3C432BE for ; Tue, 3 Aug 2021 23:43:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CB9376103C for ; Tue, 3 Aug 2021 23:43:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233335AbhHCXoC (ORCPT ); Tue, 3 Aug 2021 19:44:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:43320 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231651AbhHCXoC (ORCPT ); Tue, 3 Aug 2021 19:44:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5E8D661050; Tue, 3 Aug 2021 23:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628034230; bh=Qb7Rl5sT8Cpn/3OI3WdXxenXNQaZtsNhc5PZYQ5I6So=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=sBD9WALtt+KuOJQP1ABGJDlV91ylu8p5qdRYvIcinu4n/iQEQa6DF1Y/pJJKGcSHA FSfuLXslIAD+Yv/kQZdc9g3p/wRIe+5lzjSJypunWGSaj7vTBx/YPDdAMj3Hc2HdIM sKiAUz4qJDoO25JrqrdmeGgm/P1z3G0cMzQ6iZ+GwhbabhbJ6sJUZAIVBghiYe920U TnpWWFgzWr+3MFV1yMsILmmU/QBShU1m+e1IWR65r1oYb/WKF4Yxpt/cyLRNGjTM/r 70HuKQpjEw+HvosIAT8xdzgmwKEid0g3Upd7XNbGsXJwB2EYrx1oY9LtjFCDL2OJZH o59pMBWJ4vcKg== Date: Tue, 3 Aug 2021 18:43:49 -0500 From: Bjorn Helgaas To: Rob Herring Cc: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , linux-pci@vger.kernel.org, Srinath Mannam , Roman Bacik , Bharat Gooty , Abhishek Shah , Jitendra Bhivare , Ray Jui , Florian Fainelli , BCM Kernel Feedback , Scott Branden , Bjorn Helgaas , Lorenzo Pieralisi Subject: Re: [PATCH 1/2] PCI: of: Don't fail devm_pci_alloc_host_bridge() on missing 'ranges' Message-ID: <20210803234349.GA1587308@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210803215656.3803204-1-robh@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Tue, Aug 03, 2021 at 03:56:55PM -0600, Rob Herring wrote: > Commit 669cbc708122 ("PCI: Move DT resource setup into > devm_pci_alloc_host_bridge()") made devm_pci_alloc_host_bridge() fail on > any DT resource parsing errors, but Broadcom iProc uses > devm_pci_alloc_host_bridge() on BCMA bus devices that don't have DT > resources. In particular, there is no 'ranges' property. Fix iProc by > making 'ranges' optional. > > If 'ranges' is required by a platform, there's going to be more errors > latter on if it is missing. s/latter/later/ > Fixes: 669cbc708122 ("PCI: Move DT resource setup into devm_pci_alloc_host_bridge()") > Reported-by: Rafał Miłecki > Cc: Srinath Mannam > Cc: Roman Bacik > Cc: Bharat Gooty > Cc: Abhishek Shah > Cc: Jitendra Bhivare > Cc: Ray Jui > Cc: Florian Fainelli > Cc: BCM Kernel Feedback > Cc: Scott Branden > Cc: Bjorn Helgaas > Cc: Lorenzo Pieralisi > Signed-off-by: Rob Herring Acked-by: Bjorn Helgaas I assume Lorenzo will merge this along with the iproc change. > --- > drivers/pci/of.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/of.c b/drivers/pci/of.c > index a143b02b2dcd..d84381ce82b5 100644 > --- a/drivers/pci/of.c > +++ b/drivers/pci/of.c > @@ -310,7 +310,7 @@ static int devm_of_pci_get_host_bridge_resources(struct device *dev, > /* Check for ranges property */ > err = of_pci_range_parser_init(&parser, dev_node); > if (err) > - goto failed; > + return 0; > > dev_dbg(dev, "Parsing ranges property...\n"); > for_each_of_pci_range(&parser, &range) { > -- > 2.30.2 >