Re: [PATCH V4 1/2] gpio: Add virtio-gpio driver

[Viresh Kumar <viresh.kumar@linaro.org>]

[-- Attachment #1: Type: text/plain, Size: 2117 bytes --]

On 04-08-21, 08:14, kernel test robot wrote:
> Hi Viresh,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on soc/for-next]
> [also build test ERROR on vhost/linux-next linus/master v5.14-rc4 next-20210803]
> [cannot apply to gpio/for-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
> 
> url:    https://github.com/0day-ci/linux/commits/Viresh-Kumar/gpio-Add-virtio-based-driver/20210803-193849
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/soc/soc.git for-next
> config: m68k-allmodconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 10.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/0day-ci/linux/commit/8b6c2762f57f02c16d12f45019dbeed57c9bc6d5
>         git remote add linux-review https://github.com/0day-ci/linux
>         git fetch --no-tags linux-review Viresh-Kumar/gpio-Add-virtio-based-driver/20210803-193849
>         git checkout 8b6c2762f57f02c16d12f45019dbeed57c9bc6d5
>         # save the attached .config to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=m68k SHELL=/bin/bash drivers/gpio/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/gpio/gpio-virtio.c:356:4: error: 'VIRTIO_ID_GPIO' undeclared here (not in a function); did you mean 'VIRTIO_ID_GPU'?
>      356 |  { VIRTIO_ID_GPIO, VIRTIO_DEV_ANY_ID },
>          |    ^~~~~~~~~~~~~~
>          |    VIRTIO_ID_GPU
> 
> 
> vim +356 drivers/gpio/gpio-virtio.c

I forgot to mention a dependency :(

https://lore.kernel.org/lkml/61b27e3bc61fb0c9f067001e95cfafc5d37d414a.1627362340.git.viresh.kumar(a)linaro.org/

-- 
viresh