Re: [RFC bpf-next 3/5] igc: Launchtime support in XDP Tx ZC path

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5139 bytes --]

Hi Kishen,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Kishen-Maloor/SO_TXTIME-support-in-AF_XDP/20210804-011214
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: i386-randconfig-a011-20210803 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/a631a80055e4e1c72563d33445336f091c7053e3
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Kishen-Maloor/SO_TXTIME-support-in-AF_XDP/20210804-011214
        git checkout a631a80055e4e1c72563d33445336f091c7053e3
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/intel/igc/igc_main.c: In function 'igc_xdp_xmit_zc':
   drivers/net/ethernet/intel/igc/igc_main.c:2639:54: error: 'XDP_DESC_OPTION_SO_TXTIME' undeclared (first use in this function); did you mean 'XDP_DESC_OPTION_METADATA'?
    2639 |   if (ring->launchtime_enable && (xdp_desc.options & XDP_DESC_OPTION_SO_TXTIME)) {
         |                                                      ^~~~~~~~~~~~~~~~~~~~~~~~~
         |                                                      XDP_DESC_OPTION_METADATA
   drivers/net/ethernet/intel/igc/igc_main.c:2639:54: note: each undeclared identifier is reported only once for each function it appears in
>> drivers/net/ethernet/intel/igc/igc_main.c:2640:42: warning: passing argument 2 of 'xsk_buff_get_txtime' makes integer from pointer without a cast [-Wint-conversion]
    2640 |    launch_tm = xsk_buff_get_txtime(pool, &xdp_desc);
         |                                          ^~~~~~~~~
         |                                          |
         |                                          struct xdp_desc *
   In file included from drivers/net/ethernet/intel/igc/igc_main.c:14:
   include/net/xdp_sock_drv.h:240:71: note: expected 'u64' {aka 'long long unsigned int'} but argument is of type 'struct xdp_desc *'
     240 | static inline s64 xsk_buff_get_txtime(struct xsk_buff_pool *pool, u64 addr)
         |                                                                   ~~~~^~~~


vim +/xsk_buff_get_txtime +2640 drivers/net/ethernet/intel/igc/igc_main.c

  2613	
  2614	static void igc_xdp_xmit_zc(struct igc_ring *ring)
  2615	{
  2616		struct xsk_buff_pool *pool = ring->xsk_pool;
  2617		struct netdev_queue *nq = txring_txq(ring);
  2618		union igc_adv_tx_desc *tx_desc = NULL;
  2619		int cpu = smp_processor_id();
  2620		u16 ntu = ring->next_to_use;
  2621		struct xdp_desc xdp_desc;
  2622		u16 budget;
  2623	
  2624		if (!netif_carrier_ok(ring->netdev))
  2625			return;
  2626	
  2627		__netif_tx_lock(nq, cpu);
  2628	
  2629		budget = igc_desc_unused(ring);
  2630	
  2631		while (xsk_tx_peek_desc(pool, &xdp_desc) && budget > 2) {
  2632			u32 cmd_type, olinfo_status;
  2633			struct igc_tx_buffer *bi;
  2634			s64 launch_tm = 0;
  2635			dma_addr_t dma;
  2636	
  2637			bi = &ring->tx_buffer_info[ring->next_to_use];
  2638	
> 2639			if (ring->launchtime_enable && (xdp_desc.options & XDP_DESC_OPTION_SO_TXTIME)) {
> 2640				launch_tm = xsk_buff_get_txtime(pool, &xdp_desc);
  2641				if (launch_tm != -1) {
  2642					budget--;
  2643					igc_launchtm_ctxtdesc(ring, (ktime_t)launch_tm);
  2644				}
  2645			}
  2646	
  2647			/* re-read ntu as igc_launchtm_ctxtdesc() updates it */
  2648			ntu = ring->next_to_use;
  2649	
  2650			cmd_type = IGC_ADVTXD_DTYP_DATA | IGC_ADVTXD_DCMD_DEXT |
  2651				   IGC_ADVTXD_DCMD_IFCS | IGC_TXD_DCMD |
  2652				   xdp_desc.len;
  2653			olinfo_status = xdp_desc.len << IGC_ADVTXD_PAYLEN_SHIFT;
  2654	
  2655			dma = xsk_buff_raw_get_dma(pool, xdp_desc.addr);
  2656			xsk_buff_raw_dma_sync_for_device(pool, dma, xdp_desc.len);
  2657	
  2658			budget--;
  2659			tx_desc = IGC_TX_DESC(ring, ntu);
  2660			tx_desc->read.cmd_type_len = cpu_to_le32(cmd_type);
  2661			tx_desc->read.olinfo_status = cpu_to_le32(olinfo_status);
  2662			tx_desc->read.buffer_addr = cpu_to_le64(dma);
  2663	
  2664			bi->type = IGC_TX_BUFFER_TYPE_XSK;
  2665			bi->protocol = 0;
  2666			bi->bytecount = xdp_desc.len;
  2667			bi->gso_segs = 1;
  2668			bi->time_stamp = jiffies;
  2669			bi->next_to_watch = tx_desc;
  2670	
  2671			netdev_tx_sent_queue(txring_txq(ring), xdp_desc.len);
  2672	
  2673			ntu++;
  2674			if (ntu == ring->count)
  2675				ntu = 0;
  2676			ring->next_to_use = ntu;
  2677		}
  2678	
  2679		if (tx_desc) {
  2680			igc_flush_tx_descriptors(ring);
  2681			xsk_tx_release(pool);
  2682		}
  2683	
  2684		__netif_tx_unlock(nq);
  2685	}
  2686	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41843 bytes --]