From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09262C432BE for ; Wed, 4 Aug 2021 07:24:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA28360F38 for ; Wed, 4 Aug 2021 07:24:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235850AbhHDHYZ (ORCPT ); Wed, 4 Aug 2021 03:24:25 -0400 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:43382 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235841AbhHDHYY (ORCPT ); Wed, 4 Aug 2021 03:24:24 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=jefflexu@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0UhwmYqy_1628061851; Received: from localhost(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0UhwmYqy_1628061851) by smtp.aliyun-inc.com(127.0.0.1); Wed, 04 Aug 2021 15:24:11 +0800 From: Jeffle Xu To: vgoyal@redhat.com, stefanha@redhat.com, miklos@szeredi.hu Cc: linux-fsdevel@vger.kernel.org, virtualization@lists.linux-foundation.org, virtio-fs@redhat.com, joseph.qi@linux.alibaba.com, bo.liu@linux.alibaba.com Subject: [PATCH virtiofsd 0/3] virtiofsd: support per-file DAX Date: Wed, 4 Aug 2021 15:24:08 +0800 Message-Id: <20210804072411.1180-1-jefflexu@linux.alibaba.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210804070653.118123-1-jefflexu@linux.alibaba.com> References: <20210804070653.118123-1-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org As discussed with Vivek Goyal, I tried to make virtiofsd support per-file DAX by checking if the file is marked with FS_DAX_FL attr. Thus I need to implement .ioctl() method for passthrough_ll.c (because FS_DAX_FL attr is get/set by FS_IOC_GETFLAGS/FS_IOC_SETFLAGS ioctl), something like ``` static struct fuse_lowlevel_ops lo_oper = { + .ioctl = lo_ioctl, +static void lo_ioctl(...) +{ + ret = ioctl(fd, FS_IOC_SETFLAGS, ...); } ``` But unfortunately once virtiofsd calls ioctl() syscall, it directly exits, and qemu also hangs with 'qemu-system-x86_64: Unexpected end-of-file before all data were read'. I'm not sure if it's because ioctl() is not permitted at all for virtiofsd or qemu. Many thanks if someone familiar with virtualization could help. The code repository of virtiofsd used is: gitlab.com/virtio-fs/qemu.git virtio-fs-dev Thus this patch set is still used for test only, marking files larger than 1MB shall enable per-file DAX. Jeffle Xu (3): virtiofsd: expand fuse protocol to support per-file DAX virtiofsd: support per-file DAX negotiation in FUSE_INIT virtiofsd: support per-file DAX in FUSE_LOOKUP include/standard-headers/linux/fuse.h | 2 ++ tools/virtiofsd/fuse_common.h | 5 +++++ tools/virtiofsd/fuse_lowlevel.c | 6 ++++++ tools/virtiofsd/passthrough_ll.c | 6 ++++++ 4 files changed, 19 insertions(+) -- 2.27.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCAF0C4338F for ; Wed, 4 Aug 2021 07:24:18 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 645F4604DB for ; Wed, 4 Aug 2021 07:24:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 645F4604DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 1EC53819D2; Wed, 4 Aug 2021 07:24:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DXPEj1vm99YE; Wed, 4 Aug 2021 07:24:17 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 9490281516; Wed, 4 Aug 2021 07:24:16 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6326EC001A; Wed, 4 Aug 2021 07:24:16 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4F8C4C000E for ; Wed, 4 Aug 2021 07:24:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 496026061C for ; Wed, 4 Aug 2021 07:24:15 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OfPAUM2k-UbQ for ; Wed, 4 Aug 2021 07:24:14 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from out30-54.freemail.mail.aliyun.com (out30-54.freemail.mail.aliyun.com [115.124.30.54]) by smtp3.osuosl.org (Postfix) with ESMTPS id 48E396058D for ; Wed, 4 Aug 2021 07:24:14 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS; BC=-1|-1; BR=01201311R191e4; CH=green; DM=||false|; DS=||; FP=0|-1|-1|-1|0|-1|-1|-1; HT=e01e04400; MF=jefflexu@linux.alibaba.com; NM=1; PH=DS; RN=8; SR=0; TI=SMTPD_---0UhwmYqy_1628061851; Received: from localhost(mailfrom:jefflexu@linux.alibaba.com fp:SMTPD_---0UhwmYqy_1628061851) by smtp.aliyun-inc.com(127.0.0.1); Wed, 04 Aug 2021 15:24:11 +0800 From: Jeffle Xu To: vgoyal@redhat.com, stefanha@redhat.com, miklos@szeredi.hu Subject: [PATCH virtiofsd 0/3] virtiofsd: support per-file DAX Date: Wed, 4 Aug 2021 15:24:08 +0800 Message-Id: <20210804072411.1180-1-jefflexu@linux.alibaba.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210804070653.118123-1-jefflexu@linux.alibaba.com> References: <20210804070653.118123-1-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Cc: linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com, bo.liu@linux.alibaba.com, joseph.qi@linux.alibaba.com, virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" As discussed with Vivek Goyal, I tried to make virtiofsd support per-file DAX by checking if the file is marked with FS_DAX_FL attr. Thus I need to implement .ioctl() method for passthrough_ll.c (because FS_DAX_FL attr is get/set by FS_IOC_GETFLAGS/FS_IOC_SETFLAGS ioctl), something like ``` static struct fuse_lowlevel_ops lo_oper = { + .ioctl = lo_ioctl, +static void lo_ioctl(...) +{ + ret = ioctl(fd, FS_IOC_SETFLAGS, ...); } ``` But unfortunately once virtiofsd calls ioctl() syscall, it directly exits, and qemu also hangs with 'qemu-system-x86_64: Unexpected end-of-file before all data were read'. I'm not sure if it's because ioctl() is not permitted at all for virtiofsd or qemu. Many thanks if someone familiar with virtualization could help. The code repository of virtiofsd used is: gitlab.com/virtio-fs/qemu.git virtio-fs-dev Thus this patch set is still used for test only, marking files larger than 1MB shall enable per-file DAX. Jeffle Xu (3): virtiofsd: expand fuse protocol to support per-file DAX virtiofsd: support per-file DAX negotiation in FUSE_INIT virtiofsd: support per-file DAX in FUSE_LOOKUP include/standard-headers/linux/fuse.h | 2 ++ tools/virtiofsd/fuse_common.h | 5 +++++ tools/virtiofsd/fuse_lowlevel.c | 6 ++++++ tools/virtiofsd/passthrough_ll.c | 6 ++++++ 4 files changed, 19 insertions(+) -- 2.27.0 _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeffle Xu Date: Wed, 4 Aug 2021 15:24:08 +0800 Message-Id: <20210804072411.1180-1-jefflexu@linux.alibaba.com> In-Reply-To: <20210804070653.118123-1-jefflexu@linux.alibaba.com> References: <20210804070653.118123-1-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [Virtio-fs] [PATCH virtiofsd 0/3] virtiofsd: support per-file DAX List-Id: Development discussions about virtio-fs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: vgoyal@redhat.com, stefanha@redhat.com, miklos@szeredi.hu Cc: linux-fsdevel@vger.kernel.org, virtio-fs@redhat.com, joseph.qi@linux.alibaba.com, virtualization@lists.linux-foundation.org As discussed with Vivek Goyal, I tried to make virtiofsd support per-file DAX by checking if the file is marked with FS_DAX_FL attr. Thus I need to implement .ioctl() method for passthrough_ll.c (because FS_DAX_FL attr is get/set by FS_IOC_GETFLAGS/FS_IOC_SETFLAGS ioctl), something like ``` static struct fuse_lowlevel_ops lo_oper = { + .ioctl = lo_ioctl, +static void lo_ioctl(...) +{ + ret = ioctl(fd, FS_IOC_SETFLAGS, ...); } ``` But unfortunately once virtiofsd calls ioctl() syscall, it directly exits, and qemu also hangs with 'qemu-system-x86_64: Unexpected end-of-file before all data were read'. I'm not sure if it's because ioctl() is not permitted at all for virtiofsd or qemu. Many thanks if someone familiar with virtualization could help. The code repository of virtiofsd used is: gitlab.com/virtio-fs/qemu.git virtio-fs-dev Thus this patch set is still used for test only, marking files larger than 1MB shall enable per-file DAX. Jeffle Xu (3): virtiofsd: expand fuse protocol to support per-file DAX virtiofsd: support per-file DAX negotiation in FUSE_INIT virtiofsd: support per-file DAX in FUSE_LOOKUP include/standard-headers/linux/fuse.h | 2 ++ tools/virtiofsd/fuse_common.h | 5 +++++ tools/virtiofsd/fuse_lowlevel.c | 6 ++++++ tools/virtiofsd/passthrough_ll.c | 6 ++++++ 4 files changed, 19 insertions(+) -- 2.27.0