From: Jan Kara <jack@suse.cz>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/9] quota: Do not account space used by project quota file to quota
Date: Wed, 4 Aug 2021 14:15:53 +0200 [thread overview]
Message-ID: <20210804121553.GC4578@quack2.suse.cz> (raw)
In-Reply-To: <YQlrGbFgxf8BYruB@mit.edu>
On Tue 03-08-21 12:13:13, Theodore Ts'o wrote:
> On Wed, Jun 16, 2021 at 12:57:28PM +0200, Jan Kara wrote:
> > Project quota files have high inode numbers but are not accounted in
> > quota usage. Do not track them when computing quota usage.
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
>
> Thanks, applied to the maint branch (since this is a bug fix unrelated
> to the orhpan inode feature).
>
> It looks like this was an issue that wasn't picked up by our
> regression tests. Do you have an sample image that you used while you
> were developing this patch, that perhaps we should be adding to our
> regression test suite?
So I've uncovered this just by code inspection when adding orphan file
feature. Checking this problem is not as simple as using a fs image (the
problem manifests only if we add new quota type using tune2fs). I've
created a test for it. I'll post it separately.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2021-08-04 12:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 10:57 [PATCH 0/9 v3] e2fsprogs: Support for orphan file feature Jan Kara
2021-06-16 10:57 ` [PATCH 1/9] ext2fs: Drop HAS_SNAPSHOT feature Jan Kara
2021-06-16 10:57 ` [PATCH 2/9] quota: Do not account space used by project quota file to quota Jan Kara
2021-08-03 16:13 ` Theodore Ts'o
2021-08-04 12:15 ` Jan Kara [this message]
2021-06-16 10:57 ` [PATCH 3/9] e2image: Dump quota files Jan Kara
2021-08-03 16:15 ` Theodore Ts'o
2021-06-16 10:57 ` [PATCH 4/9] libext2fs: Support for orphan file feature Jan Kara
2021-08-03 17:36 ` Theodore Ts'o
2021-08-03 17:57 ` Theodore Ts'o
2021-06-16 10:57 ` [PATCH 5/9] mke2fs: Add support for orphan_file feature Jan Kara
2021-06-16 10:57 ` [PATCH 6/9] e2fsck: Add support for handling orphan file Jan Kara
2021-06-16 10:57 ` [PATCH 7/9] tune2fs: Add support for orphan_file feature Jan Kara
2021-06-16 10:57 ` [PATCH 8/9] mke2fs: Add orphan_file feature into mke2fs.conf Jan Kara
2021-06-16 10:57 ` [PATCH 9/9] dumpe2fs, debugfs, e2image: Add support for orphan file Jan Kara
2021-07-12 15:43 [PATCH 0/9 v4] e2fsprogs: Support for orphan file feature Jan Kara
2021-07-12 15:43 ` [PATCH 2/9] quota: Do not account space used by project quota file to quota Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804121553.GC4578@quack2.suse.cz \
--to=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.