All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Martin Kaiser <martin@kaiser.cx>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Larry Finger <Larry.Finger@lwfinger.net>,
	Phillip Potter <phil@philpotter.co.uk>,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove RT_TRACE and DBG_88E prints from ioctl_linux.c
Date: Wed, 4 Aug 2021 16:12:15 +0300	[thread overview]
Message-ID: <20210804131214.GK1931@kadam> (raw)
In-Reply-To: <20210802073917.8647-1-martin@kaiser.cx>

On Mon, Aug 02, 2021 at 09:39:17AM +0200, Martin Kaiser wrote:
> @@ -4203,7 +3940,6 @@ static int rtw_dbg_port(struct net_device *dev,
>  			u16 start_value = 0;
>  			u32 write_num = extra_arg;
>  			int i;
> -			u8 final;
>  			struct xmit_frame	*xmit_frame;
>  
>  			xmit_frame = rtw_IOL_accquire_xmit_frame(padapter);
> @@ -4216,12 +3952,6 @@ static int rtw_dbg_port(struct net_device *dev,
>  				rtw_IOL_append_WB_cmd(xmit_frame, reg, i+start_value, 0xFF);
>  			if (_SUCCESS != rtw_IOL_exec_cmds_sync(padapter, xmit_frame, 5000, 0))
>  				ret = -EPERM;
> -
> -			final = rtw_read8(padapter, reg);
> -			if (start_value+write_num-1 == final)
> -				DBG_88E("continuous IOL_CMD_WB_REG to 0x%x %u times Success, start:%u, final:%u\n", reg, write_num, start_value, final);
> -			else
> -				DBG_88E("continuous IOL_CMD_WB_REG to 0x%x %u times Fail, start:%u, final:%u\n", reg, write_num, start_value, final);
>  		}

I don't have a problem with the patch but these tests don't make any
sense now that we don't print a Success/Fail at the end.  (We should
probably delete the whole function and all the related code)

regards,
dan carpenter


  reply	other threads:[~2021-08-04 13:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-02  7:39 [PATCH] staging: r8188eu: remove RT_TRACE and DBG_88E prints from ioctl_linux.c Martin Kaiser
2021-08-04 13:12 ` Dan Carpenter [this message]
2021-08-04 14:21   ` Martin Kaiser
2021-08-04 14:19 ` [PATCH v2] " Martin Kaiser
2021-08-05 11:08   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210804131214.GK1931@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=martin@kaiser.cx \
    --cc=phil@philpotter.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.