* [PATCH] scsi: mpt3sas: Fix incorrectly assigned error return and check
@ 2021-08-04 13:49 Colin King
2021-08-10 5:16 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-08-04 13:49 UTC (permalink / raw)
To: Sathya Prakash, Sreekanth Reddy, Suganath Prabu Subramani,
James E . J . Bottomley, Martin K . Petersen,
MPT-FusionLinux.pdl, linux-scsi
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently the call to _base_static_config_pages is assigning the error
return to variable rc but checking the error return in error r. Fix this
by assigning the error return to variable r instread of rc.
Addresses-Coverity: ("Unused value")
Fixes: 19a622c39a9d ("scsi: mpt3sas: Handle firmware faults during first half of IOC init")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index 19b1c0cf5f2a..cf4a3a2c22ad 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -7851,7 +7851,7 @@ _base_make_ioc_operational(struct MPT3SAS_ADAPTER *ioc)
return r;
}
- rc = _base_static_config_pages(ioc);
+ r = _base_static_config_pages(ioc);
if (r)
return r;
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] scsi: mpt3sas: Fix incorrectly assigned error return and check
2021-08-04 13:49 [PATCH] scsi: mpt3sas: Fix incorrectly assigned error return and check Colin King
@ 2021-08-10 5:16 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2021-08-10 5:16 UTC (permalink / raw)
To: James E . J . Bottomley, Colin King, linux-scsi,
Suganath Prabu Subramani, Sathya Prakash, Sreekanth Reddy,
MPT-FusionLinux.pdl
Cc: Martin K . Petersen, kernel-janitors, linux-kernel
On Wed, 4 Aug 2021 14:49:40 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently the call to _base_static_config_pages is assigning the error
> return to variable rc but checking the error return in error r. Fix this
> by assigning the error return to variable r instread of rc.
>
>
> [...]
Applied to 5.14/scsi-fixes, thanks!
[1/1] scsi: mpt3sas: Fix incorrectly assigned error return and check
https://git.kernel.org/mkp/scsi/c/40d32727931c
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-10 5:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-04 13:49 [PATCH] scsi: mpt3sas: Fix incorrectly assigned error return and check Colin King
2021-08-10 5:16 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.