From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB63C4320A for ; Wed, 4 Aug 2021 14:40:54 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C373361002 for ; Wed, 4 Aug 2021 14:40:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C373361002 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id CFE5282E1E; Wed, 4 Aug 2021 16:40:51 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="t+tKcpGq"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8D33482F03; Wed, 4 Aug 2021 16:40:49 +0200 (CEST) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 584A382E1E for ; Wed, 4 Aug 2021 16:40:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x732.google.com with SMTP id c9so2891320qkc.13 for ; Wed, 04 Aug 2021 07:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UC5xgSS//kIzaYprFj+pZnK/wk5NrTcxVv6xiTkHlSE=; b=t+tKcpGqbmNI6UyPj/qMFaBUZhOohjwaT2+CnFaMUW1R770f/bdbtWgZ01BWsZ3nFy ho50yLX6TpzsPXa/ZdgQ9bxnTfbaV8PoJYlTCE3TQwQpiTdnY5DEVySJYeSQMNh6+QE1 7gBymffnwwazAFOcD64vTgGt3kXmGMd19mmiA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UC5xgSS//kIzaYprFj+pZnK/wk5NrTcxVv6xiTkHlSE=; b=NMC/SVCIi6Oe8YHp5OKol7147BUo3v5Doo+F9wwlTJeGiK0GMVmy6e/3iOz1wqSAKO ubkuhCrU4/YpHTAmPeYcFJST1iWE17lvnTrDhiDAkN+ck0I+0Vm1hgu+IQt4wmbniW3z bK+MA/Ew25tFj1kfcBVr5mpSoHLArLWOIEANg8tvl86eouZp6ZMd6RovIb/Jb0iG+DVQ T4M6eHsD46vshzSIzb7ae0nxw+V8EZ9xtb0//yz9GS2jqLo+ZlMeZgultrK8ilnpikd+ SlD4ac/aHY6Vh4LSAdM2O5TSMCcwtmYPhVM8nB/FP1NGf2+iXRzsigFxcymKIRG026iK FPzA== X-Gm-Message-State: AOAM533kRTj3GLXjuPymFNeWovLVkI7MaxLlj4OsyCTFdj++1pSOv5EY z+efwDRMVcjenmURt3GCLzE3Tg== X-Google-Smtp-Source: ABdhPJwCEaIr5GnH7ZsvRe55oQIoboOobYqvVwb9IQauhHa4wDKfF8U/yn1Fu5ZvIYlrDEQf2in97Q== X-Received: by 2002:a05:620a:2408:: with SMTP id d8mr26294185qkn.233.1628088044998; Wed, 04 Aug 2021 07:40:44 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-f4c0-9925-e569-04c6.res6.spectrum.com. [2603:6081:7b01:cbda:f4c0:9925:e569:4c6]) by smtp.gmail.com with ESMTPSA id g4sm1316991qkk.104.2021.08.04.07.40.43 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Aug 2021 07:40:44 -0700 (PDT) Date: Wed, 4 Aug 2021 10:40:42 -0400 From: Tom Rini To: Simon Glass Cc: Wolfgang Denk , Pali =?iso-8859-1?Q?Roh=E1r?= , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?iso-8859-1?Q?Beh=FAn?= , U-Boot Mailing List Subject: Re: [PATCH 11/11] Remove including timestamp.h in version.h Message-ID: <20210804144042.GA9379@bill-the-cat> References: <20210802131838.21097-1-pali@kernel.org> <20210802131838.21097-12-pali@kernel.org> <20210802194223.5myvz6l27rjkfrld@pali> <20210802213100.GG9379@bill-the-cat> <128122.1628056761@gemini.denx.de> <20210804124413.GZ9379@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="BUCxE1jZmpnH0wI5" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --BUCxE1jZmpnH0wI5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 04, 2021 at 08:36:27AM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Wed, 4 Aug 2021 at 06:44, Tom Rini wrote: > > > > On Wed, Aug 04, 2021 at 07:59:21AM +0200, Wolfgang Denk wrote: > > > > > Dear Tom, > > > > > > In message <20210802213100.GG9379@bill-the-cat> you wrote: > > > > > > > > I think that if nothing changes the banner not changing is the right > > > > behavior. > > > > > > Hm... is it? How about "external" changes like building with a > > > different tool chain? Then at least the "version" command should > > > produce a corresponding output, which means some parts _have_ to be > > > recompiled, resulting in a new banner, too ? > > > > There's some misunderstanding about what this series does, and does not > > do. First, with the series applied and you don't force > > SOURCE_DATE_EPOCH, and you run make, and you re-run make, cmd/version.c > > is rebuilt (but only that and not a bunch of other things anymore) and > > the banner timestamp changes. Second, if you do set SOURCE_DATE_EPOCH > > to a fixed value (so you're trying to reproduce a build with a specific > > timestamp) AND re-run make, nothing changes, as it should. Third, if > > you change gcc, everything gets rebuilt including cmd/version.c and a > > new banner. >=20 > Yes that's my understanding and it seems fine. To be clear, I did a quick test with the series (git pw is very handy) for the above. --=20 Tom --BUCxE1jZmpnH0wI5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEKpucACgkQFHw5/5Y0 tyyNEQv9F+2JtTspnPEn/0Is9dHy35OH6FXoDUdh8Qp9Gcfibr1AC0yOwYHjsnZk 9oqX5Prax/qmoNQzLoT2LZQRUuBsJjj+iW/sQwHxanq2o8NEAAcsDeSqZWY32Xzb 2RR28/qc9BGFN8p/WTs8Nvx8M2bTQ/5dLjG0+jLpqEShV7Gh0p7wd5cT4A5gYN+s z0QFwZunfHyOCYi5aByj7WrRKlFpKOmB0d9gVnAcpjlEzw+Cn1bEQNCAFjRtiXKZ 2OpoSuDgw9czznlRmT8e9wuNWB4eEEx9BnnjzMpyL62cJPYJbyveHoFV7P3zvOB4 46tJlonPKmNdfnMI0vTPxBtg66gyRHOzKy68nVCR4OsLF2cr3R7b2R9T/34be4jx BQFv++lSXq5ngoFpz8/tvySrqxZ9dxVx3VEBks7U0aV1Oom6HTC/NuYooBwwDBmx 0ap5vvntRZjBL4x5wUjF3YrqBocUelwTgS/9Q/Bhgp2GbfcYRYEEAAFoUvx3ewt4 WOoWYKyq =jh8S -----END PGP SIGNATURE----- --BUCxE1jZmpnH0wI5--