From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D569FC432BE for ; Wed, 4 Aug 2021 16:12:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0F1360F35 for ; Wed, 4 Aug 2021 16:12:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234780AbhHDQNE (ORCPT ); Wed, 4 Aug 2021 12:13:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:34988 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234238AbhHDQK6 (ORCPT ); Wed, 4 Aug 2021 12:10:58 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id ECB0560F35; Wed, 4 Aug 2021 16:10:43 +0000 (UTC) Date: Wed, 4 Aug 2021 17:10:41 +0100 From: Catalin Marinas To: Michael Kelley Cc: will@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-efi@vger.kernel.org, wei.liu@kernel.org, kys@microsoft.com, sthemmin@microsoft.com, ardb@kernel.org Subject: Re: [PATCH v12 5/5] Drivers: hv: Enable Hyper-V code to be built on ARM64 Message-ID: <20210804161040.GC4857@arm.com> References: <1628092359-61351-1-git-send-email-mikelley@microsoft.com> <1628092359-61351-6-git-send-email-mikelley@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1628092359-61351-6-git-send-email-mikelley@microsoft.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 04, 2021 at 08:52:39AM -0700, Michael Kelley wrote: > Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on > ARM64, causing the Hyper-V specific code to be built. Exclude the > Hyper-V enlightened clocks/timers code from being built for ARM64. > > Signed-off-by: Michael Kelley > Reviewed-by: Boqun Feng > Acked-by: Marc Zyngier > Acked-by: Mark Rutland > > --- > drivers/hv/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig > index 66c794d..e509d5d 100644 > --- a/drivers/hv/Kconfig > +++ b/drivers/hv/Kconfig > @@ -4,7 +4,8 @@ menu "Microsoft Hyper-V guest support" > > config HYPERV > tristate "Microsoft Hyper-V client drivers" > - depends on X86 && ACPI && X86_LOCAL_APIC && HYPERVISOR_GUEST > + depends on ACPI && ((X86 && X86_LOCAL_APIC && HYPERVISOR_GUEST) \ > + || (ARM64 && !CPU_BIG_ENDIAN)) > select PARAVIRT > select X86_HV_CALLBACK_VECTOR Does this need to be: select X86_HV_CALLBACK_VECTOR if X86 I haven't checked whether it gives a warning on arm64 but that symbol doesn't exist. Anyway, I can fix it up locally. As an additional patch (it can be done later, once this goes upstream) I think we should replace the depends on with a single ARCH_HAS_HYPERV. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C20FC4338F for ; Wed, 4 Aug 2021 16:12:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 586A860E78 for ; Wed, 4 Aug 2021 16:12:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 586A860E78 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PjlDnsVwEDl+FK9vNU2ZSJMeigAtHWAM7F2vRQfg09k=; b=z3VSyUJh5/Q6/O QkwtffiH4AJ6W1Ece6bVhHYf8SnMjiqsRPqeqoGGluLxbhdsJiI8bn44u+6j6C1fww9ZASyp2o86T fSsKxOzqyxQq204rrs9iqadTMbqvqUdys9mzJvRGw5FTplCR+C7wBc7/SmlsY3TCXPg4igGpHWiLQ Fhn3qe9gY+J69N8HnpDH8U3RbkIzMD2SVGHMABBJyTW1y9uqLK8ZdAL+vkusgJwtOJuM+YXTnjDX5 2G5GBxXNGr8uBptn6gYZyv6dvzncFlFPlsuq4GL9xU2Q+rGP2LwDn9yZTVMf/zu8ol5L5bK+jdnts wKPiqf9g/ZsLII5OOCPQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBJTl-006jIP-W5; Wed, 04 Aug 2021 16:10:50 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBJTi-006jHs-Mq for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 16:10:48 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id ECB0560F35; Wed, 4 Aug 2021 16:10:43 +0000 (UTC) Date: Wed, 4 Aug 2021 17:10:41 +0100 From: Catalin Marinas To: Michael Kelley Cc: will@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-efi@vger.kernel.org, wei.liu@kernel.org, kys@microsoft.com, sthemmin@microsoft.com, ardb@kernel.org Subject: Re: [PATCH v12 5/5] Drivers: hv: Enable Hyper-V code to be built on ARM64 Message-ID: <20210804161040.GC4857@arm.com> References: <1628092359-61351-1-git-send-email-mikelley@microsoft.com> <1628092359-61351-6-git-send-email-mikelley@microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1628092359-61351-6-git-send-email-mikelley@microsoft.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_091046_806997_A553FE59 X-CRM114-Status: GOOD ( 18.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 04, 2021 at 08:52:39AM -0700, Michael Kelley wrote: > Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on > ARM64, causing the Hyper-V specific code to be built. Exclude the > Hyper-V enlightened clocks/timers code from being built for ARM64. > > Signed-off-by: Michael Kelley > Reviewed-by: Boqun Feng > Acked-by: Marc Zyngier > Acked-by: Mark Rutland > > --- > drivers/hv/Kconfig | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig > index 66c794d..e509d5d 100644 > --- a/drivers/hv/Kconfig > +++ b/drivers/hv/Kconfig > @@ -4,7 +4,8 @@ menu "Microsoft Hyper-V guest support" > > config HYPERV > tristate "Microsoft Hyper-V client drivers" > - depends on X86 && ACPI && X86_LOCAL_APIC && HYPERVISOR_GUEST > + depends on ACPI && ((X86 && X86_LOCAL_APIC && HYPERVISOR_GUEST) \ > + || (ARM64 && !CPU_BIG_ENDIAN)) > select PARAVIRT > select X86_HV_CALLBACK_VECTOR Does this need to be: select X86_HV_CALLBACK_VECTOR if X86 I haven't checked whether it gives a warning on arm64 but that symbol doesn't exist. Anyway, I can fix it up locally. As an additional patch (it can be done later, once this goes upstream) I think we should replace the depends on with a single ARCH_HAS_HYPERV. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel