From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F26EBC432BE for ; Wed, 4 Aug 2021 16:40:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D47B960243 for ; Wed, 4 Aug 2021 16:40:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239420AbhHDQkt (ORCPT ); Wed, 4 Aug 2021 12:40:49 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:55885 "EHLO mail-wm1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbhHDQkq (ORCPT ); Wed, 4 Aug 2021 12:40:46 -0400 Received: by mail-wm1-f51.google.com with SMTP id x17so1566757wmc.5; Wed, 04 Aug 2021 09:40:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ntN9WY4zmMZ23iXHsqDbV7BPHjIIMx7cF5b4w8slmdM=; b=E9rg148APKDCUiGyWGvz8xK7eXKnUuSmsPzc/AUGcBJtSYqullHi1lFZJDp/ycgc6u gDftB3d1CFPtCpkgZT1nxu53Yuo5/wrEUe8knor6+MMVtqD79vydw/CIHB/4zICuLiVm IHOigZGoQPDnsaH8OqZuNlw6ctTm1vPQc7mCwwwXvCfDK3c7Wc5VzpwCY/7SCdsmeNr/ ii4pGv20F3IFPVEdCqj7XHtSeR2G97J2v7Zm0JPD4VVwsHwlLv+5FIFYPRBVG1ZsMI/d lBqT8NHRl9uH7crOq6I4gp+2/++WI4u5n0Fzj860AgPiCCOpSlqrSR9Ur3mkmrj4++0P rZoA== X-Gm-Message-State: AOAM531W4AkjHP9mSqC8367rvh49S2nsZKX/yL0uWFws0E9M5+vea8lL c83r5TBTvzfZqJo+er7ObTI= X-Google-Smtp-Source: ABdhPJynlr56hUIGm77MB/+XdHVmQE9WJCF4/cvFGzgNtcIZYCGID8+vnvr9j88n+a8CO1dHLsp2uw== X-Received: by 2002:a05:600c:219:: with SMTP id 25mr484815wmi.49.1628095231907; Wed, 04 Aug 2021 09:40:31 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id v12sm3125785wrq.59.2021.08.04.09.40.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Aug 2021 09:40:30 -0700 (PDT) Date: Wed, 4 Aug 2021 16:40:29 +0000 From: Wei Liu To: Catalin Marinas Cc: Michael Kelley , will@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-efi@vger.kernel.org, wei.liu@kernel.org, kys@microsoft.com, sthemmin@microsoft.com, ardb@kernel.org Subject: Re: [PATCH v12 5/5] Drivers: hv: Enable Hyper-V code to be built on ARM64 Message-ID: <20210804164029.6xmloksmssrdsmvo@liuwe-devbox-debian-v2> References: <1628092359-61351-1-git-send-email-mikelley@microsoft.com> <1628092359-61351-6-git-send-email-mikelley@microsoft.com> <20210804161040.GC4857@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210804161040.GC4857@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 04, 2021 at 05:10:41PM +0100, Catalin Marinas wrote: > On Wed, Aug 04, 2021 at 08:52:39AM -0700, Michael Kelley wrote: > > Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on > > ARM64, causing the Hyper-V specific code to be built. Exclude the > > Hyper-V enlightened clocks/timers code from being built for ARM64. > > > > Signed-off-by: Michael Kelley > > Reviewed-by: Boqun Feng > > Acked-by: Marc Zyngier > > Acked-by: Mark Rutland > > > > --- > > drivers/hv/Kconfig | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig > > index 66c794d..e509d5d 100644 > > --- a/drivers/hv/Kconfig > > +++ b/drivers/hv/Kconfig > > @@ -4,7 +4,8 @@ menu "Microsoft Hyper-V guest support" > > > > config HYPERV > > tristate "Microsoft Hyper-V client drivers" > > - depends on X86 && ACPI && X86_LOCAL_APIC && HYPERVISOR_GUEST > > + depends on ACPI && ((X86 && X86_LOCAL_APIC && HYPERVISOR_GUEST) \ > > + || (ARM64 && !CPU_BIG_ENDIAN)) > > select PARAVIRT > > select X86_HV_CALLBACK_VECTOR > > Does this need to be: > > select X86_HV_CALLBACK_VECTOR if X86 > > I haven't checked whether it gives a warning on arm64 but that symbol > doesn't exist. > > Anyway, I can fix it up locally. I can fix it up while I queue these patches. Wei. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75B7AC4338F for ; Wed, 4 Aug 2021 16:42:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E1F160238 for ; Wed, 4 Aug 2021 16:42:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3E1F160238 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J1ghIQ/oh2DEVNj7nhBq91Xzrfvg+dZ+a1V5UVZDUPo=; b=y+nTIAPPzzz2kE d1Ki22ysETOsz9D1hdaPBhPjxM0tGKkbF8jJGh5sXTGkqmdeWowMFl+7VRHB9R/9e95qPxUjFoGtx katQPHEw1gVu1hXiAw5jdPz8I5koo4W8zOgxLuZTFWfXhDNc3+5b1kFhc2ENc4IfElQAVC02aZko5 CxDb7Vw/IBsNunCxrhfjM+vZKW2BWUJrJJRQLPM5o4JqmIDC7C06rJPbAj00mYxMtZkl1tXtgSCZP ZTb5/O60QxYon7Qe4R0R7Ar95cIi4lcQ+Gr5YUnFsxSdOJYbKpdVpffPrrddpC7m4kLkvfSFdPCMg mD0vFd1lP9qvMyuJxVGQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBJwd-006mse-HW; Wed, 04 Aug 2021 16:40:39 +0000 Received: from mail-wm1-f52.google.com ([209.85.128.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBJwZ-006mrK-B7 for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 16:40:36 +0000 Received: by mail-wm1-f52.google.com with SMTP id n11so1577847wmd.2 for ; Wed, 04 Aug 2021 09:40:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ntN9WY4zmMZ23iXHsqDbV7BPHjIIMx7cF5b4w8slmdM=; b=Ta6seLy9Sm7OX2RHDmgxNK3mjBA2GwRJ8LdX8Pdvz0/QjR3iMbe8R2MA3+oubQYlmc j4d7gNROksUPfwKCEm01t10NdPVrfqJIcJLH//lgIP4lY6vGtG+SNgpV5/mlXtdhmsku kBDRQ25OV5ClkitGhXGiqTloLMaBv2vmEsavDY3b63/5y/6aaYORWCbbTiPKtLfzSs2r TDKy3fLYnjdvtv0u9Eac8oQGo+L+cCC2fkPwb7bXK/RkXFPmaFnq5agF9y2yxChcuO8b KfU9S81gEiZGPYnaD/3qA61dQvVoOWaC2qmxoxS304WMaW26RIHo7PJpTCBpyx2XC/1Y DmPA== X-Gm-Message-State: AOAM5335Kk9cfmrZIlUsl2iuCevhhvrcBOeC6HxJKmDiyLDPL2arhDsP 4PQ3g4hw0oIO/cqHYVlOWEg= X-Google-Smtp-Source: ABdhPJynlr56hUIGm77MB/+XdHVmQE9WJCF4/cvFGzgNtcIZYCGID8+vnvr9j88n+a8CO1dHLsp2uw== X-Received: by 2002:a05:600c:219:: with SMTP id 25mr484815wmi.49.1628095231907; Wed, 04 Aug 2021 09:40:31 -0700 (PDT) Received: from liuwe-devbox-debian-v2 ([51.145.34.42]) by smtp.gmail.com with ESMTPSA id v12sm3125785wrq.59.2021.08.04.09.40.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Aug 2021 09:40:30 -0700 (PDT) Date: Wed, 4 Aug 2021 16:40:29 +0000 From: Wei Liu To: Catalin Marinas Cc: Michael Kelley , will@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-efi@vger.kernel.org, wei.liu@kernel.org, kys@microsoft.com, sthemmin@microsoft.com, ardb@kernel.org Subject: Re: [PATCH v12 5/5] Drivers: hv: Enable Hyper-V code to be built on ARM64 Message-ID: <20210804164029.6xmloksmssrdsmvo@liuwe-devbox-debian-v2> References: <1628092359-61351-1-git-send-email-mikelley@microsoft.com> <1628092359-61351-6-git-send-email-mikelley@microsoft.com> <20210804161040.GC4857@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210804161040.GC4857@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_094035_430096_03557443 X-CRM114-Status: GOOD ( 22.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 04, 2021 at 05:10:41PM +0100, Catalin Marinas wrote: > On Wed, Aug 04, 2021 at 08:52:39AM -0700, Michael Kelley wrote: > > Update drivers/hv/Kconfig so CONFIG_HYPERV can be selected on > > ARM64, causing the Hyper-V specific code to be built. Exclude the > > Hyper-V enlightened clocks/timers code from being built for ARM64. > > > > Signed-off-by: Michael Kelley > > Reviewed-by: Boqun Feng > > Acked-by: Marc Zyngier > > Acked-by: Mark Rutland > > > > --- > > drivers/hv/Kconfig | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/hv/Kconfig b/drivers/hv/Kconfig > > index 66c794d..e509d5d 100644 > > --- a/drivers/hv/Kconfig > > +++ b/drivers/hv/Kconfig > > @@ -4,7 +4,8 @@ menu "Microsoft Hyper-V guest support" > > > > config HYPERV > > tristate "Microsoft Hyper-V client drivers" > > - depends on X86 && ACPI && X86_LOCAL_APIC && HYPERVISOR_GUEST > > + depends on ACPI && ((X86 && X86_LOCAL_APIC && HYPERVISOR_GUEST) \ > > + || (ARM64 && !CPU_BIG_ENDIAN)) > > select PARAVIRT > > select X86_HV_CALLBACK_VECTOR > > Does this need to be: > > select X86_HV_CALLBACK_VECTOR if X86 > > I haven't checked whether it gives a warning on arm64 but that symbol > doesn't exist. > > Anyway, I can fix it up locally. I can fix it up while I queue these patches. Wei. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel