From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50090C4320A for ; Wed, 4 Aug 2021 21:47:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7014C61073 for ; Wed, 4 Aug 2021 21:47:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7014C61073 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5273B829E2; Wed, 4 Aug 2021 23:47:04 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="r7sLX1ay"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7FC8782DEC; Wed, 4 Aug 2021 23:47:02 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 48C6E82C38 for ; Wed, 4 Aug 2021 23:46:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id E637F60F94; Wed, 4 Aug 2021 21:46:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628113616; bh=om6A7nyuscMa90dvb3IAMfUq9Yr3Iwd52sVh/LYpb7I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r7sLX1ayfFw1eJH7fBPd6CJcr7Fyantj89ud8QRwQson8vlfXNfoF4oq5HEp//1A9 jtNid/lWsYe89u2ZbJZk7MH7GokXlBr/kNJCZyH57QbjJgpKnGeuRNolJm8lmU6/Ei rO7dIXWG9PCciWTXOoUxFMsi1w2RPO9s+/caCf4iA9W+9LWU2UMfs3ksAeIDK3Zgr9 pglD+lK0S9zPWJbJGa9s+nSGd/hFeTBn0agS6HKMxn1ddIQcusz9p23SDizV1qwRxS WZWI7ESyZ21H4RgNoZtSBWzICYgFQiWMnfKUgBMVLqngF/gqk60B+FnMgg7hn3lPQx EN6nCoCTK1Qeg== Received: by pali.im (Postfix) id 7764B77F; Wed, 4 Aug 2021 23:46:53 +0200 (CEST) Date: Wed, 4 Aug 2021 23:46:53 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Tom Rini Cc: Simon Glass , Wolfgang Denk , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?utf-8?B?QmVow7pu?= , U-Boot Mailing List Subject: Re: [PATCH 11/11] Remove including timestamp.h in version.h Message-ID: <20210804214653.ex5cvuaqexy4db4g@pali> References: <20210802131838.21097-1-pali@kernel.org> <20210802131838.21097-12-pali@kernel.org> <20210802194223.5myvz6l27rjkfrld@pali> <20210802213100.GG9379@bill-the-cat> <128122.1628056761@gemini.denx.de> <20210804124413.GZ9379@bill-the-cat> <20210804144042.GA9379@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210804144042.GA9379@bill-the-cat> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Wednesday 04 August 2021 10:40:42 Tom Rini wrote: > On Wed, Aug 04, 2021 at 08:36:27AM -0600, Simon Glass wrote: > > Hi Tom, > > > > On Wed, 4 Aug 2021 at 06:44, Tom Rini wrote: > > > > > > On Wed, Aug 04, 2021 at 07:59:21AM +0200, Wolfgang Denk wrote: > > > > > > > Dear Tom, > > > > > > > > In message <20210802213100.GG9379@bill-the-cat> you wrote: > > > > > > > > > > I think that if nothing changes the banner not changing is the right > > > > > behavior. > > > > > > > > Hm... is it? How about "external" changes like building with a > > > > different tool chain? Then at least the "version" command should > > > > produce a corresponding output, which means some parts _have_ to be > > > > recompiled, resulting in a new banner, too ? > > > > > > There's some misunderstanding about what this series does, and does not > > > do. First, with the series applied and you don't force > > > SOURCE_DATE_EPOCH, and you run make, and you re-run make, cmd/version.c > > > is rebuilt (but only that and not a bunch of other things anymore) and > > > the banner timestamp changes. Second, if you do set SOURCE_DATE_EPOCH > > > to a fixed value (so you're trying to reproduce a build with a specific > > > timestamp) AND re-run make, nothing changes, as it should. Third, if > > > you change gcc, everything gets rebuilt including cmd/version.c and a > > > new banner. > > > > Yes that's my understanding and it seems fine. > > To be clear, I did a quick test with the series (git pw is very handy) > for the above. Thanks for clarification! You are of course right.