From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1226C4338F for ; Wed, 4 Aug 2021 22:16:07 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EDF660F25 for ; Wed, 4 Aug 2021 22:16:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5EDF660F25 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9FFFC82C09; Thu, 5 Aug 2021 00:16:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="S0cW42TS"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 407E882C7C; Thu, 5 Aug 2021 00:16:04 +0200 (CEST) Received: from mail-qk1-x72b.google.com (mail-qk1-x72b.google.com [IPv6:2607:f8b0:4864:20::72b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 60C1282BC7 for ; Thu, 5 Aug 2021 00:15:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qk1-x72b.google.com with SMTP id t3so3050456qkg.11 for ; Wed, 04 Aug 2021 15:15:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=v79E6J3jsccGuG9KvHk2nmuPYrA5RV5JbbhoEBhwfNQ=; b=S0cW42TSUCmkUzE1IVdTtEZnuum09tP3Pxuy340ZMGO4AiwQrTdUhvFqQx0IDMS+1P kmdMr23DvxjLmXFMdemprfyPINnbDdcuNz35afTEVxDa9dVVIwwxeeD5SxYmwye8osik x+hu+Wcak76aylPHSg+ZigLyxteIpbQNXos4k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=v79E6J3jsccGuG9KvHk2nmuPYrA5RV5JbbhoEBhwfNQ=; b=cOk2dq2gghuAoftyd60blpnx2yHDdatQ7x341UmRedi+DTAhK3bwYlIN6YHT5jiJr3 BeIWYuxLwMU+GqCjo+m3esT5HbMHdx6gZ6TVybkKNG5NDh++VBR9Yc4Fr+ZIQl0fkEBg PfD0hc4EGOytli3GMFRAxu/YaMgkM7LkdSy+QKsHjTbsvFpCi2Qi2ywke3VaDovkGHld CD6dGZMX7dm4i8kB4VvvR7lG4/qeGA31xzYVS0mFMZZBT7T5ZUuAZiY1VGxV/++1SY/F x8n1ns3QaI0ZttDyXZfh2JWC5uOw3S7kg7biEfMK3bfDuHJH2U+AFiMQZffFasb8BkEU NSsg== X-Gm-Message-State: AOAM532MwJcfozD2qJ241uD7Xtl8C4R5Fyq5+RYgaVbFY2baz2w8URaA WgoJ/OG97d6xbawlKDX9gK/wlA== X-Google-Smtp-Source: ABdhPJx4B9J1xwNXLcDfUXyZSyIOdOfVcQR6/uDJ8mB2/p3KkMWss3N4S4rW7n1Ca92Ds70/F0jT3g== X-Received: by 2002:a05:620a:13f5:: with SMTP id h21mr1712243qkl.252.1628115358228; Wed, 04 Aug 2021 15:15:58 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a9d9-7fe0-6131-a526.res6.spectrum.com. [2603:6081:7b01:cbda:a9d9:7fe0:6131:a526]) by smtp.gmail.com with ESMTPSA id c68sm2134187qkf.48.2021.08.04.15.15.56 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 04 Aug 2021 15:15:57 -0700 (PDT) Date: Wed, 4 Aug 2021 18:15:55 -0400 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Sean Anderson , Simon Glass , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?iso-8859-1?Q?Beh=FAn?= , U-Boot Mailing List Subject: Re: [PATCH 11/11] Remove including timestamp.h in version.h Message-ID: <20210804221555.GB858@bill-the-cat> References: <20210802131838.21097-1-pali@kernel.org> <20210802131838.21097-12-pali@kernel.org> <815b40e2-aa57-abfb-901f-979507a9e3b7@seco.com> <20210804220914.GA858@bill-the-cat> <20210804221429.wzw23up3ahoswuyd@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rJwd6BRFiFCcLxzm" Content-Disposition: inline In-Reply-To: <20210804221429.wzw23up3ahoswuyd@pali> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --rJwd6BRFiFCcLxzm Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 05, 2021 at 12:14:29AM +0200, Pali Roh=E1r wrote: > On Wednesday 04 August 2021 18:09:14 Tom Rini wrote: > > On Wed, Aug 04, 2021 at 05:43:41PM -0400, Sean Anderson wrote: > > >=20 > > >=20 > > > On 8/2/21 3:21 PM, Simon Glass wrote: > > > > Hi Pali, > > > >=20 > > > > On Mon, 2 Aug 2021 at 07:20, Pali Roh=E1r wrote: > > > > >=20 > > > > > Header file version.h does not use anything from timestamp.h. Inc= luding of > > > > > timestamp.h has side effect which cause recompiling object file a= t every > > > > > make run because timestamp.h changes at every run. > > > > >=20 > > > > > So remove timestamp.h from version.h and include timestamp.h in f= iles > > > > > which needs it. > > > > >=20 > > > > > This change reduce recompilation time of final U-Boot binary when= U-Boot > > > > > source files were not changed as less source files needs to be re= compiled. > > > > >=20 > > > > > Signed-off-by: Pali Roh=E1r > > > > > --- > > > > > arch/arm/mach-rockchip/tpl.c | 4 ++++ > > > > > board/work-microwave/work_92105/work_92105_display.c | 1 + > > > > > cmd/version.c | 1 + > > > > > common/spl/spl.c | 4 ++++ > > > > > drivers/rtc/emul_rtc.c | 2 +- > > > > > include/version.h | 2 -- > > > > > 6 files changed, 11 insertions(+), 3 deletions(-) > > > >=20 > > > > Reviewed-by: Simon Glass > > > >=20 > > > > I assume we do actually want to regenerate the timestamp when U-Boot > > > > builds, even if nothing has changed. Is that right? > > >=20 > > > I know this is the current behavior, but it would be nice if this was > > > not the case. If one is building U-Boot as part of a larger project, = one > > > might want to have a makefile rule like > > >=20 > > > u-boot/u-boot.bin: > > > $(MAKE) -C u-boot $(@F) > > >=20 > > > but u-boot/u-boot.bin will always be remade even if no changes have b= een > > > done. This will cause make to remake all dependents of U-Boot as well > > > (which can be rather time-consuming). > > >=20 > > > At the moment, I just use U-Boot as an order-only dependency and rema= ke > > > it manually. But I would love it if U-Boot was only remade if > > > dependencies had actually changed, since this would make it easier to > > > integrate it with the rest of my build system. > >=20 > > Note that with this series applied, if you made use of > > SOURCE_DATE_EPOCH, nothing would be rebuilt. >=20 > IIRC with SOURCE_DATE_EPOCH nothing would be rebuilt also without > applying this my patch series. Correct, it does not. > > That may or may not make > > sense however, in your case. This series does get us closer to being > > able to do what the linux kernel does as there's now just one place > > rather than a bunch of places that are rebuilt. >=20 > Just small correction. Even with this patch series there would not be > just one place. There are still more places but this patch series reduce > number of these places. Ah, I only saw one place in my limited testing this morning. --=20 Tom --rJwd6BRFiFCcLxzm Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmELEZoACgkQFHw5/5Y0 tywIhgv9FqYBi1idSCSIwbRT5M2lEvxYGz3dnhdBpvU9jPStkWClp5EE8DfufoBK AyFrt/632Fs1AoJUBYSuxeaIOX/vt2zh93QzczO7TULx8kHOmk7HEF8vBGDoi5YO aQfXl4FwIPAKgGpSuUzwAQKi6UwGVTsMagMGEecTiqO1RGDA1/1bWPloPPIVbFVU 2mgybhiW4/wdAfa/s2c7lLBSqqeUjpYQoJNbYraj8tewGleVvir2+Ov7MvzBMxpU VICkbrapr31aLZqpKrAnq00qrHywoIi2OV/ehiGGYKpnz+9iDlZNREkLOrlCpIDK rkDEpqZt0riKF9XXOWlbG5irQIUsX34LwQc5HiVvYGDdByn7ftgPnAAx72FLkkjN /mYpGUmo++O8P0/XggaJ+09uu3e3n5jytuGjI3U0Jj588Y7ud0cUpXIddbIz0EzQ Bhn6jHxObMkYlab0ShoINSQAJQCNza8wiJzGrJi61+DfB6zKwQaoad6jgkQku1kx T2kosI8O =Bt0L -----END PGP SIGNATURE----- --rJwd6BRFiFCcLxzm--