From: Gerd Hoffmann <kraxel@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-block@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>
Subject: Re: [PATCH 0/7] floppy: build as modules.
Date: Thu, 5 Aug 2021 09:11:55 +0200 [thread overview]
Message-ID: <20210805071155.pkvs4fjjdlx3juoo@sirius.home.kraxel.org> (raw)
In-Reply-To: <477961d5-576b-a588-9cea-dad796c592d2@amsat.org>
On Wed, Aug 04, 2021 at 05:19:02PM +0200, Philippe Mathieu-Daudé wrote:
> +Mark
>
> On 8/4/21 4:27 PM, Gerd Hoffmann wrote:
> > Some code shuffling needed beforehand due to floppy being part of
> > several platforms. While being at it also make floppy optional
> > in pc machine type.
>
> > floppy: move fdctrl_init_sysbus
> > floppy: move sun4m_fdctrl_init
>
> https://www.mail-archive.com/qemu-block@nongnu.org/msg84008.html
>
> Mark suggested:
>
> You may be able to simplify this further by removing the
> global legacy init functions fdctrl_init_sysbus() and
> sun4m_fdctrl_init(): from what I can see fdctrl_init_sysbus()
> is only used in hw/mips/jazz.c and sun4m_fdctrl_init() is only
> used in hw/sparc/sun4m.c so you might as well inline them or
> move the functions to the relevant files.
>
> I did it and plan to send during 6.2. Sounds simpler than module.
> You could easily rebase your series on top (or I can include your
> patches while sending).
Feel free to include them. But I can also rebase when your patches
landed upstream. Your choice ;)
take care,
Gerd
next prev parent reply other threads:[~2021-08-05 7:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 14:27 [PATCH 0/7] floppy: build as modules Gerd Hoffmann
2021-08-04 14:27 ` [PATCH 1/7] floppy: move isa_fdc_get_drive_type to separate source file Gerd Hoffmann
2021-08-04 14:27 ` [PATCH 2/7] floppy: move isa_fdc_init_drives + fdctrl_init_drives Gerd Hoffmann
2021-08-04 14:27 ` [PATCH 3/7] floppy: move fdctrl_init_sysbus Gerd Hoffmann
2021-08-04 14:27 ` [PATCH 4/7] floppy: move sun4m_fdctrl_init Gerd Hoffmann
2021-08-04 14:27 ` [PATCH 5/7] floppy: move cmos_get_fd_drive_type Gerd Hoffmann
2021-08-04 14:27 ` [PATCH 6/7] floppy: build as modules Gerd Hoffmann
2021-08-04 14:27 ` [PATCH 7/7] pc: add floppy=OnOffAuto Gerd Hoffmann
2021-08-04 15:19 ` [PATCH 0/7] floppy: build as modules Philippe Mathieu-Daudé
2021-08-05 7:11 ` Gerd Hoffmann [this message]
2021-08-16 21:55 ` John Snow
2021-08-17 9:09 ` Philippe Mathieu-Daudé
2021-08-17 13:19 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210805071155.pkvs4fjjdlx3juoo@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.