From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EE07C4338F for ; Thu, 5 Aug 2021 13:22:57 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9095D6113B for ; Thu, 5 Aug 2021 13:22:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9095D6113B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6BE6582DF6; Thu, 5 Aug 2021 15:22:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="iAES9Lic"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 603C482DF6; Thu, 5 Aug 2021 15:22:53 +0200 (CEST) Received: from mail-qv1-xf31.google.com (mail-qv1-xf31.google.com [IPv6:2607:f8b0:4864:20::f31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3EC4182903 for ; Thu, 5 Aug 2021 15:22:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf31.google.com with SMTP id cg4so2889796qvb.5 for ; Thu, 05 Aug 2021 06:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=XU8snR4wD18HQghuIcCFZBHuxRVOaJyAgH/VJLds2eY=; b=iAES9LicDwYD4H9wJgKtYb11NvsTc2Cj7r3k8tRnluSyblA3xaIzkLtU5cw8q0k7P6 eqbqrdIy78O2jofSZg9DqChyWrMwoc8qYhNQ6oysL5nfyurrBskdZBE0j5A3lIEJPYZc jSbgavlzQCtzWARdSABJxwBLcYI+OafwmC6dw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=XU8snR4wD18HQghuIcCFZBHuxRVOaJyAgH/VJLds2eY=; b=KevmqWS+vAWv668ehY6u3tAZSlwFet7s2P2aTjl+CIxvX81ToFZnFbG+6WhCKO4Ier swLSRbn+0TODXQYywzUkobNV9Yffo9QheXHFO0MWxX2QTfmbMEycAuJQWp0WA+hR+gWu PrY3rfVZTNAzO5u+1eXaENFH3M9NQm3xIjFIVNNVQ104TWbYy3Kpy1wXhBkmsGdKhW/n oabMjiZWDrrvSbHo9zOu6QIOhBLxu116gT8fP+4ObUcDyQ2xHBMmrkxNh2cJXgL1uh1n 2N6vPaO7IkqbbMpuytUDGbgnbL1IO7zvAw1gaMJP68yFmw7bgpasCvaCp1MdlSCEeD9f S+Fg== X-Gm-Message-State: AOAM5301TWLxREsudKWz22cu2Mi53/WtNb/kfUYZhDDyVZ52/kSHpyFe wtqb7lbLF+OSGwi4sPRn6I1Vpg== X-Google-Smtp-Source: ABdhPJx8O0sUAYW8c5tVZJ2bedvpfDns0Zv885x2DrgGDoMv7hWX8c6tUr+ynq6RqnBicJJCmhFk9A== X-Received: by 2002:a05:6214:c6d:: with SMTP id t13mr5204952qvj.22.1628169768852; Thu, 05 Aug 2021 06:22:48 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-a9d9-7fe0-6131-a526.res6.spectrum.com. [2603:6081:7b01:cbda:a9d9:7fe0:6131:a526]) by smtp.gmail.com with ESMTPSA id c11sm2252208qth.29.2021.08.05.06.22.47 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Aug 2021 06:22:48 -0700 (PDT) Date: Thu, 5 Aug 2021 09:22:46 -0400 From: Tom Rini To: T Karthik Reddy Cc: Ashok Reddy Soma , "u-boot@lists.denx.de" , "miquel.raynal@bootlin.com" , git Subject: Re: [PATCH] test/py: tpm2: Skip tpm pytest based on env variable Message-ID: <20210805132246.GJ858@bill-the-cat> References: <20210723121826.23072-1-ashok.reddy.soma@xilinx.com> <20210804152149.GB9379@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="8jNwmpfkpox/fiJK" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --8jNwmpfkpox/fiJK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 05, 2021 at 05:56:50AM +0000, T Karthik Reddy wrote: > Hello Tom Rini, >=20 > > -----Original Message----- > > From: Tom Rini > > Sent: Wednesday, August 4, 2021 8:52 PM > > To: Ashok Reddy Soma > > Cc: u-boot@lists.denx.de; miquel.raynal@bootlin.com; git ; > > T Karthik Reddy > > Subject: Re: [PATCH] test/py: tpm2: Skip tpm pytest based on env variab= le > >=20 > > On Fri, Jul 23, 2021 at 06:18:26AM -0600, Ashok Reddy Soma wrote: > >=20 > > > From: T Karthik Reddy > > > > > > Tpm test cases relies on tpm device setup. Provide an environment > > > variable "env__tpm_device_test_skip =3D True" to skip the test case if > > > tpm device is not present. > > > Only needed will have to add variable to the py-test framework. > > > Test runs successfully even this variable is absent. > > > > > > Signed-off-by: T Karthik Reddy > > > Signed-off-by: Ashok Reddy Soma > >=20 > > Why is this not using boardenv_* like other tests do to disable running? >=20 > What I meant here was this test doesn't depend on configuration value fro= m boardenv_*. But it uses env__tpm_device_test_skip > variable from the configuration file.=20 > I referred test/py/tests/test_sleep.py for writing this test case, hence = copied comments as well. > Should I change this NOTE in comment section? Thanks for explaining. This got me to re-read the existing tests and while none of it is as clear as I would like, your example here is just as clear as the rest, so it's fine and I'll pick it up soon. --=20 Tom --8jNwmpfkpox/fiJK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmEL5iMACgkQFHw5/5Y0 tyyK1wv/U4bNq886c05+tExGcAN10pqCVAjoBagk36WKzq6zPV9kdXaASm0c0okO gBrdbAE+sn9NmflUw9754HnxapzB45Lby+1AldLVoS3gxLUih+fGtBJUj/JoZaSQ cGx6/3kXFUDDufwDZuBfH7hjdbgMsWjBFtrhxbhixq+KxymU4yzznVF2HqvBNTOw lFtuLhqhhXWeKXKIOTu3AH0Htt54tD1gwc+nYhFnsNR4ZJJQuOlWbWdK/ReyI15t U3S3sn41h8F26lc1xWgh6WlBdaj9qLtnIssRrJmSmWWUUdIkIMTcjzFR1Seg96Pb dd6TwODnUskcRDVk8gHRQUNPMErOC1YHtJDpCR7MBGmWE7eAOMZ9G8ZwelaNi+97 Mkzd8XV8lD5xK5Rc4bdwMzZLl848ElFQmTCEF+Ff71eP9gSZ73Q72JNjmwILY4pX q5l1pxyWG2L5xR2V07JzHjgBtgvHAVvCUPZPhqGm+lrNk0MDABzNL/ANnxQwwczB 9HRpWY73 =fkxP -----END PGP SIGNATURE----- --8jNwmpfkpox/fiJK--