From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 462A1C4338F for ; Thu, 5 Aug 2021 22:14:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8534E6112F for ; Thu, 5 Aug 2021 22:14:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8534E6112F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mBld0-0000ja-BE for qemu-devel@archiver.kernel.org; Thu, 05 Aug 2021 18:14:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55846) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBlcO-0008VZ-Tx for qemu-devel@nongnu.org; Thu, 05 Aug 2021 18:13:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:31053) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBlcM-00034D-2b for qemu-devel@nongnu.org; Thu, 05 Aug 2021 18:13:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628201610; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XkgiJdlGCnCROlBVkszbMjS2498F6K+nIAjvuCfdc0c=; b=FlJGvjYiRwfEmnD1OYENgnS7L5X8N8Gto3CoTkdhJESxBUdKvVrPKh4FORsNqUujPZfhEi 8i0yWLqOrihMY/yYBUK38gbKLug3qIkLfaH6zRW+WjZleNhFt7nROPB4mMKPY12RXsDhGn XW7eQe9nTt0IewMlgGenkBL5pJxWW60= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-DckF6hPGOw2cIwQw5InD7w-1; Thu, 05 Aug 2021 18:13:29 -0400 X-MC-Unique: DckF6hPGOw2cIwQw5InD7w-1 Received: by mail-ej1-f71.google.com with SMTP id lu19-20020a170906fad3b029058768348f55so2534349ejb.12 for ; Thu, 05 Aug 2021 15:13:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=XkgiJdlGCnCROlBVkszbMjS2498F6K+nIAjvuCfdc0c=; b=nDR1Kw2LqsZK4UIDaDANuV3w6NcjJqGY+/ZQW+Ilc8WyfiTyh5muDtogKDpxOss737 FfssxPABkZuy3mYHiPmKM2PVdw0k/hfp0fRQbcbttLTxjCHYDoVBru4bVgCL5FCKTmpu yBdO7nI7XTsJnYLrzBx2pkhl7orrbRaYJBl2xAzVOQ3BWsY2ZQzDOROf9gWZqrXWIS1F 5hn0xhUFwhJwJwq+7Ai+Py93hHCPjj1pvd8MBrmpz4Mmi1yIDnXKMxva0MzxQMyOP2PR zHLPW0qgv00Qj13Xi2VZfy7KlUtEP45MuMOt3sbu5YSmsRSMf1wx/DAP5QWl52MEamUW CSGg== X-Gm-Message-State: AOAM531P+bmXhn1TCZFPTj0Huxeyy4Fj0GzRM04HoWJhamag3deGyFli 24WrSyrKt20feeVe7e3ZD8NWgLmIgvv8go2D/Blfzac5mmKak0Hy4sothUZO9EWybqOZp+OrBg4 NEj+mHwvYHZ0ojmg= X-Received: by 2002:aa7:d70b:: with SMTP id t11mr6702801edq.20.1628201608304; Thu, 05 Aug 2021 15:13:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQiqvxVKL5yvTY6nRDgn2YrG+gmDhbniizx3h5BqEeKMQdheKM3TgJFPeoTreV4+QZJIJkKg== X-Received: by 2002:aa7:d70b:: with SMTP id t11mr6702778edq.20.1628201608077; Thu, 05 Aug 2021 15:13:28 -0700 (PDT) Received: from redhat.com ([2.55.141.248]) by smtp.gmail.com with ESMTPSA id c22sm2960847eds.1.2021.08.05.15.13.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Aug 2021 15:13:25 -0700 (PDT) Date: Thu, 5 Aug 2021 18:13:21 -0400 From: "Michael S. Tsirkin" To: Ani Sinha Subject: Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host Message-ID: <20210805180915-mutt-send-email-mst@kernel.org> References: <20210726165743.232073-1-ani@anisinha.ca> <20210805111543.5fb99abf@redhat.com> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , jusual@redhat.com, Richard Henderson , qemu-devel@nongnu.org, Paolo Bonzini , Igor Mammedov Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Aug 05, 2021 at 07:42:35PM +0530, Ani Sinha wrote: > Also to be noted that there is a stub for acpi_get_i386_pci_host() which > simply returns NULL. This activates when CONFIG_PC is disabled. It is this > stub that gets called for mips and hence the check for non-null host is > needed in acpi_set_pci_info() function. > Frankly this is generating more discussion that it's worth imho. IMHO these tweaks will bring little benefit. Igor do you feel differently? -- MST