From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3B4BC4320A for ; Fri, 6 Aug 2021 07:20:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1C8461179 for ; Fri, 6 Aug 2021 07:20:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243585AbhHFHUz (ORCPT ); Fri, 6 Aug 2021 03:20:55 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27147 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242012AbhHFHUp (ORCPT ); Fri, 6 Aug 2021 03:20:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628234429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HTm9fbXgLtcZGdGW/3I21kvZ1VGYI5U7k0mhmEpEDg0=; b=FSTa0CY5QWVMGSAhJkJC7vjnuHrBQCQfqwkY3HEfrr+B3P9NL1ZZzdAfJtB+3FwPXwV1nx 2WS96G0N6qoKpi1YBaXeve/LdBjuzFszM7dgnpn9eUQH9IyYQFj5DsxiApY/6bHmjiEmYU bWdDXK9GSg1mp+a/TUA8U1aSU2vMsns= Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-156-tDQHwIlcM7Co9dnYzqwu1A-1; Fri, 06 Aug 2021 03:20:28 -0400 X-MC-Unique: tDQHwIlcM7Co9dnYzqwu1A-1 Received: by mail-ed1-f72.google.com with SMTP id u25-20020aa7d8990000b02903bb6a903d90so4438146edq.17 for ; Fri, 06 Aug 2021 00:20:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HTm9fbXgLtcZGdGW/3I21kvZ1VGYI5U7k0mhmEpEDg0=; b=VrBUMCpQ6Qs1EGNYwZbJyEi8H2CVHi8YwV0YIT9VMNppL7j6OzREdaOcYlmfQaxSSm tF1mTEhx0YjfnoBkDymDWOTaoXHRmpD7He+QHXUixkiZxVbOPlvbFsJ5ST1tU7t6RM3Y zuO549GRGm2N05vXRBAc/PtitvK+CejBu/hx4mhgUfacZa5cZVQbpJ2f5tRznE3ix2T1 Rl0EPVptY8sRa11wUh/PJBJz0naPtGPQKAL/XhWBX3HQXI3/WPkxJGENVVQJ1tstkE3h m90/++6/MVhlBSoh4zKoav7jn1PVhQavj16B6dqPh8po9lbCu3bT5e+VBZZepzh3qxA4 Nmjw== X-Gm-Message-State: AOAM532a3UauJbBbG7mQ5RLcyeUUFRIR8xhIU9PsLmwVn9AW1bIYGxx8 Nmv95pBZCQDOTgaWIl9vK50GvcU2YSLM9UBL6Ab6k0ablYtFqVqqg/5LSHkUY+jjTnTHkJE97So UoZHuIf0/bX2w/iVJJluC4jk0 X-Received: by 2002:a05:6402:361:: with SMTP id s1mr11209643edw.172.1628234427596; Fri, 06 Aug 2021 00:20:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuVKndM6vRqX10g0DMF+zN0NMme5c3sOtXbrtFonOTm7kn0n+W/NJwkU2ojVAcnd/691RvGg== X-Received: by 2002:a05:6402:361:: with SMTP id s1mr11209627edw.172.1628234427450; Fri, 06 Aug 2021 00:20:27 -0700 (PDT) Received: from steredhat (host-79-18-148-79.retail.telecomitalia.it. [79.18.148.79]) by smtp.gmail.com with ESMTPSA id p16sm3396595eds.73.2021.08.06.00.20.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Aug 2021 00:20:27 -0700 (PDT) Date: Fri, 6 Aug 2021 09:20:24 +0200 From: Stefano Garzarella To: Arseny Krasnov Cc: Stefan Hajnoczi , "Michael S. Tsirkin" , Jason Wang , "David S. Miller" , Jakub Kicinski , Jorgen Hansen , Norbert Slusarek , Colin Ian King , Andra Paraschiv , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, oxffffaa@gmail.com Subject: Re: [RFC PATCH v1 2/7] vsock: rename implementation from 'record' to 'message' Message-ID: <20210806072024.ejp2d5sgfatga6oz@steredhat> References: <20210726163137.2589102-1-arseny.krasnov@kaspersky.com> <20210726163328.2589649-1-arseny.krasnov@kaspersky.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20210726163328.2589649-1-arseny.krasnov@kaspersky.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 26, 2021 at 07:33:25PM +0300, Arseny Krasnov wrote: >As 'record' is not same as 'message', rename current variables, >comments and defines from 'record' concept to 'message'. > >Signed-off-by: Arseny Krasnov >--- > drivers/vhost/vsock.c | 18 +++++++++--------- > net/vmw_vsock/virtio_transport_common.c | 14 +++++++------- > 2 files changed, 16 insertions(+), 16 deletions(-) This patch is fine, I think you can move here the renaming of the flag too. Stefano From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2002C4338F for ; Fri, 6 Aug 2021 07:20:35 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53BEF61179 for ; Fri, 6 Aug 2021 07:20:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 53BEF61179 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2106B6089F; Fri, 6 Aug 2021 07:20:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iol3rH-aCgQW; Fri, 6 Aug 2021 07:20:34 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id CEB686087B; Fri, 6 Aug 2021 07:20:33 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id A498AC001A; Fri, 6 Aug 2021 07:20:33 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id CD626C000E for ; Fri, 6 Aug 2021 07:20:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id C5D764014E for ; Fri, 6 Aug 2021 07:20:31 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CsiRGsTruhI6 for ; Fri, 6 Aug 2021 07:20:31 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id D220340124 for ; Fri, 6 Aug 2021 07:20:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628234429; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HTm9fbXgLtcZGdGW/3I21kvZ1VGYI5U7k0mhmEpEDg0=; b=FSTa0CY5QWVMGSAhJkJC7vjnuHrBQCQfqwkY3HEfrr+B3P9NL1ZZzdAfJtB+3FwPXwV1nx 2WS96G0N6qoKpi1YBaXeve/LdBjuzFszM7dgnpn9eUQH9IyYQFj5DsxiApY/6bHmjiEmYU bWdDXK9GSg1mp+a/TUA8U1aSU2vMsns= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152-JYemRZ9aPumgz91Q77IW1w-1; Fri, 06 Aug 2021 03:20:28 -0400 X-MC-Unique: JYemRZ9aPumgz91Q77IW1w-1 Received: by mail-ej1-f71.google.com with SMTP id g19-20020a1709065953b02905a4506b6d92so2869177ejr.7 for ; Fri, 06 Aug 2021 00:20:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HTm9fbXgLtcZGdGW/3I21kvZ1VGYI5U7k0mhmEpEDg0=; b=dOeoJ6DU93AI8xQnNCuKbrnPvziBGBZi5hx7/K225s5/Os6wCXrH9kBoM38oQxxdaY 087ugTj20IB3j6NFdfwC8jJ1hy7bCqwILLBsNE5+JmuJEMFFqC2yJfnCX20uNh9nICNc UxK4cwJ7urBRcEK1QV003XTLJIyT0dk2FWEu+LaJq/FSCrGmJ5aNAun/WBW3+nKoEWqn MB5tCOMJjEvzlmdzx+mGucBasPETt+aC+BmNzxtwOxkNPblGvOvzMjhFhLeFtxOxJ/fH e+WpRw8ua78TxqUl48xawOZHnF5nWOAhH4fzpf0s0RgmvVI3+bCkv8EARCspnKSXu3vN H/ng== X-Gm-Message-State: AOAM533ujGezJJsS2Nz7onLgFxpHrB8vtYUXGRlR3MA6MTCJ0setp2jP Wu6b/5R/BVDo+AXjd7Vi7+gb4Uay+Ekyp3qkwv2ZUK1kPP2Goa2qMwpO+y02NGQBxIp+Tu5RHHh gRCI3SVlPY2QbRIXcZe8qz0L5HRce/2dJrXUnqOac3g== X-Received: by 2002:a05:6402:361:: with SMTP id s1mr11209649edw.172.1628234427597; Fri, 06 Aug 2021 00:20:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyuVKndM6vRqX10g0DMF+zN0NMme5c3sOtXbrtFonOTm7kn0n+W/NJwkU2ojVAcnd/691RvGg== X-Received: by 2002:a05:6402:361:: with SMTP id s1mr11209627edw.172.1628234427450; Fri, 06 Aug 2021 00:20:27 -0700 (PDT) Received: from steredhat (host-79-18-148-79.retail.telecomitalia.it. [79.18.148.79]) by smtp.gmail.com with ESMTPSA id p16sm3396595eds.73.2021.08.06.00.20.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Aug 2021 00:20:27 -0700 (PDT) Date: Fri, 6 Aug 2021 09:20:24 +0200 From: Stefano Garzarella To: Arseny Krasnov Subject: Re: [RFC PATCH v1 2/7] vsock: rename implementation from 'record' to 'message' Message-ID: <20210806072024.ejp2d5sgfatga6oz@steredhat> References: <20210726163137.2589102-1-arseny.krasnov@kaspersky.com> <20210726163328.2589649-1-arseny.krasnov@kaspersky.com> MIME-Version: 1.0 In-Reply-To: <20210726163328.2589649-1-arseny.krasnov@kaspersky.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sgarzare@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: Andra Paraschiv , kvm@vger.kernel.org, "Michael S. Tsirkin" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, oxffffaa@gmail.com, Norbert Slusarek , Stefan Hajnoczi , Colin Ian King , Jakub Kicinski , "David S. Miller" , Jorgen Hansen X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On Mon, Jul 26, 2021 at 07:33:25PM +0300, Arseny Krasnov wrote: >As 'record' is not same as 'message', rename current variables, >comments and defines from 'record' concept to 'message'. > >Signed-off-by: Arseny Krasnov >--- > drivers/vhost/vsock.c | 18 +++++++++--------- > net/vmw_vsock/virtio_transport_common.c | 14 +++++++------- > 2 files changed, 16 insertions(+), 16 deletions(-) This patch is fine, I think you can move here the renaming of the flag too. Stefano _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization