* [PATCH net] nfp: update ethtool reporting of pauseframe control
@ 2021-08-03 10:39 Simon Horman
2021-08-03 12:00 ` patchwork-bot+netdevbpf
2021-08-03 15:03 ` Andrew Lunn
0 siblings, 2 replies; 6+ messages in thread
From: Simon Horman @ 2021-08-03 10:39 UTC (permalink / raw)
To: David Miller, Jakub Kicinski
Cc: netdev, oss-drivers, Fei Qin, Louis Peens, Simon Horman
From: Fei Qin <fei.qin@corigine.com>
Pauseframe control is set to symmetric mode by default on the NFP.
Pause frames can not be configured through ethtool now, but ethtool can
report the supported mode.
Fixes: 265aeb511bd5 ("nfp: add support for .get_link_ksettings()")
Signed-off-by: Fei Qin <fei.qin@corigine.com>
Signed-off-by: Louis Peens <louis.peens@corigine.com>
Signed-off-by: Simon Horman <simon.horman@corigine.com>
---
drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
index 1b482446536d..8803faadd302 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
@@ -286,6 +286,8 @@ nfp_net_get_link_ksettings(struct net_device *netdev,
/* Init to unknowns */
ethtool_link_ksettings_add_link_mode(cmd, supported, FIBRE);
+ ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
+ ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
cmd->base.port = PORT_OTHER;
cmd->base.speed = SPEED_UNKNOWN;
cmd->base.duplex = DUPLEX_UNKNOWN;
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net] nfp: update ethtool reporting of pauseframe control
2021-08-03 10:39 [PATCH net] nfp: update ethtool reporting of pauseframe control Simon Horman
@ 2021-08-03 12:00 ` patchwork-bot+netdevbpf
2021-08-03 15:03 ` Andrew Lunn
1 sibling, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-08-03 12:00 UTC (permalink / raw)
To: Simon Horman; +Cc: davem, kuba, netdev, oss-drivers, fei.qin, louis.peens
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Tue, 3 Aug 2021 12:39:11 +0200 you wrote:
> From: Fei Qin <fei.qin@corigine.com>
>
> Pauseframe control is set to symmetric mode by default on the NFP.
> Pause frames can not be configured through ethtool now, but ethtool can
> report the supported mode.
>
> Fixes: 265aeb511bd5 ("nfp: add support for .get_link_ksettings()")
> Signed-off-by: Fei Qin <fei.qin@corigine.com>
> Signed-off-by: Louis Peens <louis.peens@corigine.com>
> Signed-off-by: Simon Horman <simon.horman@corigine.com>
>
> [...]
Here is the summary with links:
- [net] nfp: update ethtool reporting of pauseframe control
https://git.kernel.org/netdev/net/c/9fdc5d85a8fe
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] nfp: update ethtool reporting of pauseframe control
2021-08-03 10:39 [PATCH net] nfp: update ethtool reporting of pauseframe control Simon Horman
2021-08-03 12:00 ` patchwork-bot+netdevbpf
@ 2021-08-03 15:03 ` Andrew Lunn
2021-08-03 15:50 ` Simon Horman
1 sibling, 1 reply; 6+ messages in thread
From: Andrew Lunn @ 2021-08-03 15:03 UTC (permalink / raw)
To: Simon Horman
Cc: David Miller, Jakub Kicinski, netdev, oss-drivers, Fei Qin, Louis Peens
On Tue, Aug 03, 2021 at 12:39:11PM +0200, Simon Horman wrote:
> From: Fei Qin <fei.qin@corigine.com>
>
> Pauseframe control is set to symmetric mode by default on the NFP.
> Pause frames can not be configured through ethtool now, but ethtool can
> report the supported mode.
>
> Fixes: 265aeb511bd5 ("nfp: add support for .get_link_ksettings()")
> Signed-off-by: Fei Qin <fei.qin@corigine.com>
> Signed-off-by: Louis Peens <louis.peens@corigine.com>
> Signed-off-by: Simon Horman <simon.horman@corigine.com>
> ---
> drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> index 1b482446536d..8803faadd302 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> @@ -286,6 +286,8 @@ nfp_net_get_link_ksettings(struct net_device *netdev,
>
> /* Init to unknowns */
> ethtool_link_ksettings_add_link_mode(cmd, supported, FIBRE);
> + ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
> + ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
Hi Simon
Does it act on the results of the pause auto-neg? If the link peer
says it does not support pause, will it turn pause off?
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] nfp: update ethtool reporting of pauseframe control
2021-08-03 15:03 ` Andrew Lunn
@ 2021-08-03 15:50 ` Simon Horman
2021-08-06 9:38 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2021-08-03 15:50 UTC (permalink / raw)
To: Andrew Lunn
Cc: David Miller, Jakub Kicinski, netdev, oss-drivers, Fei Qin, Louis Peens
On Tue, Aug 03, 2021 at 05:03:33PM +0200, Andrew Lunn wrote:
> On Tue, Aug 03, 2021 at 12:39:11PM +0200, Simon Horman wrote:
> > From: Fei Qin <fei.qin@corigine.com>
> >
> > Pauseframe control is set to symmetric mode by default on the NFP.
> > Pause frames can not be configured through ethtool now, but ethtool can
> > report the supported mode.
> >
> > Fixes: 265aeb511bd5 ("nfp: add support for .get_link_ksettings()")
> > Signed-off-by: Fei Qin <fei.qin@corigine.com>
> > Signed-off-by: Louis Peens <louis.peens@corigine.com>
> > Signed-off-by: Simon Horman <simon.horman@corigine.com>
> > ---
> > drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > index 1b482446536d..8803faadd302 100644
> > --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > @@ -286,6 +286,8 @@ nfp_net_get_link_ksettings(struct net_device *netdev,
> >
> > /* Init to unknowns */
> > ethtool_link_ksettings_add_link_mode(cmd, supported, FIBRE);
> > + ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
> > + ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
>
> Hi Simon
>
> Does it act on the results of the pause auto-neg? If the link peer
> says it does not support pause, will it turn pause off?
Thanks Andrew,
I'll try and get an answer to that question for you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] nfp: update ethtool reporting of pauseframe control
2021-08-03 15:50 ` Simon Horman
@ 2021-08-06 9:38 ` Simon Horman
2021-08-07 2:17 ` Andrew Lunn
0 siblings, 1 reply; 6+ messages in thread
From: Simon Horman @ 2021-08-06 9:38 UTC (permalink / raw)
To: Andrew Lunn
Cc: David Miller, Jakub Kicinski, netdev, oss-drivers, Fei Qin, Louis Peens
On Tue, Aug 03, 2021 at 05:50:26PM +0200, Simon Horman wrote:
> On Tue, Aug 03, 2021 at 05:03:33PM +0200, Andrew Lunn wrote:
> > On Tue, Aug 03, 2021 at 12:39:11PM +0200, Simon Horman wrote:
> > > From: Fei Qin <fei.qin@corigine.com>
> > >
> > > Pauseframe control is set to symmetric mode by default on the NFP.
> > > Pause frames can not be configured through ethtool now, but ethtool can
> > > report the supported mode.
> > >
> > > Fixes: 265aeb511bd5 ("nfp: add support for .get_link_ksettings()")
> > > Signed-off-by: Fei Qin <fei.qin@corigine.com>
> > > Signed-off-by: Louis Peens <louis.peens@corigine.com>
> > > Signed-off-by: Simon Horman <simon.horman@corigine.com>
> > > ---
> > > drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 2 ++
> > > 1 file changed, 2 insertions(+)
> > >
> > > diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > > index 1b482446536d..8803faadd302 100644
> > > --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > > +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > > @@ -286,6 +286,8 @@ nfp_net_get_link_ksettings(struct net_device *netdev,
> > >
> > > /* Init to unknowns */
> > > ethtool_link_ksettings_add_link_mode(cmd, supported, FIBRE);
> > > + ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
> > > + ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
> >
> > Hi Simon
> >
> > Does it act on the results of the pause auto-neg? If the link peer
> > says it does not support pause, will it turn pause off?
>
> Thanks Andrew,
>
> I'll try and get an answer to that question for you.
Hi Andrew,
The simple answer to those questions is no.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] nfp: update ethtool reporting of pauseframe control
2021-08-06 9:38 ` Simon Horman
@ 2021-08-07 2:17 ` Andrew Lunn
0 siblings, 0 replies; 6+ messages in thread
From: Andrew Lunn @ 2021-08-07 2:17 UTC (permalink / raw)
To: Simon Horman
Cc: David Miller, Jakub Kicinski, netdev, oss-drivers, Fei Qin, Louis Peens
On Fri, Aug 06, 2021 at 11:38:57AM +0200, Simon Horman wrote:
> On Tue, Aug 03, 2021 at 05:50:26PM +0200, Simon Horman wrote:
> > On Tue, Aug 03, 2021 at 05:03:33PM +0200, Andrew Lunn wrote:
> > > On Tue, Aug 03, 2021 at 12:39:11PM +0200, Simon Horman wrote:
> > > > From: Fei Qin <fei.qin@corigine.com>
> > > >
> > > > Pauseframe control is set to symmetric mode by default on the NFP.
> > > > Pause frames can not be configured through ethtool now, but ethtool can
> > > > report the supported mode.
> > > >
> > > > Fixes: 265aeb511bd5 ("nfp: add support for .get_link_ksettings()")
> > > > Signed-off-by: Fei Qin <fei.qin@corigine.com>
> > > > Signed-off-by: Louis Peens <louis.peens@corigine.com>
> > > > Signed-off-by: Simon Horman <simon.horman@corigine.com>
> > > > ---
> > > > drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 2 ++
> > > > 1 file changed, 2 insertions(+)
> > > >
> > > > diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > > > index 1b482446536d..8803faadd302 100644
> > > > --- a/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > > > +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c
> > > > @@ -286,6 +286,8 @@ nfp_net_get_link_ksettings(struct net_device *netdev,
> > > >
> > > > /* Init to unknowns */
> > > > ethtool_link_ksettings_add_link_mode(cmd, supported, FIBRE);
> > > > + ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
> > > > + ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
> > >
> > > Hi Simon
> > >
> > > Does it act on the results of the pause auto-neg? If the link peer
> > > says it does not support pause, will it turn pause off?
> >
> > Thanks Andrew,
> >
> > I'll try and get an answer to that question for you.
>
> Hi Andrew,
>
> The simple answer to those questions is no.
Hi Simon
Then please send a patch removing Pause from advertising, and ensure
your PHY, SERDES etc, does not advertise it.
It seems like all the smart NICs get pause wrong.
Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-08-07 2:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-03 10:39 [PATCH net] nfp: update ethtool reporting of pauseframe control Simon Horman
2021-08-03 12:00 ` patchwork-bot+netdevbpf
2021-08-03 15:03 ` Andrew Lunn
2021-08-03 15:50 ` Simon Horman
2021-08-06 9:38 ` Simon Horman
2021-08-07 2:17 ` Andrew Lunn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.