From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6339C4320A for ; Fri, 6 Aug 2021 11:52:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 865E160EBC for ; Fri, 6 Aug 2021 11:52:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245727AbhHFLw0 (ORCPT ); Fri, 6 Aug 2021 07:52:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231811AbhHFLwX (ORCPT ); Fri, 6 Aug 2021 07:52:23 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C86ADC061798 for ; Fri, 6 Aug 2021 04:52:07 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id u21-20020a17090a8915b02901782c36f543so13462268pjn.4 for ; Fri, 06 Aug 2021 04:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=asA0Ub0/xhYqLYHlNNxTcENpmvj49OeKJZ/JEYJFvM8=; b=q5BdQhFDmEyv26B/H0n63ZK+Rh4G56toYP/AgcY0rIGb7YNTEBvTtlBbPPY4YL435M uDmaeNThxx82CNOVC7yCNskVuOWKS3thkxWhtt0IiCvcelIpuzCsT8sj5NOc+n9WR7Lu 28KhvZQBAG1VKQMS60AonYBFj9xUvAB3Z8q++0I+m7GqKQbNXq1dVkGgesNK4dXFk6Z1 UWH7VX9D1BW/mxSSR4XOn+d1UxnU1G3ubBwhx+RYlePTH9hToSc5MYgtp7eONJ07HNCA ODs124Bw3SnnGLPEg5o7LFkNzlIMD7wmC2iljqLroSya7nRCQ/Lmk8e3ta1QhBmxrst1 ypJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=asA0Ub0/xhYqLYHlNNxTcENpmvj49OeKJZ/JEYJFvM8=; b=Xf+RRZx9vcw+2p7BBWgzWz3q8ep+Avs7e/C65gyfkfb/r1pfq+X8geXL4eRWwn+jb6 lqBTZhECiE+wla9tqTA9g6ZveudkizrsC7XzcIoJ9ABWt2iSNfWgnPtRuhJNQBAlE5zc Mne2du2K9dIBU1VDS0OHg79AwD7ZWoenxul3pZ/7HT7Q9hgJt8R09ESCemZ5pnIc1MAl p1bHbXt0pOgguxljtD3QCOwRA0CGywslXeZZmjtNLAPl/bOpdH/wGSuuIyYqNZSbL2bJ COXM2P6oi+wfB93bmojEzn4R/eI4v6PcDoZNSIJ9+i40MOFBgow7u6e04dpeGDibJ+/b 0+Qw== X-Gm-Message-State: AOAM530t/9o8n0NjvrZcov99pOoUFzzwpsrOrnRkNxiiKH1F5h71EjIl CzWzxl+LET0/wUyID11Qrv+hwQ== X-Google-Smtp-Source: ABdhPJyNuw9EDtxDCBskyq1NRyT0OJ02HnLnshfcel7lcpgJY4HHIVXVd9fMs6F7JIEw59fFFQDS6A== X-Received: by 2002:a17:90a:404a:: with SMTP id k10mr10147405pjg.145.1628250727264; Fri, 06 Aug 2021 04:52:07 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([210.0.159.74]) by smtp.gmail.com with ESMTPSA id o8sm12735737pjh.20.2021.08.06.04.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Aug 2021 04:52:06 -0700 (PDT) Date: Fri, 6 Aug 2021 19:52:00 +0800 From: Leo Yan To: James Clark Cc: acme@kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, al.grant@arm.com, suzuki.poulose@arm.com, anshuman.khandual@arm.com, mike.leach@linaro.org, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 6/6] perf cs-etm: Print the decoder name Message-ID: <20210806115200.GD68808@leoy-ThinkPad-X240s> References: <20210721090706.21523-1-james.clark@arm.com> <20210721090706.21523-7-james.clark@arm.com> <20210731073037.GF7437@leoy-ThinkPad-X240s> <077ebe58-f692-9adb-9cb5-ed35a9b508c1@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <077ebe58-f692-9adb-9cb5-ed35a9b508c1@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 06, 2021 at 10:43:25AM +0100, James Clark wrote: > On 31/07/2021 08:30, Leo Yan wrote: > >> @@ -658,7 +658,7 @@ cs_etm_decoder__create_etm_decoder(struct cs_etm_decoder_params *d_params, > >> > >> return 0; > >> } else if (d_params->operation == CS_ETM_OPERATION_PRINT) { > >> - if (ocsd_dt_create_decoder(decoder->dcd_tree, decoder_name, > >> + if (ocsd_dt_create_decoder(decoder->dcd_tree, decoder->decoder_name, > >> OCSD_CREATE_FLG_PACKET_PROC, > >> trace_config, &csid)) > >> return -1; > >> @@ -790,3 +790,8 @@ void cs_etm_decoder__free(struct cs_etm_decoder *decoder) > >> decoder->dcd_tree = NULL; > >> free(decoder); > >> } > >> + > >> +const char *cs_etm_decoder__get_name(struct cs_etm_decoder *decoder) > >> +{ > >> + return decoder->decoder_name; > >> +} > > Maybe can consider to place this function into the header file with > > "static inline" specifier. > > I tried this, but because the struct is defined in the .c file it can't > be done without moving the struct to the header. It's also only used > for the --dump-raw-trace path so performance isn't critical anyway. It's fine to keep current patch, and thanks for trying. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9A07C4338F for ; Fri, 6 Aug 2021 11:53:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7DCC60FE7 for ; Fri, 6 Aug 2021 11:53:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A7DCC60FE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4fP7hhO4hzk7q5kY96ZG2Lm91qTtXWp0Z6WhNQjsghE=; b=UCCR6fuIirWirW Ss10OM8kMAerFwERBJKkSeKsX2K5uRli7jhpB6BVWkYBrV6RZ52ekrU9TmJJCIG/+OtBgS+eTKFxf irNjHlsyi28w4yoe5fy+frhOdEIwZIf8GlhCtcOREz2HJ1i0VokBu3WegcnAnJN/ale7pgZNIqgPo C7PIC7AHYwJbQs8cOWVdNG5S9UdYsnoW6dcmnMDQWv7QPReDRik8KP7HhPgwJXsSMmpuMOik7r78c PmeLv5cdFXPkcbjFxFw+OH1OmkWo/2zWpMMAW4dQXUQ8iHu8Q4dz/XzbZtNgbhD09uWmXbgVI+5Oi s/SFUYVlOTdEyvlDOotw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mByOa-00CNkO-LI; Fri, 06 Aug 2021 11:52:12 +0000 Received: from mail-pj1-x1031.google.com ([2607:f8b0:4864:20::1031]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mByOX-00CNjb-2O for linux-arm-kernel@lists.infradead.org; Fri, 06 Aug 2021 11:52:10 +0000 Received: by mail-pj1-x1031.google.com with SMTP id u21-20020a17090a8915b02901782c36f543so13462266pjn.4 for ; Fri, 06 Aug 2021 04:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=asA0Ub0/xhYqLYHlNNxTcENpmvj49OeKJZ/JEYJFvM8=; b=q5BdQhFDmEyv26B/H0n63ZK+Rh4G56toYP/AgcY0rIGb7YNTEBvTtlBbPPY4YL435M uDmaeNThxx82CNOVC7yCNskVuOWKS3thkxWhtt0IiCvcelIpuzCsT8sj5NOc+n9WR7Lu 28KhvZQBAG1VKQMS60AonYBFj9xUvAB3Z8q++0I+m7GqKQbNXq1dVkGgesNK4dXFk6Z1 UWH7VX9D1BW/mxSSR4XOn+d1UxnU1G3ubBwhx+RYlePTH9hToSc5MYgtp7eONJ07HNCA ODs124Bw3SnnGLPEg5o7LFkNzlIMD7wmC2iljqLroSya7nRCQ/Lmk8e3ta1QhBmxrst1 ypJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=asA0Ub0/xhYqLYHlNNxTcENpmvj49OeKJZ/JEYJFvM8=; b=fvngUfspqMJBDRun2lLDzRsmyVjRn6V7UHKiRW6g24Zrdlm+PH13LKBipeWNaSuct0 Erz2t5fsWuxbk8yOo9GGyOpsdOWi8ZyRAHQAk6hIMRwUb1SEXKUJo9qHxgffXsrSCX9/ zl/2E5HGREsjRN0gLSPlkCMttZpvZCP87shK4WUSo81ucdUY//6hBIBmQ5Rirg+4kkNI wTL2CJBAkVVX4a96oY1CEfiviWSwThVvDHs/sdQbMVTf62xPTkWzsqalOc232IIws2BX HmVmyoNpTiWPIOLQV0Ll25ecWDnFj+ubvJw7POWTVxPPrERUultgNPeUsrEBtfg7JW6S CHJA== X-Gm-Message-State: AOAM533doWPyUUo0kEWNwIHJUhlq7F0qfMnWxsAKi71BT5mJ5YYn6P4s +FDSvpf6VM1Hmrs4QDT2WD+4gQ== X-Google-Smtp-Source: ABdhPJyNuw9EDtxDCBskyq1NRyT0OJ02HnLnshfcel7lcpgJY4HHIVXVd9fMs6F7JIEw59fFFQDS6A== X-Received: by 2002:a17:90a:404a:: with SMTP id k10mr10147405pjg.145.1628250727264; Fri, 06 Aug 2021 04:52:07 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([210.0.159.74]) by smtp.gmail.com with ESMTPSA id o8sm12735737pjh.20.2021.08.06.04.52.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Aug 2021 04:52:06 -0700 (PDT) Date: Fri, 6 Aug 2021 19:52:00 +0800 From: Leo Yan To: James Clark Cc: acme@kernel.org, mathieu.poirier@linaro.org, coresight@lists.linaro.org, al.grant@arm.com, suzuki.poulose@arm.com, anshuman.khandual@arm.com, mike.leach@linaro.org, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH 6/6] perf cs-etm: Print the decoder name Message-ID: <20210806115200.GD68808@leoy-ThinkPad-X240s> References: <20210721090706.21523-1-james.clark@arm.com> <20210721090706.21523-7-james.clark@arm.com> <20210731073037.GF7437@leoy-ThinkPad-X240s> <077ebe58-f692-9adb-9cb5-ed35a9b508c1@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <077ebe58-f692-9adb-9cb5-ed35a9b508c1@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210806_045209_159399_93993F50 X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 06, 2021 at 10:43:25AM +0100, James Clark wrote: > On 31/07/2021 08:30, Leo Yan wrote: > >> @@ -658,7 +658,7 @@ cs_etm_decoder__create_etm_decoder(struct cs_etm_decoder_params *d_params, > >> > >> return 0; > >> } else if (d_params->operation == CS_ETM_OPERATION_PRINT) { > >> - if (ocsd_dt_create_decoder(decoder->dcd_tree, decoder_name, > >> + if (ocsd_dt_create_decoder(decoder->dcd_tree, decoder->decoder_name, > >> OCSD_CREATE_FLG_PACKET_PROC, > >> trace_config, &csid)) > >> return -1; > >> @@ -790,3 +790,8 @@ void cs_etm_decoder__free(struct cs_etm_decoder *decoder) > >> decoder->dcd_tree = NULL; > >> free(decoder); > >> } > >> + > >> +const char *cs_etm_decoder__get_name(struct cs_etm_decoder *decoder) > >> +{ > >> + return decoder->decoder_name; > >> +} > > Maybe can consider to place this function into the header file with > > "static inline" specifier. > > I tried this, but because the struct is defined in the .c file it can't > be done without moving the struct to the header. It's also only used > for the --dump-raw-trace path so performance isn't critical anyway. It's fine to keep current patch, and thanks for trying. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel