From: Herbert Xu <herbert@gondor.apana.org.au>
To: Tony Lindgren <tony@atomide.com>
Cc: "David S . Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
linux-crypto@vger.kernel.org, Lokesh Vutla <lokeshvutla@ti.com>,
Tero Kristo <kristo@kernel.org>
Subject: Re: [PATCH 1/6] crypto: omap-sham - clear dma flags only after omap_sham_update_dma_stop()
Date: Fri, 6 Aug 2021 20:14:26 +0800 [thread overview]
Message-ID: <20210806121426.GA25554@gondor.apana.org.au> (raw)
In-Reply-To: <20210727102339.49141-1-tony@atomide.com>
On Tue, Jul 27, 2021 at 01:23:34PM +0300, Tony Lindgren wrote:
> We should not clear FLAGS_DMA_ACTIVE before omap_sham_update_dma_stop() is
> done calling dma_unmap_sg(). We already clear FLAGS_DMA_ACTIVE at the
> end of omap_sham_update_dma_stop().
>
> The early clearing of FLAGS_DMA_ACTIVE is not causing issues as we do not
> need to defer anything based on FLAGS_DMA_ACTIVE currently. So this can be
> applied as clean-up.
>
> Cc: Lokesh Vutla <lokeshvutla@ti.com>
> Cc: Tero Kristo <kristo@kernel.org>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
> drivers/crypto/omap-sham.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2021-08-06 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 10:23 [PATCH 1/6] crypto: omap-sham - clear dma flags only after omap_sham_update_dma_stop() Tony Lindgren
2021-07-27 10:23 ` [PATCH 2/6] crypto: omap-sham - initialize req only after omap_sham_hw_init() Tony Lindgren
2021-07-27 10:23 ` [PATCH 3/6] crypto: omap-sham - add missing pm_runtime_dontuse_autosuspend() Tony Lindgren
2021-07-27 10:23 ` [PATCH 4/6] crypto: omap-sham - drop old hw_init and unused FLAGS_INIT Tony Lindgren
2021-07-27 10:23 ` [PATCH 5/6] crypto: omap-sham - drop suspend and resume functions Tony Lindgren
2021-07-27 10:23 ` [PATCH 6/6] crypto: omap-sham - drop pm_runtime_irqsafe() usage Tony Lindgren
2021-08-06 12:14 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806121426.GA25554@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=kristo@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.