All of lore.kernel.org
 help / color / mirror / Atom feed
From: Igor Mammedov <imammedo@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
	jusual@redhat.com,
	"Richard Henderson" <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org, "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Ani Sinha" <ani@anisinha.ca>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: Re: [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host
Date: Fri, 6 Aug 2021 12:33:26 +0200	[thread overview]
Message-ID: <20210806123326.284595b3@redhat.com> (raw)
In-Reply-To: <20210805180915-mutt-send-email-mst@kernel.org>

On Thu, 5 Aug 2021 18:13:21 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Thu, Aug 05, 2021 at 07:42:35PM +0530, Ani Sinha wrote:
> > Also to be noted that there is a stub for acpi_get_i386_pci_host() which
> > simply returns NULL. This activates when CONFIG_PC is disabled. It is this
> > stub that gets called for mips and hence the check for non-null host is
> > needed in acpi_set_pci_info() function.
> >   
> 
> Frankly this is generating more discussion that it's worth imho.
> IMHO these tweaks will bring little benefit.
> Igor do you feel differently?
replacing 'ifs' with assert is a bit cleaner, but if we are cleaning
it up we should clean up it properly without leaving unnecessary
code around.
That's why I suggested to separate x86 specific parts from piix4.
Philippe (CCed) even have reported issues ACPI parts were
causing on MIPS machines, so if someone is willing to untangle
the mess it might be worth the shot.




  reply	other threads:[~2021-08-06 10:35 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-26 16:57 [PATCH v3] hw/acpi: add an assertion check for non-null return from acpi_get_i386_pci_host Ani Sinha
2021-07-28 13:03 ` Michael S. Tsirkin
2021-07-28 14:12   ` Ani Sinha
2021-07-29  4:38   ` Ani Sinha
2021-07-29  6:10     ` Ani Sinha
2021-08-03 11:34       ` Ani Sinha
2021-08-05  9:15 ` Igor Mammedov
2021-08-05 12:09   ` Ani Sinha
2021-08-05 12:59     ` Ani Sinha
2021-08-05 14:12       ` Ani Sinha
2021-08-05 22:13         ` Michael S. Tsirkin
2021-08-06 10:33           ` Igor Mammedov [this message]
2021-08-06 10:37         ` Igor Mammedov
2021-08-06 10:52           ` Ani Sinha
2021-08-06 14:01             ` Philippe Mathieu-Daudé
2021-08-06 16:38               ` Philippe Mathieu-Daudé
2021-08-09 16:21                 ` Ani Sinha
2021-08-11 15:00               ` Ani Sinha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210806123326.284595b3@redhat.com \
    --to=imammedo@redhat.com \
    --cc=ani@anisinha.ca \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=jusual@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.