From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2BB7C432BE for ; Fri, 6 Aug 2021 12:47:53 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D1EA61184 for ; Fri, 6 Aug 2021 12:47:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0D1EA61184 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id ED21082F3D; Fri, 6 Aug 2021 14:47:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="ibMzqayz"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3C2B68310F; Fri, 6 Aug 2021 14:47:49 +0200 (CEST) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 3CB5582986 for ; Fri, 6 Aug 2021 14:47:46 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x831.google.com with SMTP id l24so6333207qtj.4 for ; Fri, 06 Aug 2021 05:47:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=sxCfZ7nJwi7fKq2vMPSTDkGSL4hRtJBAyp2ZJLdJlLc=; b=ibMzqayztVz2EwAk1VSX/SgLs7JM6ca9Di3iVBbQWV7DwBQYNTH33pIvjlRVGaQNZl JYZGRs/GgYykJexSElrPFTadJLgHixq4eCBbRZdbkNJcxmNe+DotQmb9fS/Fuic7Nh0O g8PAkvLs/DP70NFBslJmS6Zosk5rDYUkO53a4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=sxCfZ7nJwi7fKq2vMPSTDkGSL4hRtJBAyp2ZJLdJlLc=; b=MQhann0WrBUGtVaFrsRzKXDfK7FX1ftXiCYA0Gl0RSzwm5r7yBZoIaCQyqOjxTWci2 Gg0K7DyoouMG3Fsz20shEhKdWM2Z1iu7vVUq3RIEKYBgWC6/CP6ntnCHCyA1ZiJOC4Sq rxsXS3TL6BOLO125NLYgSQ7M0avSxHpvvC2tUyuYtnPsNSccEpm81E6MCoMUFHT9b9ac ZNtQIzQxwH7urqNb+PTPjac5nlAu/TinpGHxxcc3NgasTtpH46M+m2KN1LIRztIpvadZ gBWvg2lYfJrRfWuhZ6Mi1IZNjmhIE3Nhl3BCZde8xB00juEs5L31gRezDeAxLVJ85JX4 IIPA== X-Gm-Message-State: AOAM5322HX4OrxD1Y9c4j8vJNwklPjcUdj33TL/SGbDRL8s/MDyyHaod k4VPpJUT71Z3YszxeZEKoqcZhQ== X-Google-Smtp-Source: ABdhPJxNl+sWB5yPN7MN9kNY0mG6Yd59chu7fGZgiX9dcfEtmWBI2+bVGC1u4rXKQNwO6B94CKV6Cg== X-Received: by 2002:a05:622a:188c:: with SMTP id v12mr8679491qtc.309.1628254065038; Fri, 06 Aug 2021 05:47:45 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b01-cbda-91f5-8795-37c3-31a0.res6.spectrum.com. [2603:6081:7b01:cbda:91f5:8795:37c3:31a0]) by smtp.gmail.com with ESMTPSA id t124sm4596183qke.16.2021.08.06.05.47.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 06 Aug 2021 05:47:44 -0700 (PDT) Date: Fri, 6 Aug 2021 08:47:42 -0400 From: Tom Rini To: Mattijs Korpershoek Cc: Neil Armstrong , u-boot-amlogic@groups.io, u-boot@lists.denx.de, Guillaume La Roque Subject: Re: [PATCH 1/9] configs: meson64: permit redefining SYS_MALLOC_LEN Message-ID: <20210806124742.GW858@bill-the-cat> References: <20210805151728.422329-1-mkorpershoek@baylibre.com> <20210805151728.422329-2-mkorpershoek@baylibre.com> <20210805171601.GN858@bill-the-cat> <23fcf0b5-201c-7518-0113-f2397283b344@baylibre.com> <87pmurj57d.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="sBvc846/5FzkyDmz" Content-Disposition: inline In-Reply-To: <87pmurj57d.fsf@baylibre.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean --sBvc846/5FzkyDmz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 06, 2021 at 11:24:54AM +0200, Mattijs Korpershoek wrote: > Hi Tom, Neil, >=20 > Neil Armstrong writes: >=20 > > On 05/08/2021 19:16, Tom Rini wrote: > >> On Thu, Aug 05, 2021 at 06:20:53PM +0200, Neil Armstrong wrote: > >>> On 05/08/2021 17:17, Mattijs Korpershoek wrote: > >>>> Permit redefining SYS_MALLOC_LEN for board specific configs. > >>>> This is especially useful for Android with AVB, which requires a mal= loc > >>>> length of 128M. > >>>> > >>>> Signed-off-by: Guillaume La Roque > >>>> Signed-off-by: Mattijs Korpershoek > >>>> --- > >>>> include/configs/meson64.h | 2 ++ > >>>> 1 file changed, 2 insertions(+) > >>>> > >>>> diff --git a/include/configs/meson64.h b/include/configs/meson64.h > >>>> index fb7f16d148..f9bb0240d2 100644 > >>>> --- a/include/configs/meson64.h > >>>> +++ b/include/configs/meson64.h > >>>> @@ -32,7 +32,9 @@ > >>>> #define CONFIG_CPU_ARMV8 > >>>> #define CONFIG_REMAKE_ELF > >>>> #define CONFIG_SYS_MAXARGS 32 > >>>> +#ifndef CONFIG_SYS_MALLOC_LEN > >>>> #define CONFIG_SYS_MALLOC_LEN (32 << 20) > >>>> +#endif > >>>> #define CONFIG_SYS_CBSIZE 1024 > >>>> =20 > >>>> #define CONFIG_SYS_SDRAM_BASE 0 > >>>> > >>> > >>> Acked-by: Neil Armstrong > >>=20 > >> I prefer to see these as SZ_xxx, but also what's the minimum DRAM you'= re > >> going to see on a meson64 platform? And if it's 1GB or more, why not > >> just use 128MB for everyone? > >>=20 > > > > We can get down to 256MiB DRAM (very rare), but 512MiB is used on La Fr= ite. > In that case, I think it's more reasonable to keep the change as-is. > I'll send a v2 replacing (32 << 20) by SZ_32M tbh, using SZ_xxx isn't a big enough issue to v2 things over. --=20 Tom --sBvc846/5FzkyDmz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmENL24ACgkQFHw5/5Y0 tywsaQv+Ls1yWrAQ5vxJPs/hw6dugtHAVBniCQAAr+FlLOkv8NZH+M1URQTKdwek 32j6/BUaWEsani8K8CumN3ZckRq8x6Nvnl9LTqWTjNIBdbzfigPfTYCnTqZrQRWn VPWFWL7Vvh48taig5DZ4G8AWkkAJ44/Dap8Ufjk4iRS7XMb6QTOtjfesw3+XhIYN TRL+5L/7/TV8AIqcOoDMn6usS+hu327XqHEpsSZzfmIxUKVBN5ytKfIKUo1Z9NEZ ob/SNNwm9XiYx3qNlGsXnRdl/h0xQW66ViVov6LpsOX73pHOogsw4Je1y/LMj7p2 JIEjC92+x6ie+olhcG5uAjmYohIX68VB3D+NzRObHiIjsKqIYIewATEZTHFeWrSM fWHI260Hr98qsnrsH3jILztElepPAdKyhHyalDFpssrH6BxpsFEAP0KqKNnKuNgZ 2Km1Cub2hLhy6YQyakmi0D0wCFSNzBZHXOw/QpyXQX2X69IIbi5wML90RrKqu7fI t47Psmcn =8G5T -----END PGP SIGNATURE----- --sBvc846/5FzkyDmz--